Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp1324990pxb; Fri, 6 Nov 2020 06:56:54 -0800 (PST) X-Google-Smtp-Source: ABdhPJwjeFenGwjmV+JhtA1etiJvS3RMJELqe4iYeg6ekRqT/GehYuJIDBdpYT7egz1zpR2njbfP X-Received: by 2002:a17:906:5fd9:: with SMTP id k25mr2600607ejv.166.1604674614247; Fri, 06 Nov 2020 06:56:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604674614; cv=none; d=google.com; s=arc-20160816; b=pR4YDEByAAH18tqWh0PcgbZ58w6UuX6dcziS9gdNUxf7dOeBW+7rB8ahDlLEcvlBaP z2F0oOH/XyY19yGCTGmPbiuhMMB0f0xXzswXixXNrRIJFD55Df15jEES8PElSkeSxu/0 4bPa72w8DYj2BQ+QAEOQYtTQ3kBTExLuFesAraHQ+/A02/veUWaSGrw3qsN6VUn/EQiU 1FZhey2ImTINoQVm53/CO+l7RvNld4sZAAQXIaYsx69zH1BcNprbjlF4OPqM21vJiW+s 7FZTETBQn34P/nUf5TsnrVXrdN0x1NXqk1KA3IsZu8g2Z8N20ujm/zdPld7n/+u7w1+T +VhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:content-transfer-encoding:mime-version :message-id:date:subject:cc:from; bh=x2rRgfyY/KXyuivuXMp3I4aTZ0dEVwQ51RNk4G6F0go=; b=ENNhwNIyrCsYov5D5kCsQywcS0I9EwlUrLboyOSiz2SzPcG0+6UETbnR9N5E07+A4G 0NImZDzzBylaCeD6gr6ZbUbSW59crDz2iapqTOQdPDabbDg2N4xpYIlEqlBcaMT7EeiN yb4WYcOYRSKYhIrxWIlQsVJruZ9rwHwh/Sx3J/g6OnRN9joEVfhD2H8boihvcEdbqdKx QMkx0tAJqbMqjX6OV9eZSlegObx91JFQqz1VmzHTs9ekCczDT/VZb9oIv7XvuoONS1U7 2Ggyfd8C83829K6Tv4+rYKlons8+2AzDHTUNJi4aPqduMk8dEgjRu4iyZHSugIRwz7K6 FzNg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h14si1018893ejs.645.2020.11.06.06.56.30; Fri, 06 Nov 2020 06:56:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727055AbgKFOzF (ORCPT + 99 others); Fri, 6 Nov 2020 09:55:05 -0500 Received: from out30-131.freemail.mail.aliyun.com ([115.124.30.131]:45987 "EHLO out30-131.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726422AbgKFOzF (ORCPT ); Fri, 6 Nov 2020 09:55:05 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R941e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04357;MF=alex.shi@linux.alibaba.com;NM=1;PH=DS;RN=3;SR=0;TI=SMTPD_---0UERBQOx_1604674489; Received: from aliy80.localdomain(mailfrom:alex.shi@linux.alibaba.com fp:SMTPD_---0UERBQOx_1604674489) by smtp.aliyun-inc.com(127.0.0.1); Fri, 06 Nov 2020 22:54:49 +0800 From: Alex Shi Cc: Steven Rostedt , Ingo Molnar , linux-kernel@vger.kernel.org Subject: [PATCH] ftrace: remove unused varible 'ret' Date: Fri, 6 Nov 2020 22:54:46 +0800 Message-Id: <1604674486-52350-1-git-send-email-alex.shi@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 'ret' in 2 functions are not used. and one of them is a void function. So remove them to avoid gcc warning: kernel/trace/ftrace.c:4166:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] kernel/trace/ftrace.c:5571:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] Signed-off-by: Alex Shi Cc: Steven Rostedt Cc: Ingo Molnar Cc: linux-kernel@vger.kernel.org --- kernel/trace/ftrace.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c index 8185f7240095..466b8359cbad 100644 --- a/kernel/trace/ftrace.c +++ b/kernel/trace/ftrace.c @@ -4163,7 +4163,6 @@ static void process_mod_list(struct list_head *head, struct ftrace_ops *ops, struct ftrace_hash **orig_hash, *new_hash; LIST_HEAD(process_mods); char *func; - int ret; mutex_lock(&ops->func_hash->regex_lock); @@ -4216,7 +4215,7 @@ static void process_mod_list(struct list_head *head, struct ftrace_ops *ops, mutex_lock(&ftrace_lock); - ret = ftrace_hash_move_and_update_ops(ops, orig_hash, + ftrace_hash_move_and_update_ops(ops, orig_hash, new_hash, enable); mutex_unlock(&ftrace_lock); @@ -5568,7 +5567,6 @@ int ftrace_regex_release(struct inode *inode, struct file *file) struct ftrace_hash **orig_hash; struct trace_parser *parser; int filter_hash; - int ret; if (file->f_mode & FMODE_READ) { iter = m->private; @@ -5596,7 +5594,7 @@ int ftrace_regex_release(struct inode *inode, struct file *file) orig_hash = &iter->ops->func_hash->notrace_hash; mutex_lock(&ftrace_lock); - ret = ftrace_hash_move_and_update_ops(iter->ops, orig_hash, + ftrace_hash_move_and_update_ops(iter->ops, orig_hash, iter->hash, filter_hash); mutex_unlock(&ftrace_lock); } else { -- 1.8.3.1