Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp1347004pxb;
        Fri, 6 Nov 2020 07:25:30 -0800 (PST)
X-Google-Smtp-Source: ABdhPJyuRNDEgni7fk7R2nTnBgCJMlOuaddCIsf1z4Xl8fY/lofZw7wk9ME3lva/6ukfWF+m0oPm
X-Received: by 2002:a17:906:c298:: with SMTP id r24mr2563331ejz.76.1604676330566;
        Fri, 06 Nov 2020 07:25:30 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1604676330; cv=none;
        d=google.com; s=arc-20160816;
        b=EpoxOmY+ijDtuFtaQjm2Zg8J2FA36rkDxj2sV7RLPwJDEG/JlT0Hv4w+lXb+f/e4dz
         YiT+DQSk3obWmxG3tmV/tlycnggM9WEVi8eX7aKl46peSWioubNY2x/MEiX+G/In4UEj
         aubDC9LdlUU92X+hpfLccvG2V8KX/Xf0INhy4wOFbT50CuOscq6SwedhV3bybMqUqqy9
         cHbjXsVjCPjWStYyLo5P1jZcwaU8kPM/EOty1AT6HYAVurqDWwQWrxR4PQewIKs/nka6
         MpdimA0fNtdV1c7imOILmW3WFC6dbhP2ufhWjDISXNgg6lHzOc8pGDLZyR0FqqlZxTd1
         PrSA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:in-reply-to:content-disposition:mime-version
         :references:message-id:subject:cc:to:from:date:dkim-signature;
        bh=4S5KHTu0b7/e9t7QGnVTVE/CYcplYeRZTP1PGG4sVWk=;
        b=T4hmLHWJgDsZBO83HCFaIZNyz/XNogkLPIzAzYroGxy5Ag91MGJdFuzet+n3XQN/nk
         N9H9pRB1FTw427sLEjdMMd/WJHop34jQ5+Xqf7UvijpjBYuYMp9RzDGOmGe7GKk0wNm5
         clFV6d63rPvoCqvvoPCgVyIVD639hxFRsqQF8pKREHkLOYnxfLqM3Ibz6FlYsmlwyUuG
         bF/Tir+T8HunBfqm38Wsax5he1ljl0esMPjOCjHLI/iu6SzUkUNc3nbZU7vbrtpIlRn4
         Qw9nMVe7F1aO9zr/iXdMrBeHh4gb81/mbwKYDh+QcCAcYe39k/zrBI3PGEKZb54II7an
         H6AQ==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@alien8.de header.s=dkim header.b=Tt+0MwXs;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id v26si1129961edr.571.2020.11.06.07.24.44;
        Fri, 06 Nov 2020 07:25:30 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@alien8.de header.s=dkim header.b=Tt+0MwXs;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727567AbgKFPW7 (ORCPT <rfc822;luigi.mantellini.ml@gmail.com>
        + 99 others); Fri, 6 Nov 2020 10:22:59 -0500
Received: from mail.skyhub.de ([5.9.137.197]:36956 "EHLO mail.skyhub.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1727639AbgKFPW7 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 6 Nov 2020 10:22:59 -0500
Received: from zn.tnic (p200300ec2f0d1f00a4cc36f619593225.dip0.t-ipconnect.de [IPv6:2003:ec:2f0d:1f00:a4cc:36f6:1959:3225])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 874C71EC03EA;
        Fri,  6 Nov 2020 16:22:57 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim;
        t=1604676178;
        h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
         to:to:cc:cc:mime-version:mime-version:content-type:content-type:
         content-transfer-encoding:in-reply-to:in-reply-to:  references:references;
        bh=4S5KHTu0b7/e9t7QGnVTVE/CYcplYeRZTP1PGG4sVWk=;
        b=Tt+0MwXsM/5V0Ja26+sniWCJzCuxTz/+HS9btYCJ3duW2v4yPgtiWlWibnfCKJt907/Ajm
        R+P2n/+E3rXsPeU0SHl6qekZFfKBZ7R6a5jyHuCmuyyYCMQkKmzQEYTseJpga3MRb7HtYH
        mZNCBhf1Tse+Qtd4UavjuhJqTqUjB4E=
Date:   Fri, 6 Nov 2020 16:22:44 +0100
From:   Borislav Petkov <bp@alien8.de>
To:     Hewenliang <hewenliang4@huawei.com>
Cc:     tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
        osandov@fb.com, rppt@kernel.org, lijiang@redhat.com,
        linux-kernel@vger.kernel.org, hushiyuan@huawei.com
Subject: Re: [PATCH] x86/kexec: Initialize the value of ident mapping offset
Message-ID: <20201106152244.GE14914@zn.tnic>
References: <20201106033005.2354-1-hewenliang4@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20201106033005.2354-1-hewenliang4@huawei.com>
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Nov 05, 2020 at 10:30:05PM -0500, Hewenliang wrote:
> From: hewenliang <hewenliang4@huawei.com>
> 
> It is necessary to initialize the value of ident mapping offset.

Why is it necessary?

> This can not only avoid using dirty data,

What happens to designated initializers when some of the members are not
explicitly mentioned?

Hint:

$ make arch/x86/kernel/machine_kexec_64.s

and look at that file before your patch.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette