Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 6 Nov 2020 19:23:00 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Saravana Kannan <saravanak@google.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Rafael J . Wysocki" <rafael@kernel.org>,
        Daniel Mentz <danielmentz@google.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Frank Rowand <frowand.list@gmail.com>
Subject: Re: [PATCH RFC] driver core: Ensure DT devices always have fwnode set
Message-ID: <20201106192300.GG49612@sirena.org.uk>
References: <20201106150747.31273-1-broonie@kernel.org>
 <CAGETcx-abGAgYrHM0jm6hVkrJ5KvfhK6gCZ4Y6RY0msPJDCuQg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="0z5c7mBtSy1wdr4F"
Content-Disposition: inline
In-Reply-To: <CAGETcx-abGAgYrHM0jm6hVkrJ5KvfhK6gCZ4Y6RY0msPJDCuQg@mail.gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk


--0z5c7mBtSy1wdr4F
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Nov 06, 2020 at 11:09:17AM -0800, Saravana Kannan wrote:

> If you want to do this in "one common place", then I think the way to
> do this is have include/linux/of.h provide something like:

> void of_set_device_of_node(dev, of_node)
> {
>     dev->of_node = of_node;
>     dev->fw_node = &of_node->fwnode;
>    /* bunch of other housekeeping like setting OF_POPULATED and doing
> proper of_node_get() */
>    // Passing NULL for of_node could undo all the above for dev->of_node.
> }

That also sounds good, particularly if we have a coccinelle spatch or
some other mechanism that enforced the usage of the function where
appropriate, my main concern is making sure that we do something which
ensures that the boilerplate stuff is handled.

--0z5c7mBtSy1wdr4F
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl+lopMACgkQJNaLcl1U
h9DUQwf/V0RSkpyIL4FEcj3BUW/M22qomf9RcalybT/vs4vdIQaiAlhX/OM6dX/1
Wfrq3dNmTQNqiwaWALRSYOUDZUAf/SGkT9uAzLCNDq1U3Y58CCBVxm04/olb7p97
b6PIMdNXjeUlnxC+llq5JsRxzkKpvXF0kcKiCIAy61OsuVRRlzF30GXNejZIu+v9
H+qlGDQBIgR+MKHilNDx8ejYGxTtxtttd6MdBzQxMpop4QK/lddpdtaWOHZWh7mP
mtO7T9fWCDM2X5flpLQFZllLjtaVAd3JhDt4vhlgpuevBnUQ9o7nmBJZhapuYziP
OJwsk/SKxB7xHHGnoeAxKkIzupQ1jA==
=Jznh
-----END PGP SIGNATURE-----

--0z5c7mBtSy1wdr4F--