Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp1579236pxb;
        Fri, 6 Nov 2020 13:29:37 -0800 (PST)
X-Google-Smtp-Source: ABdhPJybQu9W6XGeJaR1AsmkPnbNWpwgrCiT9uVY6oEnBfQTXqkl2jEEMD9AwpXlrjXrkSmFDceW
X-Received: by 2002:aa7:c44d:: with SMTP id n13mr4322338edr.138.1604698176831;
        Fri, 06 Nov 2020 13:29:36 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1604698176; cv=none;
        d=google.com; s=arc-20160816;
        b=uK/rqbI86hVV87aectFGIz9b4XteKY6sZ3kZCr04e/5Ai6huJYrp1k3J74pljf8pFE
         igupDr6hfWF31xao3Q4zuk6nM0a1zLxAc0i+s0xt8qCkpJdhF/GrJxvErdBrPOo0cvFT
         Yniwg6iYLW38o2mgjWOFhqEjQBvi4hoNhtdxNOY83rbXGZu4Qp8ZAEqyxm7jVL9QdRNS
         2c7/pDkEhG5kthgCDab8x2B20cDu/e2KCPcjPs3Jl+Dpb6ldNDD2w43We7ExjTBfp9y+
         n8t8R8wPTEhnL+tkHuu0OtIhz8HgGHH4vbGYuiQfPhxTJGBfz5yXHM97qk5hYINaIkh0
         bClA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:dkim-signature:content-transfer-encoding
         :content-language:in-reply-to:mime-version:user-agent:date
         :message-id:from:references:cc:to:subject;
        bh=sJlHFFmh1FwR1Swhc5FD4UAS7VszQVSWU413enTyHH4=;
        b=I0Ri7zSKKC7fNmQZFljyFFgUVrYO3HGkfDRQgVdxb0AhXHRlOSd8xovDLgbJV9JU7g
         N2WZ2TYNYSrGaSN5vc+NHu0GJ5+9qw+qjxDX8L+LZgQvq7UORUBVwlFoAwzOs6c1RDkX
         OCmzMikpiK0XE2AH6jarkvBqNXs3OKvJyAlkgS50qHWd4QH6itPUxsN/xObLCuVfUkBI
         EdKqPB5FQeVlNgYTr9dgedYSLL2z07B0JQ66CmU93+SH3vqh1zobfHjtUIsHKSJ3xTJi
         jWRPnFWF5pYeuTnAerG7ygqnV8VIz59plf+YV4gxwhuj8wB7tskcVAgfvtXBB+4nK5vw
         C0bg==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=D+Hb3S3I;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id m2si1901625edp.487.2020.11.06.13.29.14;
        Fri, 06 Nov 2020 13:29:36 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=D+Hb3S3I;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1728055AbgKFV0x (ORCPT <rfc822;luigi.mantellini.ml@gmail.com>
        + 99 others); Fri, 6 Nov 2020 16:26:53 -0500
Received: from hqnvemgate25.nvidia.com ([216.228.121.64]:12456 "EHLO
        hqnvemgate25.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1725868AbgKFV0x (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 6 Nov 2020 16:26:53 -0500
Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, AES256-SHA)
        id <B5fa5bf9a0000>; Fri, 06 Nov 2020 13:26:50 -0800
Received: from rcampbell-dev.nvidia.com (172.20.13.39) by HQMAIL107.nvidia.com
 (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 6 Nov
 2020 21:26:50 +0000
Subject: Re: [PATCH v3 3/6] mm: support THP migration to device private memory
To:     Christoph Hellwig <hch@lst.de>
CC:     <linux-mm@kvack.org>, <nouveau@lists.freedesktop.org>,
        <linux-kselftest@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        "Jerome Glisse" <jglisse@redhat.com>,
        John Hubbard <jhubbard@nvidia.com>,
        "Alistair Popple" <apopple@nvidia.com>,
        Jason Gunthorpe <jgg@nvidia.com>,
        Bharata B Rao <bharata@linux.ibm.com>,
        Zi Yan <ziy@nvidia.com>,
        "Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
        Yang Shi <yang.shi@linux.alibaba.com>,
        Ben Skeggs <bskeggs@redhat.com>, Shuah Khan <shuah@kernel.org>,
        "Andrew Morton" <akpm@linux-foundation.org>
References: <20201106005147.20113-1-rcampbell@nvidia.com>
 <20201106005147.20113-4-rcampbell@nvidia.com> <20201106080322.GE31341@lst.de>
From:   Ralph Campbell <rcampbell@nvidia.com>
X-Nvconfidentiality: public
Message-ID: <a7b8b90c-09b7-2009-0784-908b61f61ef2@nvidia.com>
Date:   Fri, 6 Nov 2020 13:26:50 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.2.2
MIME-Version: 1.0
In-Reply-To: <20201106080322.GE31341@lst.de>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Originating-IP: [172.20.13.39]
X-ClientProxiedBy: HQMAIL107.nvidia.com (172.20.187.13) To
 HQMAIL107.nvidia.com (172.20.187.13)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1604698011; bh=sJlHFFmh1FwR1Swhc5FD4UAS7VszQVSWU413enTyHH4=;
        h=Subject:To:CC:References:From:X-Nvconfidentiality:Message-ID:Date:
         User-Agent:MIME-Version:In-Reply-To:Content-Type:Content-Language:
         Content-Transfer-Encoding:X-Originating-IP:X-ClientProxiedBy;
        b=D+Hb3S3IoeXUGY43+BDjeVkVQHFWtOWYZpKP/V1fcty+B82xJWfBYCbrNIRLcwd1N
         xHNxqb4t8k2I+/J1kKnnLsF5xZkxtH+JOsq7sBETw85okpdAVkV2cTPaH+3yzHWUQV
         0W2jqDyoUzaJGiP3EhfAPrA37NzlSLU284MbBQY8hK+AY5l7waP/BrPCk4U5cwfu4Q
         wclHRUc9XPKRGZCTe+xikUB3QYpdfkmjsK9FPg9F2qGpeePz9bHplQ7R35oDaNt1jg
         VQHbvDCCv9xArzhsLxgy1hTgi/8qcKTrJiwn4j7znBMrdvlFc6JKsA4ta7lEI7Yu/q
         ldJ63eePyEAMQ==
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 11/6/20 12:03 AM, Christoph Hellwig wrote:
> I hate the extra pin count magic here.  IMHO we really need to finish
> off the series to get rid of the extra references on the ZONE_DEVICE
> pages first.

First, thanks for the review comments.

I don't like the extra refcount either, that is why I tried to fix that up
before resending this series. However, you didn't like me just fixing the
refcount only for device private pages and I don't know the dax/pmem code
and peer-to-peer PCIe uses of ZONE_DEVICE pages well enough to say how
long it will take me to fix all the use cases.
So I wanted to make progress on the THP migration code in the mean time.