Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp1584623pxb; Fri, 6 Nov 2020 13:39:43 -0800 (PST) X-Google-Smtp-Source: ABdhPJx8q8Q9fQ3VDHk27LA1jf6QsJuqdKlC6d5RLkX64/zEc2rbqX+yNI0zY443c21Bbd73tY3h X-Received: by 2002:a05:6402:104d:: with SMTP id e13mr4088012edu.322.1604698783596; Fri, 06 Nov 2020 13:39:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604698783; cv=none; d=google.com; s=arc-20160816; b=zRfp8nshneLlft/lenVVvZQqszTLuIbZSYd9ozuZGQd2Wp2N6S6KVpOhHmiGksGBDQ yZtjyviIca0vl4+jByjFxJxRigkgLmNYlz51LvJsMUZ8axuokDmoNBUIu96YBJv9qto7 X8HRJL4ekRW7g4VEivjH8jeFqOUN0793XM+e50yJQ9Mi6yvMe7JqE5k4l0s4m8S1IQoR TnkZQ0Q1t3A75IZn3+/y8+K5fZ/+o5NROK2e4Ej7S6yyOnqIZHZpfScytPyefBro1QSS trT0d++QKr2AVtg3P0kmXkl9nebfM3ZHjUqBWAJ5oGHBlblss1mNJhEzvC8mVyFmDdaU fVfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=L9e594iGsPQazHtR8mr0tF4GNyBoavTbOlvYUU648dY=; b=EOsaCsYbJpKSMcJ3oax1J7Gtwe31ivM4vTAl/c0dYFni/aMOZO82ClEW7WAXnD4e3+ 0tjmYvrViC8l+YHQKw0Slsn5n4uxWPmeQhtVUCAtRDkMAwpTG0dbEJj3yI1BMyeNyRFt Ds4Mf1E3v8O4tlSdZl6NYu0XbDe3ju1PBFhOLHi/6b6xKtETxOBLUrHHFyyylTgarvBb KkfpvYBkFl/vDBq4xV8AKiFLxeNcHJEcJlgrwDqR0siyGhStPZcew1T9vv4QbeeSat/e jhVK9W49U2uvUMSdFPvImzTzYQEp7lLz8TBk5kxcY5Rt4EOp1/3th/VQd1Z4zDQx50lZ SXIQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=fQkMLtI3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lr3si2227792ejb.40.2020.11.06.13.39.20; Fri, 06 Nov 2020 13:39:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=fQkMLtI3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728685AbgKFVhh (ORCPT + 99 others); Fri, 6 Nov 2020 16:37:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54936 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728612AbgKFVh1 (ORCPT ); Fri, 6 Nov 2020 16:37:27 -0500 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8B4BDC0613D2 for ; Fri, 6 Nov 2020 13:37:25 -0800 (PST) Received: by mail-wm1-x343.google.com with SMTP id h2so2825143wmm.0 for ; Fri, 06 Nov 2020 13:37:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=L9e594iGsPQazHtR8mr0tF4GNyBoavTbOlvYUU648dY=; b=fQkMLtI3jRMu0qJTAzLmT9sPs3g2kSFvpEfcUm48VsT9veBNfwxyjelqHMe5RGhlJl yAdcpBeo6Viv+XbU7khoYaO2OCICXxNtrjXAWn9GmjWK6wON3wcQnp30LoNA46vsnaTf PT/DIyVKteZ69p56UD52b8pS6Rfmws+Ofjhv2UTmpVqUP+afGGgpudPY1aJ1CKhxSZA3 Jd7s6g2FSXBobiP6aWe/HsuPwzQklf4lNRrZDxfI8IGsmErymbBTaeH7Z2Udwiw8OBZ4 irGVpOVEJcL3/u4qjf5Pxy4Q5f6x8jPNb7+Uu3MgSQtrgGD8pef6VLhQPkDAUHw59LEK SY1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=L9e594iGsPQazHtR8mr0tF4GNyBoavTbOlvYUU648dY=; b=s/UqM8SR4SSzr0QbAjl/Im15n44OqA8ka5jGx+Oy44Od7XOJs2YUJNIOHDxNuq/xcC 35c+oo/yDzAdP0BoBc8IhPMzFvmtiI6LdeMZVXMGgogXENcUGvnuUjSUrEYoLT1+K8DV 3s9PjxNkVM/9d0iuOmoaKhAAL3SCmsBgwXthxi0ia1C0xCOldw35PA6DEuCwmH4YPCxT 5+b/Nqyz13PSnXAn24X8wfHPpam+eyXW+/faDU1I0olzWjpaGwfmBdjMgebczik8ld1r mNTGaTCyZJLMNG66baMZADrk2rclA9MVQjaiPx6l4/xBKjnWChrP02RD4KuYTyCu/0Fe 36Sg== X-Gm-Message-State: AOAM533SnOOmxOgs91i/IgOeXBgmAH/hD1/kOhynUUYjRfoqB+MBolBR iftHZAe6vBxft/IdSlOabssZvw== X-Received: by 2002:a1c:e286:: with SMTP id z128mr1590177wmg.33.1604698644192; Fri, 06 Nov 2020 13:37:24 -0800 (PST) Received: from dell.default ([91.110.221.236]) by smtp.gmail.com with ESMTPSA id d16sm3984942wrw.17.2020.11.06.13.37.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Nov 2020 13:37:23 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Jian Zhang , linux-mtd@lists.infradead.org Subject: [PATCH v2 19/23] mtd: nand: raw: omap2: Fix a bunch of kernel-doc misdemeanours Date: Fri, 6 Nov 2020 21:36:51 +0000 Message-Id: <20201106213655.1838861-20-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201106213655.1838861-1-lee.jones@linaro.org> References: <20201106213655.1838861-1-lee.jones@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/mtd/nand/raw/omap2.c:191: warning: Function parameter or member 'info' not described in 'omap_prefetch_enable' drivers/mtd/nand/raw/omap2.c:221: warning: Function parameter or member 'cs' not described in 'omap_prefetch_reset' drivers/mtd/nand/raw/omap2.c:221: warning: Function parameter or member 'info' not described in 'omap_prefetch_reset' drivers/mtd/nand/raw/omap2.c:946: warning: Function parameter or member 'chip' not described in 'omap_enable_hwecc' drivers/mtd/nand/raw/omap2.c:946: warning: Excess function parameter 'mtd' description in 'omap_enable_hwecc' drivers/mtd/nand/raw/omap2.c:1017: warning: Function parameter or member 'chip' not described in 'omap_dev_ready' drivers/mtd/nand/raw/omap2.c:1017: warning: Excess function parameter 'mtd' description in 'omap_dev_ready' drivers/mtd/nand/raw/omap2.c:1036: warning: Function parameter or member 'chip' not described in 'omap_enable_hwecc_bch' drivers/mtd/nand/raw/omap2.c:1036: warning: Excess function parameter 'mtd' description in 'omap_enable_hwecc_bch' drivers/mtd/nand/raw/omap2.c:1142: warning: Function parameter or member 'ecc_calc' not described in '_omap_calculate_ecc_bch' drivers/mtd/nand/raw/omap2.c:1142: warning: Excess function parameter 'ecc_code' description in '_omap_calculate_ecc_bch' drivers/mtd/nand/raw/omap2.c:1270: warning: Function parameter or member 'ecc_calc' not described in 'omap_calculate_ecc_bch_sw' drivers/mtd/nand/raw/omap2.c:1270: warning: Excess function parameter 'ecc_code' description in 'omap_calculate_ecc_bch_sw' drivers/mtd/nand/raw/omap2.c:1284: warning: Function parameter or member 'ecc_calc' not described in 'omap_calculate_ecc_bch_multi' drivers/mtd/nand/raw/omap2.c:1284: warning: Excess function parameter 'ecc_code' description in 'omap_calculate_ecc_bch_multi' drivers/mtd/nand/raw/omap2.c:1681: warning: Function parameter or member 'info' not described in 'is_elm_present' drivers/mtd/nand/raw/omap2.c:1681: warning: Function parameter or member 'elm_node' not described in 'is_elm_present' drivers/mtd/nand/raw/omap2.c:1681: warning: Excess function parameter 'omap_nand_info' description in 'is_elm_present' Cc: Miquel Raynal Cc: Richard Weinberger Cc: Vignesh Raghavendra Cc: Jian Zhang Cc: linux-mtd@lists.infradead.org Signed-off-by: Lee Jones --- drivers/mtd/nand/raw/omap2.c | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/mtd/nand/raw/omap2.c b/drivers/mtd/nand/raw/omap2.c index 4cc47ab7f01ad..fbb9955f24671 100644 --- a/drivers/mtd/nand/raw/omap2.c +++ b/drivers/mtd/nand/raw/omap2.c @@ -184,6 +184,7 @@ static inline struct omap_nand_info *mtd_to_omap(struct mtd_info *mtd) * @dma_mode: dma mode enable (1) or disable (0) * @u32_count: number of bytes to be transferred * @is_write: prefetch read(0) or write post(1) mode + * @info: NAND device structure containing platform data */ static int omap_prefetch_enable(int cs, int fifo_th, int dma_mode, unsigned int u32_count, int is_write, struct omap_nand_info *info) @@ -213,7 +214,7 @@ static int omap_prefetch_enable(int cs, int fifo_th, int dma_mode, return 0; } -/** +/* * omap_prefetch_reset - disables and stops the prefetch engine */ static int omap_prefetch_reset(int cs, struct omap_nand_info *info) @@ -938,7 +939,7 @@ static int omap_calculate_ecc(struct nand_chip *chip, const u_char *dat, /** * omap_enable_hwecc - This function enables the hardware ecc functionality - * @mtd: MTD device structure + * @chip: NAND chip object * @mode: Read/Write mode */ static void omap_enable_hwecc(struct nand_chip *chip, int mode) @@ -1008,7 +1009,7 @@ static int omap_wait(struct nand_chip *this) /** * omap_dev_ready - checks the NAND Ready GPIO line - * @mtd: MTD device structure + * @chip: NAND chip object * * Returns true if ready and false if busy. */ @@ -1021,7 +1022,7 @@ static int omap_dev_ready(struct nand_chip *chip) /** * omap_enable_hwecc_bch - Program GPMC to perform BCH ECC calculation - * @mtd: MTD device structure + * @chip: NAND chip object * @mode: Read/Write mode * * When using BCH with SW correction (i.e. no ELM), sector size is set @@ -1130,7 +1131,7 @@ static u8 bch8_polynomial[] = {0xef, 0x51, 0x2e, 0x09, 0xed, 0x93, 0x9a, 0xc2, * _omap_calculate_ecc_bch - Generate ECC bytes for one sector * @mtd: MTD device structure * @dat: The pointer to data on which ecc is computed - * @ecc_code: The ecc_code buffer + * @ecc_calc: The ecc_code buffer * @i: The sector number (for a multi sector page) * * Support calculating of BCH4/8/16 ECC vectors for one sector @@ -1258,7 +1259,7 @@ static int _omap_calculate_ecc_bch(struct mtd_info *mtd, * omap_calculate_ecc_bch_sw - ECC generator for sector for SW based correction * @chip: NAND chip object * @dat: The pointer to data on which ecc is computed - * @ecc_code: The ecc_code buffer + * @ecc_calc: Buffer storing the calculated ECC bytes * * Support calculating of BCH4/8/16 ECC vectors for one sector. This is used * when SW based correction is required as ECC is required for one sector @@ -1274,7 +1275,7 @@ static int omap_calculate_ecc_bch_sw(struct nand_chip *chip, * omap_calculate_ecc_bch_multi - Generate ECC for multiple sectors * @mtd: MTD device structure * @dat: The pointer to data on which ecc is computed - * @ecc_code: The ecc_code buffer + * @ecc_calc: Buffer storing the calculated ECC bytes * * Support calculating of BCH4/8/16 ecc vectors for the entire page in one go. */ @@ -1673,7 +1674,8 @@ static int omap_read_page_bch(struct nand_chip *chip, uint8_t *buf, /** * is_elm_present - checks for presence of ELM module by scanning DT nodes - * @omap_nand_info: NAND device structure containing platform data + * @info: NAND device structure containing platform data + * @elm_node: ELM's DT node */ static bool is_elm_present(struct omap_nand_info *info, struct device_node *elm_node) -- 2.25.1