Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp1591021pxb; Fri, 6 Nov 2020 13:52:50 -0800 (PST) X-Google-Smtp-Source: ABdhPJze6b9V2vd29I6rYWEFPklIL5JWP+OnT4Ru7zNmQoaPR3woN3HGCwmhcHxVmDvCoLlytYjC X-Received: by 2002:aa7:d3c3:: with SMTP id o3mr4392300edr.319.1604699570074; Fri, 06 Nov 2020 13:52:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604699570; cv=none; d=google.com; s=arc-20160816; b=d+c49fBgcb0l/ZU/XmFV3etPeq6A7X6KoUUWyKI9J4WNGjLgY8e835pfeG7DGsJK+U b1vp+Ci/VLuRFCkrJgIIedSXU5OPVEJRNEEUzBHeYo4vPXreV6VKKNBwJYeRyLsnlb0y /T9VKx5Y7Lj/CbSK4lr1E3WYazH4JcRcLVEXXmmmPFaYb2nuW1YoPv/foNCjLU+gKV2Q LIIe4c/4CbR3ZuVYcaBuOKSz26dc6w0bzXlk63/QbLvf8s2oTZSQtMePxxAXI9G9+AuH 08miGxJpHEBxRqlABlIlkOvq1o6fLN0oCfc/wljncIluVa/qUvL1Fa7tJVJgbeIM0qtP fxTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=/vzXOfe3LQJ1tPjw4mGTlBd2Hha/B9WB2NE4h+LPHsM=; b=KygREelYFv8+79YpvVhbK9vtkmeYJUyDATF/SOFf8S3T2Dappy5WfGstZ1/G+XCc7/ HYcIfo8ikkp4Rwy/1epjtP+rrCT4dQhqb/aI7gCTiwi/cIwszNe9Lc+NbAVgWi0GevvY zjx6Aqk5QwX3akVHf/BSSvbmgbtNOwKuDh3EuRk0uV1SVk/upUlVtPkUUK9xlmVISUHB uvHrl3fQqrKBEK8ixf/9CHIDJCih6IrUd9L19EiBc/d1/RTGB3TFtkmG25ojUn452zyQ Bm4if5ENTRl//Ilgxc3JnxwgTCd3OaD2yA2xFKtSRdH/VaAXuif/HV5GPMl8PIEAEUCS t4sg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=CTrg6Tx6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 20si1869188ejw.320.2020.11.06.13.52.27; Fri, 06 Nov 2020 13:52:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=CTrg6Tx6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728846AbgKFVug (ORCPT + 99 others); Fri, 6 Nov 2020 16:50:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56962 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728783AbgKFVuN (ORCPT ); Fri, 6 Nov 2020 16:50:13 -0500 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4BC14C0613D2 for ; Fri, 6 Nov 2020 13:50:12 -0800 (PST) Received: by mail-wr1-x441.google.com with SMTP id b8so2801670wrn.0 for ; Fri, 06 Nov 2020 13:50:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/vzXOfe3LQJ1tPjw4mGTlBd2Hha/B9WB2NE4h+LPHsM=; b=CTrg6Tx6WbaAEcip1oP69BTNYGApk3DcwyCdUIuDQ2NDdnRBvWJ1vAX/ZU360Uj2H3 z2RJwZ1+S16zy979ZmaON1OE5ShHP9tn4UZpPgSmyA/uBIfj1vjmH+jWAjbfh3kcAI+N vT9asDh4Mu/wxBCF1XvL2esu1JYbTTLz+JNFFGMzs0UJu4zl3JLxby5TvA9gZghh1n8E xgYZIZKANmxc4y1D04xef/nQe3Mc/WsFTjsItHINOS2+gcjAGg4rCIRkTLtMqCjztxQv AImujyKOROsE+WUyTvErplm6dKHsfOgyEv5JJ1hSVPExxmbbHfSR6B+4fSicdViUancm iJig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/vzXOfe3LQJ1tPjw4mGTlBd2Hha/B9WB2NE4h+LPHsM=; b=TNHR8pufsym/Bs1ySntmPl+UJ/pZlNYiPtNhVLxkJFA87O+bgjPMiw/INhGcG871OO xvE60Xzz7PGrLQTIqHheXsi3BIz0AzeIu92z2+H/XhI4zi3VIIbyqAqfhwwtOktvj2H1 o9aerAm/78GI/HzmTamUV5UkrH65UV9UjBVBCMAZgN8KqGKwsGTj6J/2Uh0kOyIHmfS0 ct7hSqmrMNdV9eviLuRSqLs+uukjYRTFQ2Qm+9kiMaI7mocbtpRA8caNSXyVwzgij8jn depcTQI4UuHX1nkNYDVHYF06ubWsxiUrw7rpTmQNR0VRfKxHZKx9MSVHQ1bOvyX/A8qT RDwQ== X-Gm-Message-State: AOAM533HXxxulxqDNnMhRlVVEPpQX0VX5XMIEtshbHh060l8CE1QK4Pg DH/t9o2beZ/ShH8zdZyIjXloMg== X-Received: by 2002:adf:e551:: with SMTP id z17mr4904423wrm.374.1604699411021; Fri, 06 Nov 2020 13:50:11 -0800 (PST) Received: from dell.default ([91.110.221.236]) by smtp.gmail.com with ESMTPSA id t199sm3981084wmt.46.2020.11.06.13.50.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Nov 2020 13:50:10 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , David Airlie , Daniel Vetter , Sumit Semwal , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org Subject: [PATCH 14/19] drm/amd/amdgpu/amdgpu_device: Provide documentation for 'reg_addr' params Date: Fri, 6 Nov 2020 21:49:44 +0000 Message-Id: <20201106214949.2042120-15-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201106214949.2042120-1-lee.jones@linaro.org> References: <20201106214949.2042120-1-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:594: warning: Function parameter or member 'reg_addr' not described in 'amdgpu_device_indirect_rreg' drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:624: warning: Function parameter or member 'reg_addr' not described in 'amdgpu_device_indirect_rreg64' Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Sumit Semwal Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Cc: linux-media@vger.kernel.org Cc: linaro-mm-sig@lists.linaro.org Signed-off-by: Lee Jones --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c index 300fcade4a2b1..63374d12e00fe 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c @@ -585,6 +585,7 @@ void amdgpu_mm_wdoorbell64(struct amdgpu_device *adev, u32 index, u64 v) * @adev: amdgpu_device pointer * @pcie_index: mmio register offset * @pcie_data: mmio register offset + * @reg_addr: indirect register address to read from * * Returns the value of indirect register @reg_addr */ @@ -615,6 +616,7 @@ u32 amdgpu_device_indirect_rreg(struct amdgpu_device *adev, * @adev: amdgpu_device pointer * @pcie_index: mmio register offset * @pcie_data: mmio register offset + * @reg_addr: indirect register address to read from * * Returns the value of indirect register @reg_addr */ -- 2.25.1