Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <df7273e41c72d0b9ac3e7df2773417069169a29f.camel@kernel.org>
Subject: Re: [PATCH v2 net-next 06/13] octeontx2-pf: Add support for unicast
 MAC address filtering
From:   Saeed Mahameed <saeed@kernel.org>
To:     Naveen Mamindlapalli <naveenm@marvell.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     kuba@kernel.org, davem@davemloft.net, sgoutham@marvell.com,
        lcherian@marvell.com, gakula@marvell.com, jerinj@marvell.com,
        sbhatta@marvell.com, hkelam@marvell.com
Date:   Fri, 06 Nov 2020 14:15:33 -0800
In-Reply-To: <20201105092816.819-7-naveenm@marvell.com>
References: <20201105092816.819-1-naveenm@marvell.com>
         <20201105092816.819-7-naveenm@marvell.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.36.5 (3.36.5-1.fc32) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 2020-11-05 at 14:58 +0530, Naveen Mamindlapalli wrote:
> From: Hariprasad Kelam <hkelam@marvell.com>
> 
> Add unicast MAC address filtering support using install flow
> message. Total of 8 MCAM entries are allocated for adding
> unicast mac filtering rules. If the MCAM allocation fails,
> the unicast filtering support will not be advertised.
> 
> Signed-off-by: Hariprasad Kelam <hkelam@marvell.com>
> Signed-off-by: Sunil Goutham <sgoutham@marvell.com>
> Signed-off-by: Naveen Mamindlapalli <naveenm@marvell.com>
> ---
>  .../ethernet/marvell/octeontx2/nic/otx2_common.h   |  10 ++
>  .../ethernet/marvell/octeontx2/nic/otx2_flows.c    | 138
> +++++++++++++++++++--
>  .../net/ethernet/marvell/octeontx2/nic/otx2_pf.c   |   5 +
>  3 files changed, 146 insertions(+), 7 deletions(-)
> 

> +int otx2_add_macfilter(struct net_device *netdev, const u8 *mac)
> +{
> +	struct otx2_nic *pf = netdev_priv(netdev);
> +	int err;
> +
> +	err = otx2_do_add_macfilter(pf, mac);
> +	if (err) {
> +		netdev->flags |= IFF_PROMISC;

I don't think you are allowed to change netdev->flags inside the driver
like this, this can easily conflict with other users of this netdev;
netdev promiscuity is managed by the stack via refcount Please see:
__dev_set_promiscuity() and dev_set_promiscuity()

And you will need to notify stack and userspace of flags changes.