Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201105232440.1049635-1-brendanhiggins@google.com>
In-Reply-To: <20201105232440.1049635-1-brendanhiggins@google.com>
From:   David Gow <davidgow@google.com>
Date:   Sat, 7 Nov 2020 12:09:16 +0800
Message-ID: <CABVgOSnVj+EXZ13vgx7pj3fFJ7yx9xPYU39nuCP_v_fNYpN12w@mail.gmail.com>
Subject: Re: [PATCH v1] kunit: tool: unmark test_data as binary blobs
To:     Brendan Higgins <brendanhiggins@google.com>
Cc:     Shuah Khan <shuah@kernel.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@vger.kernel.org>,
        KUnit Development <kunit-dev@googlegroups.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Nov 6, 2020 at 7:24 AM Brendan Higgins
<brendanhiggins@google.com> wrote:
>
> The tools/testing/kunit/test_data/ directory was marked as binary
> because some of the test_data files cause checkpatch warnings. Fix this
> by dropping the .gitattributes file.
>
> Fixes: afc63da64f1e ("kunit: kunit_parser: make parser more robust")
> Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
> ---
Reviewed-by: David Gow <davidgow@google.com>

Thanks. I wasn't able to find any issues which required those files to
be binary.

For the record, a link to the original issue, which appeared to be
with whitespace (spaces before tabs) in git apply:
https://lkml.org/lkml/2020/3/13/920

Cheers,
-- David