Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp1779641pxb; Fri, 6 Nov 2020 21:10:38 -0800 (PST) X-Google-Smtp-Source: ABdhPJyzeOejHoTeWfUrCasNuhnMMs4zHgQNDCVDa7lC7tZxhYRXHQkc4D7grc21XuM5raLg1xp0 X-Received: by 2002:a05:6402:150:: with SMTP id s16mr5311097edu.304.1604725837832; Fri, 06 Nov 2020 21:10:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604725837; cv=none; d=google.com; s=arc-20160816; b=i8IeQx37EWJtw6eFZPstTJj54D/WhdCmXtO5SkWLy/2SNnF2bqim4BDz+/cnOb3Ik3 sgHMemzDXnoHQhD04T1ctCcEfruRu4xcuepeekRQZmwY5BDWRXAZhsA8UoCgQG4KNzJv tcOYrWYysBDKnQlNf99ia3LdiqzEBcVo5b7JiJQO6KxitaFiZjVJ8Q+Q40YYG44Iz6Bo ZvvcBaEMIfBMBXErWkioe0oHG+Jbz66gdt45tRWnOat8pXhXGNo7cuCg5rDhCR0jxHzE O8B0LauYQh4GPDUyWqbv2kRAL3UlNnVEOx/wvOOVF5x12V4CMi8WXzswdCfw+MbDxIlH PIFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=nk+z5R5zFdPeWzYH+hbsNRa55uO51J3c/bqhW9RtJX4=; b=m/oH6zGeJrTdTVmEMhWUExmCxCVFPCS2W1L9O9dN7yQOqPPPAbgfIZsuPXLBjI4gdd ywIYqRQUwfOhrtATJ3B25o8ZJB4hk34b5Cne9Pa+N0oxDxIeGHK3MoA9lnIwZ9f/aNQ5 fqoHeI1bGsz5LNnKe9otiuWfEDNTVa7LWSqHOBayXmzqB3ExMjxBDjIrgjcsjz0/Q6pW hXabWndQus3FVeGed/X5xidyscTCdO0dw8Jm49LyUYJx/7B6+OXByICP6qeTji5eDzq9 ZBrz2/N974YUpnsZIUr1Jiqvwubil2FbhksZSYquOYGo+mZPoMwb9VhN5q2c9bzwPNGC WIHg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=clH9jKll; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id jr7si2520467ejb.592.2020.11.06.21.10.14; Fri, 06 Nov 2020 21:10:37 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=clH9jKll; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727380AbgKGFIu (ORCPT + 99 others); Sat, 7 Nov 2020 00:08:50 -0500 Received: from mail.kernel.org ([198.145.29.99]:59010 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726880AbgKGFIt (ORCPT ); Sat, 7 Nov 2020 00:08:49 -0500 Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6BF4C20872; Sat, 7 Nov 2020 05:08:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604725727; bh=55KoHb8qRGofoRpTcqTP6+Sj4wA/iZddMk3945/FVcc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=clH9jKll51JXfmaZOHedvXOzyp7t2WgbUCWUJcFUbBilgShWQhDpvNoMEYLV6qd43 +Fl/JEjNDA8ao703NxINPTq7DhZShDMQQ3SqcctGfKdjL2V0jw0fCkDbxitCqY1TJo ueNrSwM6MnUGAptjcct12z9Zzj6EsXyQ2pksLgGM= Date: Fri, 6 Nov 2020 21:08:45 -0800 From: Andrew Morton To: Vineet Gupta Cc: Alexey Dobriyan , Ingo Molnar , Alexey Gladkov , Peter Zijlstra , Kees Cook , "Eric W . Biederman" , Vlastimil Babka , Michel Lespinasse , Andrei Vagin , Bernd Edlinger , John Johansen , Oleg Nesterov , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-snps-arc@lists.infradead.org Subject: Re: [RFC] proc: get_wchan() stack unwind only makes sense for sleeping/non-self tasks Message-Id: <20201106210845.e9e95e91b779a01b6751e240@linux-foundation.org> In-Reply-To: <20201105231132.2130132-1-vgupta@synopsys.com> References: <20201105231132.2130132-1-vgupta@synopsys.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 5 Nov 2020 15:11:32 -0800 Vineet Gupta wrote: > Most architectures currently check this in their get_wchan() implementation > (ARC doesn't hence this patch). However doing this in core code shows > the semantics better so move the check one level up (eventually remove > the boiler-plate code from arches) It would be nice to clean up the arch callees in the same patch, at least so it doesn't get forgotten about. Are you prepared to propose such a change?