Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201031181043.805329-1-xie.he.0141@gmail.com>
 <20201103152216.36ed8495@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <CAJht_EMOtSVSeqy93ZsDKZRi+-A7=6Fjqu1nPRVi3O4SZV8Zrw@mail.gmail.com>
In-Reply-To: <CAJht_EMOtSVSeqy93ZsDKZRi+-A7=6Fjqu1nPRVi3O4SZV8Zrw@mail.gmail.com>
From:   Xie He <xie.he.0141@gmail.com>
Date:   Sat, 7 Nov 2020 06:34:05 -0800
Message-ID: <CAJht_EPvPW8tSGbhB99c_SpZ7c30yP23Z-tW-6+YjBP8aacr0w@mail.gmail.com>
Subject: Re: [PATCH net-next v7 0/5] net: hdlc_fr: Improve fr_rx and add
 support for any Ethertype
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     "David S. Miller" <davem@davemloft.net>,
        Linux Kernel Network Developers <netdev@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Krzysztof Halasa <khc@pm.waw.pl>,
        Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Nov 3, 2020 at 6:03 PM Xie He <xie.he.0141@gmail.com> wrote:
>
> On Tue, Nov 3, 2020 at 3:22 PM Jakub Kicinski <kuba@kernel.org> wrote:
> >
> > Applied, but going forward please limit any refactoring and extensions
> > to the HDLC code. I thought you are actually using it. If that's not
> > the case let's leave the code be, it's likely going to be removed in
> > a few years time.
>
> OK. I understand.
>
> Thanks!

The HDLC layer is still used by X.25 people (to be precise, Martin
Schiller <ms@dev.tdt.de>). Although we currently have three X.25
drivers in the kernel (lapbether, x25_asy, hdlc_x25), it seems to me
that only hdlc_x25 is used in the real world. So I guess the HDLC
layer will be there as long as the X.25 stack is still there.