Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp2118315pxb; Sat, 7 Nov 2020 09:48:03 -0800 (PST) X-Google-Smtp-Source: ABdhPJyhyC80uWwvJ2lh9r6jkwLVgVnzCMBDZIS/mvFZ7+VmnjMzf5PlzA9ve83rHAeyAaiZKIao X-Received: by 2002:a17:906:604e:: with SMTP id p14mr8015926ejj.515.1604771283791; Sat, 07 Nov 2020 09:48:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604771283; cv=none; d=google.com; s=arc-20160816; b=OV5ISj4ARlerso4BwLOzaZr6BAuZMOI0xsXe/IHTiocAD1efYqTVzTqMpPzb7YorK0 T6znNiyo9tBv6BKr2PtgVJCc6nWCJo6N7fnvvp8+TnR/wv8PDQnEA6qsvC6nRN8Hgd94 /YUqvkeTnjJjLr2CN5MUjolVhYaJW+nOA034akNlrwe1O7r1pZERvNSAfewWl4U/E/jV yHg0CyaEp1+piIJG8Uigwr/tGZYIFsHXhbkrgUIfMsPPziz8FBxxrPHRIB6DyQSx3B14 mgsG8r8KT2eznvEjiqTRygV2ZuvjxIkYh2T0BbW82Oi3UI+lW32mBJmnEySvY2hoMR3I JDrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=HzO5wSzTkfmeFYKB7AfLplL6DNZtD5Hccv3T0sbcxyw=; b=tEVbH9anItyZMTNC+5pMMPEyptflDWdaVgt0NWVLx22BT9Jpc9W//Gc2bsLMILl04s yU6Hg3uejBlTqqfZnXCn0klQe2HpEf6RyiRDjOOe1I4FcmTE1WfpfE4nyvZQpI/04Xxy feLccx+ajEx8aRE6piNoLdLHURklreIm6zD84j8m9DiF8vlhuwpCvM8cJjwhV0z+ZZO1 LRIS6WfTM3tErGIM5s3BoI7llLbOFbx0sx4ugX2U3TDdLMzSSaVHJ537LyBaEN+ic4kg 2LhecVP+BLTh5R09hAk7I2pi8Vzh/xlNyT4KBBpmR02EkHNXpW9JOFFxxLfWp++abC0B oZRg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=q88sDzz6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y19si3602114edu.280.2020.11.07.09.47.37; Sat, 07 Nov 2020 09:48:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=q88sDzz6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728388AbgKGRqO (ORCPT + 99 others); Sat, 7 Nov 2020 12:46:14 -0500 Received: from mail.kernel.org ([198.145.29.99]:34604 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727305AbgKGRqO (ORCPT ); Sat, 7 Nov 2020 12:46:14 -0500 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D29B220878; Sat, 7 Nov 2020 17:46:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604771174; bh=qfZ3VmMYwVntgdcYb/LX3LnhnzFyi7oFus8Cl8eq+yI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=q88sDzz6oM+Ef5DcBkyrpWq0FxdRHAMj7skajZDkCDsr/ub+5g7fCnlZWnOkTwtDl b1dqpnSq5vBcsDF6WsQVe/rXMU619oav/BghRvfZ+4RKiBz4N4TZjLQUAO7Z9Wxmh9 Y19l9IX8B137vdXYK3szji8BLINXxGgQKjSzYEyY= Date: Sat, 7 Nov 2020 09:46:13 -0800 From: Jakub Kicinski To: Huazhong Tan Cc: , , , , , Subject: Re: [PATCH net-next 02/11] net: hns3: add support for 1us unit GL configuration Message-ID: <20201107094613.261fe05b@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <1604730681-32559-3-git-send-email-tanhuazhong@huawei.com> References: <1604730681-32559-1-git-send-email-tanhuazhong@huawei.com> <1604730681-32559-3-git-send-email-tanhuazhong@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 7 Nov 2020 14:31:12 +0800 Huazhong Tan wrote: > For device whose version is above V3(include V3), the GL > configuration can set as 1us unit, so adds support for > configuring this field. >=20 > Signed-off-by: Huazhong Tan Doesn't build. drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c: In function =E2=80=98hn= s3_check_gl_coalesce_para=E2=80=99: drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c:1152:6: error: =E2=80=98= ae_dev=E2=80=99 undeclared (first use in this function); did you mean =E2= =80=98netdev=E2=80=99? 1152 | if (ae_dev->dev_version >=3D HNAE3_DEVICE_VERSION_V3) | ^~~~~~ | netdev drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c:1152:6: note: each undec= lared identifier is reported only once for each function it appears in make[6]: *** [drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.o] Error 1 make[5]: *** [drivers/net/ethernet/hisilicon/hns3] Error 2 make[4]: *** [drivers/net/ethernet/hisilicon] Error 2 make[4]: *** Waiting for unfinished jobs.... make[3]: *** [drivers/net/ethernet] Error 2 make[2]: *** [drivers/net] Error 2 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [drivers] Error 2 make: *** [__sub-make] Error 2