Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp2130695pxb; Sat, 7 Nov 2020 10:13:12 -0800 (PST) X-Google-Smtp-Source: ABdhPJwxmQvUWDMINPjglagFtVRhJvLxlGtlhJvLATBf6jd2FFZjOe+sJuZHfW10YMAXMzjCpyBO X-Received: by 2002:aa7:db82:: with SMTP id u2mr7880640edt.262.1604772792210; Sat, 07 Nov 2020 10:13:12 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1604772792; cv=pass; d=google.com; s=arc-20160816; b=H7T8+0MlBFizAR/ZcFcEatkHS20EnXdniKqyzHt+664j12pa79O5JwiwQCzdSMhWIw WuvNT+swns1fdCmUZeT8hW8ysnyEBvZy6HcdpY3lYfeulIyEmTOaWNsYKquJlTrBKn44 sK23ZODXRm76rDS1wHTd9Fti3FP+8BQRRrtP1XnsV7blLQzwmWyneMA60RwAvd2upIrc zl4nwXFWvApXeSnp/hdLi0LD/6fbZtvKarffwspCTL1+/ER69iHP9eOxez+pg99KELEl OgbuAZb3lKm0/Pwem7RBB7xjFFZjBVA4L7yhga9JY89PVXAQsvjw3msVROisp/oemks+ 2i3Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :content-language:in-reply-to:user-agent:date:message-id:from :references:to:subject:dkim-signature:dkim-signature; bh=TwqZxM++hfBd73X1KRRlxvntiJFNd3xpmL+Pi1QahRk=; b=Q4vy7JaLmcLYKR6Oe+zvOH71Js9DcZz5inz+pu5qYLV0R/fdGWIvEeCv7u+sjD83CB INRv/zw5ETXXCxYrSUfWIFLHjHzUuX9g5t0N/OgBFSqr+pGl4sUghxht82wStS+xgWOm AyI6fHRchlrrHLgb/oF8zyZtossKG7WuivWWnmmHC2oD6y42eHHOOLi/8gSUe8rouU84 Se/RURS/TLNWgwY0/BIWsqy4/R1Ln78CnLA4wbMzrDeVlvjAX1g0m7JsNWqrG1OzAVx0 oR5wPLpRinHm6zQfL9BwLjwyZtRR56UwkJPX033GZS4JG2WKh/HAtFoyAr57NEbg3Quk N++A== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@fb.com header.s=facebook header.b=V4eBkDLv; dkim=pass header.i=@fb.onmicrosoft.com header.s=selector2-fb-onmicrosoft-com header.b=Cdsh4AnH; arc=pass (i=1 spf=pass spfdomain=fb.com dkim=pass dkdomain=fb.com dmarc=pass fromdomain=fb.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=fb.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u1si3692413edp.86.2020.11.07.10.12.28; Sat, 07 Nov 2020 10:13:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@fb.com header.s=facebook header.b=V4eBkDLv; dkim=pass header.i=@fb.onmicrosoft.com header.s=selector2-fb-onmicrosoft-com header.b=Cdsh4AnH; arc=pass (i=1 spf=pass spfdomain=fb.com dkim=pass dkdomain=fb.com dmarc=pass fromdomain=fb.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=fb.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728546AbgKGSJg (ORCPT + 99 others); Sat, 7 Nov 2020 13:09:36 -0500 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:2626 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726333AbgKGSJg (ORCPT ); Sat, 7 Nov 2020 13:09:36 -0500 Received: from pps.filterd (m0001303.ppops.net [127.0.0.1]) by m0001303.ppops.net (8.16.0.42/8.16.0.42) with SMTP id 0A7I8rif008493; Sat, 7 Nov 2020 10:08:53 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com; h=subject : to : references : from : message-id : date : in-reply-to : content-type : content-transfer-encoding : mime-version; s=facebook; bh=TwqZxM++hfBd73X1KRRlxvntiJFNd3xpmL+Pi1QahRk=; b=V4eBkDLveg2EcTOb+S6i12LakWRt1CayP/HQzyl3NanGZALChmMU1d2XDlegAtQ/oTTd l7rM7V0gQUx3BKFnTEQc1vM6XiYNNaBCigqCjqlz1VbUT8c9mgn3gVwW0ELMSQ58D2fA +c6BmdgD/JiHxYz+U/l3hWMMRDmNnBzpWmM= Received: from maileast.thefacebook.com ([163.114.130.16]) by m0001303.ppops.net with ESMTP id 34nr4phcj3-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Sat, 07 Nov 2020 10:08:53 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (100.104.31.183) by o365-in.thefacebook.com (100.104.36.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3; Sat, 7 Nov 2020 10:08:48 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H7PM8jk/oaVdAVZg7zdeRiCcCoX0oourRaITPZV//05IIlHr0bz9Ft+Q1JLh20aZEBeAyhDZ+AUVingSdR4Vls+lkaO+CzIN+sb7rOB83xmTT2ahVAnHJbYSDgqZeY0k6CgWDwrqa/41JFXUizEY+/RlpXYrhVPOegkW8EXViT8EGeGqTTqp0kCZRuQ2l3gfpeU7LhJQIkzHqOlmbkhHgubDDG9N0Nk6gSPt3lxCSOmFaKW9u4dyStBSlJz87jKdVj1L3kgow+2cOP2ZvNdax40hTFeq7T7tiHJ1MLOmMntWy86GCN6apuaNOEj0nkFMKCMGyraDyb4fVseNOyMAjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TwqZxM++hfBd73X1KRRlxvntiJFNd3xpmL+Pi1QahRk=; b=iWdMqjBXlLsp4tMcvrEjynW/TWcz7tcoS1sgSrxi0cWQzWnD4kuMjJWk08Yqea32e3vR33yVsqevz+HivxYd6acpGObhRFcCz1TP5jvVftI3kDM8pwowBPtcyFQP2c6NxJ/AxsHjbWfhP/EryKkk+qzQpZhGMmeCb0GT4fbUM2vzXCC4FOd3uyBkrDUOE//aLM3BpfhgpUzKBJXcFO4QfvdaMjo4CZs4gkyYu8ADMI98uAyrg2EPPnHf1vZTMfI6nQgcuzlTIlzHl7/qfONe8T5/fCOqUY++HAWOKT5FiyYFhmpgpC238SDKO1XIaEFlrsT4ijdXVN44YwA3bMkxBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=fb.com; dmarc=pass action=none header.from=fb.com; dkim=pass header.d=fb.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.onmicrosoft.com; s=selector2-fb-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TwqZxM++hfBd73X1KRRlxvntiJFNd3xpmL+Pi1QahRk=; b=Cdsh4AnHNwTRFK6OdqrqVRO2SkwcXGOUhcwCSI85MlQV8syu3UPObYnwZ2bV1ZOtXXSgM+cWE4LbUw8txMLM2T2+kcW1tsGqsArjEAGJ7SYSaEtqwF7loYflm/dlYbxYf1EM9B7jylP+pQ0wC/JTedow94EBawqbDSWi9t//8As= Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=fb.com; Received: from BYAPR15MB4088.namprd15.prod.outlook.com (2603:10b6:a02:c3::18) by SJ0PR15MB4204.namprd15.prod.outlook.com (2603:10b6:a03:2c8::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.29; Sat, 7 Nov 2020 18:08:47 +0000 Received: from BYAPR15MB4088.namprd15.prod.outlook.com ([fe80::8887:dd68:f497:ea42]) by BYAPR15MB4088.namprd15.prod.outlook.com ([fe80::8887:dd68:f497:ea42%3]) with mapi id 15.20.3541.021; Sat, 7 Nov 2020 18:08:47 +0000 Subject: Re: [PATCH v3 bpf] trace: bpf: Fix passing zero to PTR_ERR() To: Wang Qing , Steven Rostedt , Ingo Molnar , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Andrii Nakryiko , John Fastabend , KP Singh , , , References: <1604735144-686-1-git-send-email-wangqing@vivo.com> From: Yonghong Song Message-ID: <60774a8b-32a5-354d-88d5-cf86be19d51c@fb.com> Date: Sat, 7 Nov 2020 10:08:43 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 In-Reply-To: <1604735144-686-1-git-send-email-wangqing@vivo.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [2620:10d:c090:400::5:4dfc] X-ClientProxiedBy: MWHPR1201CA0006.namprd12.prod.outlook.com (2603:10b6:301:4a::16) To BYAPR15MB4088.namprd15.prod.outlook.com (2603:10b6:a02:c3::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [IPv6:2620:10d:c085:21e1::10a6] (2620:10d:c090:400::5:4dfc) by MWHPR1201CA0006.namprd12.prod.outlook.com (2603:10b6:301:4a::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.19 via Frontend Transport; Sat, 7 Nov 2020 18:08:45 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b15d04e4-f661-4b43-bcfa-08d883482bbc X-MS-TrafficTypeDiagnostic: SJ0PR15MB4204: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-FB-Source: Internal X-MS-Oob-TLC-OOBClassifiers: OLM:361; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pst24rQbt6gwKx0CIg4r0hyl8T5RhPvZQX0oDmRcWHGa3YKbcr3EYRKqJxRQELRSbiUVFMluTJhdLdGMBGdMBsUH+FezAT4ou3n6OVIy3lecaocqYZ4BoQizRJHlNJUMXsBp3WwIYLGO5D7qXho0iVuUvqzihRE+IaHm2z85Yp0xWtHyN5U1HqviZUTNq3AsXyxhbivsuQmeQ3HcUhtKezVtIqItfkR2vCMHr6Er4ZWgjf2zzt3EHCS0H/D80wQdrz/FXzdBUeT2tV/WQGd805jSJ4zvK7qT2ShRbdVxIGNPXE0WfBCM/nnD3oi+wSLkPooHE4m1T1WTyNh9MP4B8xkNk3AAOg7moYKbmDk7wRKhehnucj4SCGp/PPcN7fYgdSDteTHvazw96oihejPpsg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR15MB4088.namprd15.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(346002)(376002)(136003)(396003)(39860400002)(6486002)(2616005)(478600001)(53546011)(16526019)(66556008)(66476007)(66946007)(36756003)(5660300002)(86362001)(8676002)(110136005)(186003)(7416002)(8936002)(2906002)(52116002)(31696002)(316002)(558084003)(31686004)(921003)(43740500002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData: X4ZIKEZtNGZxJbbIugG/joPhEo0h8xbNzJ8emWVxOdDw3j9Y5vVk9eCWT/Fw150q0xPmia0Uyx7CqiatK2FE9N+rUkRkRWbJpXw9xsdLCk/AXVUnFZGKtDhBDC2+KRiYaDN24xS/BgqR2Cln5g2NIwK7NoyLLGBFh8lYmYodCqXs7anPkDspUogsf0nIovLriwxtUqttl5DTgFjkMI+hAhK+1idGjpZUTOGJrTSeWkItjetlAs80wGWJFX61EYSvboMjYNKiLR8OGwJ/5JqzI6KAG5W57lMCEZIihAJSOYepUjNAeTEmxhr+rJbQbOE0k9F+fdPsNsmtqx89OLo4TUqc9vCR6j1gezUXxFriPGVORG7bQrTrNGpWranr/Pby8e5nm9huhiTaRXRz/hm9jQs7f6Id3BF1V04TPUCiruOgIzMrJSXtAI8mt1pyqspLnoGUWr/XcXxR8ZB2pe8DcTpCDAlzFUdirhJYHxNOsUG/ZjEJiTQveY+J6L3ycUwWrZHl5OixTQPfhAN2wyK/KqGxNZpx1scQZkMLqufYY7q9BCiA0pdTGuEQwu92XeJ1yP2SOC5/Pgl6CLqUM3m76jXYBDJqxFVmh/yJ6zNhLEH2sw4YDHkPry2THF/V6rvmVv18AUvF/sUuI9GbtqUgRbaEvladiXkMXkNREgEGqE+e540wpibqx0PFG9bPStzu X-MS-Exchange-CrossTenant-Network-Message-Id: b15d04e4-f661-4b43-bcfa-08d883482bbc X-MS-Exchange-CrossTenant-AuthSource: BYAPR15MB4088.namprd15.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2020 18:08:47.3125 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nPEGkhQkZA2XBzXjZXujws8KzFeLjTcrX/ZuNXz+FLH8CheTDrbfBlbhAEj+87bF X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR15MB4204 X-OriginatorOrg: fb.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.312,18.0.737 definitions=2020-11-07_09:2020-11-05,2020-11-07 signatures=0 X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 lowpriorityscore=0 malwarescore=0 mlxlogscore=889 spamscore=0 suspectscore=0 mlxscore=0 bulkscore=0 phishscore=0 clxscore=1015 impostorscore=0 adultscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2011070132 X-FB-Internal: deliver Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/6/20 11:45 PM, Wang Qing wrote: > There is a bug when passing zero to PTR_ERR() and return. > Fix smatch err. > > Signed-off-by: Wang Qing Acked-by: Yonghong Song