Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 7 Nov 2020 12:45:47 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     Randy Dunlap <rdunlap@infradead.org>
Cc:     Vadym Kochan <vadym.kochan@plvision.eu>,
        Volodymyr Mytnyk <volodymyr.mytnyk@plvision.eu>,
        Andrii Savka <andrii.savka@plvision.eu>,
        "David S. Miller" <davem@davemloft.net>,
        Oleksandr Mazur <oleksandr.mazur@plvision.eu>,
        Serhiy Boiko <serhiy.boiko@plvision.eu>,
        Serhiy Pshyk <serhiy.pshyk@plvision.eu>,
        Taras Chornyi <taras.chornyi@plvision.eu>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        Mickey Rachamim <mickeyr@marvell.com>
Subject: Re: [PATCH net] net: marvell: prestera: fix compilation with
 CONFIG_BRIDGE=m
Message-ID: <20201107124547.0b22d635@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <4d67e1d4-4f5c-a0c1-ce87-42e141215aa1@infradead.org>
References: <20201106161128.24069-1-vadym.kochan@plvision.eu>
        <4d67e1d4-4f5c-a0c1-ce87-42e141215aa1@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Fri, 6 Nov 2020 12:13:12 -0800 Randy Dunlap wrote:
> On 11/6/20 8:11 AM, Vadym Kochan wrote:
> > With CONFIG_BRIDGE=m the compilation fails:
> > 
> >     ld: drivers/net/ethernet/marvell/prestera/prestera_switchdev.o: in function `prestera_bridge_port_event':
> >     prestera_switchdev.c:(.text+0x2ebd): undefined reference to `br_vlan_enabled'
> > 
> > in case the driver is statically enabled.
> > 
> > Fix it by adding 'BRIDGE || BRIDGE=n' dependency.
> > 
> > Fixes: e1189d9a5fbe ("net: marvell: prestera: Add Switchdev driver implementation")
> > Reported-by: Randy Dunlap <rdunlap@infradead.org>
> > Signed-off-by: Vadym Kochan <vadym.kochan@plvision.eu>  
> 
> Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested

Applied, thanks!