Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp2211822pxb; Sat, 7 Nov 2020 13:26:35 -0800 (PST) X-Google-Smtp-Source: ABdhPJzU5Q3HwOhwfcyztsREGoU/p18oF2AO0NVkcl3b2hYgiK/aD74UDHn5wXXzoTl5TGsjYaz6 X-Received: by 2002:a17:906:854b:: with SMTP id h11mr8401656ejy.273.1604784395307; Sat, 07 Nov 2020 13:26:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604784395; cv=none; d=google.com; s=arc-20160816; b=bIm+IQinclx/IBNtlguTeCrRdb3geKdD84/7CZwYSjkmcchks8s0BNBy3ZHXnvxYMD 4bNx+CVNRSUCF5JGp+WBF9q4nmQwZqKzTyuGfadm40oljDTFn00blZ7sTwTJsOA2cP/7 VBMsPnXQPRbsk0E4fCLgYUUzwaqP6IH1KaUDdjU4WSqUbFS8VgyGr72QeGecWpew1rr4 gXzrvrq/BNSnjYLk/sI29CuyRats8Oa6iLAxVvbO4+Tvo9sEdvgBRr+P+bVL7icnEaaM nfIbudKCf2F1a2ht4x36uh9jzWHMnAbnsfNzJcu2SgTK0m4tMx1vEwxSsF//R4a4/EHL CSiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=44tM+Aai8f/cN6dBXY3HLyYig3x3wX7rVn0vWF2io7Y=; b=rD6yzU2x5sEIQVZb49KZifwoDGiX2CtJnA8EuSF37wWejyZDEYJj5yZkBhG/ktJsBP 2vl1ZhXccSSDrMqQy4xie/a822Ok0IQleoUfDpc7gn77SxF8T2XII/6cKlHfWUQYquYb i65nIBy3Lb5v6GFyJ6TSOjt99vJZ/mkhBduGWl/ZjaS9s3md1XrPiwozHpRQ56dmP9kv to66Fd5YeTwVsV6GGPEmBblWD8supGaggchx9OovFUol+1gTvF21LMwASKsZZVZsBjFQ SFp0rLn0rM0Af8jRPhTz3/LL+N/qkCbFtTwqnVOoCIg6Y1i7xhIUJPvfBIEHM5P//O8m F7TA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=BoVgnF4d; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id uz28si3658876ejb.599.2020.11.07.13.26.12; Sat, 07 Nov 2020 13:26:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=BoVgnF4d; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727454AbgKGVYq (ORCPT + 99 others); Sat, 7 Nov 2020 16:24:46 -0500 Received: from mail.kernel.org ([198.145.29.99]:44088 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725836AbgKGVYq (ORCPT ); Sat, 7 Nov 2020 16:24:46 -0500 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4EFFD206DB; Sat, 7 Nov 2020 21:24:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604784285; bh=BFT8AiDGiOnrBrmOkHYjI06IqPwJCXPQDbVnQeOlgNY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=BoVgnF4d72DKMOD5u+iPh1O00tp9JieqvGf7mPhR9R5y5EHBkBr6Z745QSffNLF+7 0XCVsgGRZJlveuGY0cLehzgp6cq+T+4y/OXDe+aR/wZmBoEFokmkJvCVVoaIAOaboe QPWbApSj2o15qv0rNX/P3+o3DHHG6NsDVFuJma3s= Date: Sat, 7 Nov 2020 13:24:44 -0800 From: Jakub Kicinski To: Nicolas Ferre Cc: Parshuram Thombare , , , , , , , , , , Subject: Re: [RESEND PATCH] net: macb: fix NULL dereference due to no pcs_config method Message-ID: <20201107132444.560cc7c2@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <22c6b5ff-d19e-2af8-d601-341a2101d6ef@microchip.com> References: <1604599113-2488-1-git-send-email-pthombar@cadence.com> <22c6b5ff-d19e-2af8-d601-341a2101d6ef@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 6 Nov 2020 10:26:59 +0100 Nicolas Ferre wrote: > On 05/11/2020 at 18:58, Parshuram Thombare wrote: > > This patch fixes NULL pointer dereference due to NULL pcs_config > > in pcs_ops. > > > > Reported-by: Nicolas Ferre > > Link: https://lore.kernel.org/netdev/2db854c7-9ffb-328a-f346-f68982723d29@microchip.com/ > > Signed-off-by: Parshuram Thombare > > Acked-by: Nicolas Ferre Applied. I brought back the fixes tag from the first posting. It's entirely reasonable to add fixes tags from the tree you're targeting as long as that tree guarantees commit hashes are stable and won't change on their way upstream. Which is the case for net and net-next trees. Thanks!