Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201013085512.12857-1-bernard@vivo.com> <CAAOTY__r-2aQLK+oy6uRFnu3xExngBYrSAQ7jCfhWx+Ti0UgFw@mail.gmail.com>
In-Reply-To: <CAAOTY__r-2aQLK+oy6uRFnu3xExngBYrSAQ7jCfhWx+Ti0UgFw@mail.gmail.com>
From:   Chun-Kuang Hu <chunkuang.hu@kernel.org>
Date:   Sun, 8 Nov 2020 10:58:19 +0800
Message-ID: <CAAOTY_-EgZuxG=6J2WgO7awAcOePXuH8a6_rHENM7C45m-H7ew@mail.gmail.com>
Subject: Re: [PATCH] drm/mediatek: Optimize functions which do not need to return
To:     Chun-Kuang Hu <chunkuang.hu@kernel.org>
Cc:     Bernard Zhao <bernard@vivo.com>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        DRI Development <dri-devel@lists.freedesktop.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@lists.infradead.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        opensource.kernel@vivo.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi, Bernard:

Chun-Kuang Hu <chunkuang.hu@kernel.org> =E6=96=BC 2020=E5=B9=B410=E6=9C=881=
7=E6=97=A5 =E9=80=B1=E5=85=AD =E4=B8=8A=E5=8D=8810:50=E5=AF=AB=E9=81=93=EF=
=BC=9A
>
> Bernard Zhao <bernard@vivo.com> =E6=96=BC 2020=E5=B9=B410=E6=9C=8813=E6=
=97=A5 =E9=80=B1=E4=BA=8C =E4=B8=8B=E5=8D=884:55=E5=AF=AB=E9=81=93=EF=BC=9A
> >
> > Function mtk_hdmi_aud_set_input always return 0, no need to
> > keep the return value. Functions mtk_hdmi_aud_enable_packet &
> > mtk_hdmi_aud_on_off_hw_ncts are the same, these two functions
> > just call next functions. Maybe it`s a bit better to just call
> > the inner function.
>
> Reviewed-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
>

Applied to mediatek-drm-next [1], thanks.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/=
log/?h=3Dmediatek-drm-next

Regards,
Chun-Kuang.

> >
> > Signed-off-by: Bernard Zhao <bernard@vivo.com>
> > ---
> >  drivers/gpu/drm/mediatek/mtk_hdmi.c | 27 +++++++--------------------
> >  1 file changed, 7 insertions(+), 20 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/medi=
atek/mtk_hdmi.c
> > index a97725680d4e..f1d987df0550 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c
> > +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> > @@ -870,19 +870,8 @@ static void mtk_hdmi_video_set_display_mode(struct=
 mtk_hdmi *hdmi,
> >         mtk_hdmi_hw_msic_setting(hdmi, mode);
> >  }
> >
> > -static int mtk_hdmi_aud_enable_packet(struct mtk_hdmi *hdmi, bool enab=
le)
> > -{
> > -       mtk_hdmi_hw_send_aud_packet(hdmi, enable);
> > -       return 0;
> > -}
> >
> > -static int mtk_hdmi_aud_on_off_hw_ncts(struct mtk_hdmi *hdmi, bool on)
> > -{
> > -       mtk_hdmi_hw_ncts_enable(hdmi, on);
> > -       return 0;
> > -}
> > -
> > -static int mtk_hdmi_aud_set_input(struct mtk_hdmi *hdmi)
> > +static void mtk_hdmi_aud_set_input(struct mtk_hdmi *hdmi)
> >  {
> >         enum hdmi_aud_channel_type chan_type;
> >         u8 chan_count;
> > @@ -912,8 +901,6 @@ static int mtk_hdmi_aud_set_input(struct mtk_hdmi *=
hdmi)
> >         chan_count =3D mtk_hdmi_aud_get_chnl_count(chan_type);
> >         mtk_hdmi_hw_aud_set_i2s_chan_num(hdmi, chan_type, chan_count);
> >         mtk_hdmi_hw_aud_set_input_type(hdmi, hdmi->aud_param.aud_input_=
type);
> > -
> > -       return 0;
> >  }
> >
> >  static int mtk_hdmi_aud_set_src(struct mtk_hdmi *hdmi,
> > @@ -921,7 +908,7 @@ static int mtk_hdmi_aud_set_src(struct mtk_hdmi *hd=
mi,
> >  {
> >         unsigned int sample_rate =3D hdmi->aud_param.codec_params.sampl=
e_rate;
> >
> > -       mtk_hdmi_aud_on_off_hw_ncts(hdmi, false);
> > +       mtk_hdmi_hw_ncts_enable(hdmi, false);
> >         mtk_hdmi_hw_aud_src_disable(hdmi);
> >         mtk_hdmi_clear_bits(hdmi, GRL_CFG2, CFG2_ACLK_INV);
> >
> > @@ -959,7 +946,7 @@ static int mtk_hdmi_aud_output_config(struct mtk_hd=
mi *hdmi,
> >                                       struct drm_display_mode *display_=
mode)
> >  {
> >         mtk_hdmi_hw_aud_mute(hdmi);
> > -       mtk_hdmi_aud_enable_packet(hdmi, false);
> > +       mtk_hdmi_hw_send_aud_packet(hdmi, false);
> >
> >         mtk_hdmi_aud_set_input(hdmi);
> >         mtk_hdmi_aud_set_src(hdmi, display_mode);
> > @@ -968,8 +955,8 @@ static int mtk_hdmi_aud_output_config(struct mtk_hd=
mi *hdmi,
> >
> >         usleep_range(50, 100);
> >
> > -       mtk_hdmi_aud_on_off_hw_ncts(hdmi, true);
> > -       mtk_hdmi_aud_enable_packet(hdmi, true);
> > +       mtk_hdmi_hw_ncts_enable(hdmi, true);
> > +       mtk_hdmi_hw_send_aud_packet(hdmi, true);
> >         mtk_hdmi_hw_aud_unmute(hdmi);
> >         return 0;
> >  }
> > @@ -1097,13 +1084,13 @@ static int mtk_hdmi_output_init(struct mtk_hdmi=
 *hdmi)
> >
> >  static void mtk_hdmi_audio_enable(struct mtk_hdmi *hdmi)
> >  {
> > -       mtk_hdmi_aud_enable_packet(hdmi, true);
> > +       mtk_hdmi_hw_send_aud_packet(hdmi, true);
> >         hdmi->audio_enable =3D true;
> >  }
> >
> >  static void mtk_hdmi_audio_disable(struct mtk_hdmi *hdmi)
> >  {
> > -       mtk_hdmi_aud_enable_packet(hdmi, false);
> > +       mtk_hdmi_hw_send_aud_packet(hdmi, false);
> >         hdmi->audio_enable =3D false;
> >  }
> >
> > --
> > 2.28.0
> >