Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201108022321.2114430-1-natechancellor@gmail.com>
In-Reply-To: <20201108022321.2114430-1-natechancellor@gmail.com>
From:   Krzysztof Kozlowski <krzk@kernel.org>
Date:   Sun, 8 Nov 2020 10:31:10 +0100
Message-ID: <CAJKOXPdVVgRMaCPfq3nPR232KQyKVVewm5LveUSuyfqE8sScQg@mail.gmail.com>
Subject: Re: [PATCH] arm64: dts: imx: Fix imx8mm-kontron-n801x-s.dtb target
To:     Nathan Chancellor <natechancellor@gmail.com>
Cc:     Shawn Guo <shawnguo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
        Frieder Schrempf <frieder.schrempf@kontron.de>,
        linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sun, 8 Nov 2020 at 03:23, Nathan Chancellor <natechancellor@gmail.com> wrote:

Hi,

Thanks for the fixes.

Please mark patches with versions, this should be v2. Otherwise
maintainer might apply the older one,
You also need to add versioning changelog after ---.

> $ make -skj"$(nproc)" ARCH=arm64 CROSS_COMPILE=aarch64-linux- \
> INSTALL_DTBS_PATH=rootfs distclean defconfig dtbs dtbs_install

All this is still irrelevant. Just: "make dtbs". Don't add unrelated
details like how many processes you spawn, where do you want to
install DTBS or even all other make targets.
Everyone should know how to cross compile so simple: make dtbs

> ...
> make[3]: *** No rule to make target
> 'rootfs/freescale/imx8mm-kontron-n801x-s.dts', needed by
> '__dtbs_install'

This should be joined with previous line. I mentioned it in your previous patch.

> ...

Also not needed dots. This is small change and should go with small
and accurate description. Blowing the description does not help.

Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>

Best regards,
Krzysztof