Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp2500091pxb; Sun, 8 Nov 2020 02:57:28 -0800 (PST) X-Google-Smtp-Source: ABdhPJws25c6K+Jlr4jaoL/PJsmSSMdYGv9+lWiUaUTLKBIX+eCWzCYtStRlGRKpzaYtHBzvYp3k X-Received: by 2002:a50:8245:: with SMTP id 63mr10442896edf.133.1604833048289; Sun, 08 Nov 2020 02:57:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604833048; cv=none; d=google.com; s=arc-20160816; b=CsP9W9Q5fNQ+Jo8/bwhd2QcMCg0KpkTnwjVNQWdgOrybWlwbnTANmskzACVN3W3pBX CDee4USHNT2kVRiOJcR/pYaoP95+B1BC5t+32sCsOczMoslTaI7k273za4CkdUjcoaG0 J/wTPBuvTh06M9CxA1DwXOR1ekKTwZzbp/1zkDbawyFe+OmdBuZ/bfakjDtDieNeV/qQ uys8ytXyuGRJnQDp2pf1+cD335tsHklTfVTuJduSGDTr8Y7j6UdrD5UgWv28KhZ5Jz/b cb+/F8NVeM7Sle5yKxugqVPmpzvtUFzgytOQGGiuLxg+shwSuRc/dFP6hDeLylMQJJqy r0yQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=5yga+YhYMQ17qZclkaFZvTzGBgGQ2s4DwtuMr5hjbJ8=; b=jNhU1lMjMQZdRVBcf/x6gn4LBGQD8lu6a48cL6cb/ymJwVTYL+wpCPom34u7x+ZfpY pgQTQx3D8MrmFfv0aAEf0aQGG7ToUC1jpLpt8vH7znryb3R1B2UccnZo/dkGuuMiUWh+ 7zX3BJx7z0KMFn2jTXIBgraJiqYH5+koDh8mpD894SDAVs60LWcsdNxyWHx9doj5WbQB 6cD22fDLVoDVHW6lFnk5pt4O0R2dTRSGZum+B7UEJ3utLSl536qoK5Ab9Xf3bfW0WDLZ LIDOclDN9RPKuqksUX7zLgBNrp0A6cyRH+ycoGciuNBpENPrKSICvLujn+i6DLAT7oTa /7Kw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gn40si5102507ejc.710.2020.11.08.02.57.04; Sun, 08 Nov 2020 02:57:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728106AbgKHKzk (ORCPT + 99 others); Sun, 8 Nov 2020 05:55:40 -0500 Received: from asavdk3.altibox.net ([109.247.116.14]:52470 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727348AbgKHKzk (ORCPT ); Sun, 8 Nov 2020 05:55:40 -0500 Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id D376220025; Sun, 8 Nov 2020 11:55:36 +0100 (CET) Date: Sun, 8 Nov 2020 11:55:35 +0100 From: Sam Ravnborg To: Alexandru Gagniuc Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, Jernej Skrabec , Mauro Carvalho Chehab , Neil Armstrong , David Airlie , Mark Brown , Jonas Karlman , open list , Andrzej Hajda , Rob Herring , Thomas Bogendoerfer , Laurent Pinchart Subject: Re: [PATCH v3 2/3] drm/bridge: sii902x: Enable I/O and core VCC supplies if present Message-ID: <20201108105535.GB1161483@ravnborg.org> References: <20200928173056.1674274-1-mr.nuke.me@gmail.com> <20201020221501.260025-2-mr.nuke.me@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201020221501.260025-2-mr.nuke.me@gmail.com> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=VbvZwmh9 c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=kj9zAlcOel0A:10 a=pGLkceISAAAA:8 a=f2O8UAJn3HDJhdU-9UYA:9 a=CjuIK1q_8ugA:10 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Alexandru On Tue, Oct 20, 2020 at 05:14:58PM -0500, Alexandru Gagniuc wrote: > On the SII9022, the IOVCC and CVCC12 supplies must reach the correct > voltage before the reset sequence is initiated. On most boards, this > assumption is true at boot-up, so initialization succeeds. > > However, when we try to initialize the chip with incorrect supply > voltages, it will not respond to I2C requests. sii902x_probe() fails > with -ENXIO. > > To resolve this, look for the "iovcc" and "cvcc12" regulators, and > make sure they are enabled before starting the reset sequence. If > these supplies are not available in devicetree, then they will default > to dummy-regulator. In that case everything will work like before. > > This was observed on a STM32MP157C-DK2 booting in u-boot falcon mode. > On this board, the supplies would be set by the second stage > bootloader, which does not run in falcon mode. > > Signed-off-by: Alexandru Gagniuc Thanks, applied series to drm-misc-next. I fixed two checkpatch --strict warnings while applying. Sam