Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sun, 8 Nov 2020 12:13:46 -0700
From:   Nathan Chancellor <natechancellor@gmail.com>
To:     Krzysztof Kozlowski <krzk@kernel.org>
Cc:     Shawn Guo <shawnguo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
        Frieder Schrempf <frieder.schrempf@kontron.de>,
        linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arm64: dts: imx: Fix imx8mm-kontron-n801x-s.dtb target
Message-ID: <20201108191346.GA4061631@ubuntu-m3-large-x86>
References: <20201108022321.2114430-1-natechancellor@gmail.com>
 <CAJKOXPdVVgRMaCPfq3nPR232KQyKVVewm5LveUSuyfqE8sScQg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAJKOXPdVVgRMaCPfq3nPR232KQyKVVewm5LveUSuyfqE8sScQg@mail.gmail.com>
Precedence: bulk

Hi Krzysztof,

On Sun, Nov 08, 2020 at 10:31:10AM +0100, Krzysztof Kozlowski wrote:
> On Sun, 8 Nov 2020 at 03:23, Nathan Chancellor <natechancellor@gmail.com> wrote:
> 
> Hi,
> 
> Thanks for the fixes.
> 
> Please mark patches with versions, this should be v2. Otherwise
> maintainer might apply the older one,
> You also need to add versioning changelog after ---.

I have only sent this one patch. It looks like Anders Roxell sent an
identical patch though:

https://lore.kernel.org/linux-devicetree/20201105111823.1613337-1-anders.roxell@linaro.org/

> > $ make -skj"$(nproc)" ARCH=arm64 CROSS_COMPILE=aarch64-linux- \
> > INSTALL_DTBS_PATH=rootfs distclean defconfig dtbs dtbs_install
> 
> All this is still irrelevant. Just: "make dtbs". Don't add unrelated
> details like how many processes you spawn, where do you want to
> install DTBS or even all other make targets.
> Everyone should know how to cross compile so simple: make dtbs

Sure, I will update it, my apologies.

> > ...
> > make[3]: *** No rule to make target
> > 'rootfs/freescale/imx8mm-kontron-n801x-s.dts', needed by
> > '__dtbs_install'
> 
> This should be joined with previous line. I mentioned it in your previous patch.

Sure, I usually just let my editor do the auto wrapping but I will put
it all onto one line!

> > ...
> 
> Also not needed dots. This is small change and should go with small
> and accurate description. Blowing the description does not help.
> 
> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
> 
> Best regards,
> Krzysztof

Thank you for the review, I will sent v2 along shortly.

Cheers,
Nathan