Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751330AbWHSPm0 (ORCPT ); Sat, 19 Aug 2006 11:42:26 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751495AbWHSPm0 (ORCPT ); Sat, 19 Aug 2006 11:42:26 -0400 Received: from 83-64-96-243.bad-voeslau.xdsl-line.inode.at ([83.64.96.243]:51920 "EHLO mognix.dark-green.com") by vger.kernel.org with ESMTP id S1751330AbWHSPmZ (ORCPT ); Sat, 19 Aug 2006 11:42:25 -0400 Message-ID: <44E7315F.5090004@ed-soft.at> Date: Sat, 19 Aug 2006 17:42:23 +0200 From: Edgar Hucek User-Agent: Thunderbird 1.5.0.5 (X11/20060728) MIME-Version: 1.0 To: Thomas Meyer CC: linux-kernel@vger.kernel.org, greg@kroah.com, akpm@osdl.org Subject: Re: [PATCH] x86: Fix dmi detection of MacBookPro and iMac References: <44E703D2.6050302@m3y3r.de> In-Reply-To: <44E703D2.6050302@m3y3r.de> X-Enigmail-Version: 0.94.0.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2025 Lines: 50 Ups. You are right. Signed-off-by: Edgar Hucek Thomas Meyer schrieb: > This commit: > http://kernel.org/git/?p=linux/kernel/git/gregkh/linux-2.6.git;a=commit;h=b64ef8afa58f397e1eaba2bd9ecaa6812064d464 > contained a wrong DMI_MATCH. > > Signed-off-by: Thomas Meyer > --- > > The error can also be found in this broken out patch: > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.18-rc4/2.6.18-rc4-mm1/broken-out/add-force-of-use-mmconfig.patch > > Please change DMI_BIOS_VERSION into DMI_PRODUCT_NAME > > With kind regards > Thomas > > diff --git a/drivers/video/imacfb.c b/drivers/video/imacfb.c > index b485bec..a6a0ffd 100644 > --- a/drivers/video/imacfb.c > +++ b/drivers/video/imacfb.c > @@ -71,10 +71,10 @@ static int set_system(struct dmi_system_ > static struct dmi_system_id __initdata dmi_system_table[] = { > { set_system, "iMac4,1", { > DMI_MATCH(DMI_BIOS_VENDOR,"Apple Computer, Inc."), > - DMI_MATCH(DMI_BIOS_VERSION,"iMac4,1") }, (void*)M_I17}, > + DMI_MATCH(DMI_PRODUCT_NAME,"iMac4,1") }, (void*)M_I17}, > { set_system, "MacBookPro1,1", { > DMI_MATCH(DMI_BIOS_VENDOR,"Apple Computer, Inc."), > - DMI_MATCH(DMI_BIOS_VERSION,"MacBookPro1,1") }, (void*)M_I17}, > + DMI_MATCH(DMI_PRODUCT_NAME,"MacBookPro1,1") }, (void*)M_I17}, > { set_system, "MacBook1,1", { > DMI_MATCH(DMI_BIOS_VENDOR,"Apple Computer, Inc."), > DMI_MATCH(DMI_PRODUCT_NAME,"MacBook1,1")}, (void *)M_MACBOOK}, > > - > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/