Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp2946019pxb;
        Sun, 8 Nov 2020 20:19:39 -0800 (PST)
X-Google-Smtp-Source: ABdhPJzo59pvSTZI912RNnV3kIryOq60eAP2QOy+6ae+8U3yeYGDffi0/y0L6v5Tqa1B3+k11kIC
X-Received: by 2002:aa7:c5d0:: with SMTP id h16mr13846492eds.7.1604895579557;
        Sun, 08 Nov 2020 20:19:39 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1604895579; cv=none;
        d=google.com; s=arc-20160816;
        b=wSUqM4GG5YNkNBqZ0etF6E6eCFfX9DFhLvzbfQlmp4AoaehmIPofzQLiCodl0ebGjg
         XH/xaes6+5S86htN3KXzkxDMCjG9JPGNetU/IBVfxCzzTRK56S4TQUKuqhpoLZtLlSL6
         DclFfwBMk1Jq/ljRkKishMVLrWBZ+YPU+BLyC25C0dSqwWJpTa8Fv29Z0rC/qTaj0rKe
         5BLK1biB/CQZAC/VYtzGFL8aKL39IhGxrdFQyUlBxFxc5jcRG46HHzd/kZtKKIO4OBr5
         it4ecnOttkzqwhoyjvnHFkwQZ6ewogXYAtX8O+zMxP0W+UiYjKtxGug07JkbdSFhZHrB
         6SVg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:dkim-signature:content-transfer-encoding
         :content-language:in-reply-to:mime-version:user-agent:date
         :message-id:from:references:cc:to:subject;
        bh=GyczsSIPQ2H7XyF7aw5OG6GSzZRXZ+iyOimEZqVpguI=;
        b=pqlhAaV3uUDjy1IuInhhIpf9sQ49T70EjElkXyKedThU8DX8wxw5+fHgQbE83lU1H4
         dp6nNe45ioQwTpZvac8hVBDis2jviq1mFQf1GmlZAvjzxy6raoSX28to6UDixLwAr2Tw
         6O72DEVbLY9573ZJF0aP+4n+mqnB/80JF2LAstTLjuObMDyLYX37VcfWXYzbJUYEsxsS
         rF6lgW6iJ5R5CiCevP+W3VorYx9+VfonWOQ4yU7KPfiwXgzUlgP+1nomuJzmEgor0n1H
         yj+fzi9TzxlL8vQZozqz8TDFhdOZ1N2XlWrLf3JhD8q+WlwBjWK2kl0M2S07IC8roHiJ
         gxAw==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=NcFwCzlI;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id c9si6229581eds.291.2020.11.08.20.19.04;
        Sun, 08 Nov 2020 20:19:39 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=NcFwCzlI;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1729025AbgKIERK (ORCPT <rfc822;deadfox.tw@gmail.com>
        + 99 others); Sun, 8 Nov 2020 23:17:10 -0500
Received: from hqnvemgate26.nvidia.com ([216.228.121.65]:4001 "EHLO
        hqnvemgate26.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1728038AbgKIERK (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 8 Nov 2020 23:17:10 -0500
Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, AES256-SHA)
        id <B5fa8c2c90001>; Sun, 08 Nov 2020 20:17:13 -0800
Received: from [10.2.49.75] (10.124.1.5) by HQMAIL107.nvidia.com
 (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 9 Nov
 2020 04:17:09 +0000
Subject: Re: [PATCH 2/2] tomoyo: Fixed typo in documentation
To:     Souptick Joarder <jrdr.linux@gmail.com>
CC:     <takedakn@nttdata.co.jp>,
        Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
        James Morris <jmorris@namei.org>,
        "Serge E. Hallyn" <serge@hallyn.com>,
        linux-security-module <linux-security-module@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <1604737451-19082-1-git-send-email-jrdr.linux@gmail.com>
 <1604737451-19082-2-git-send-email-jrdr.linux@gmail.com>
 <f5ed0413-315c-d5d0-e33f-c2b247a28da2@nvidia.com>
 <CAFqt6zaRP56DPRHTGMNiY3KpdOKPB_SeeuFagUbkmQKQ6mKD2A@mail.gmail.com>
From:   John Hubbard <jhubbard@nvidia.com>
Message-ID: <7c60a6f5-414f-99e8-68c3-ca3b60fe89e9@nvidia.com>
Date:   Sun, 8 Nov 2020 20:17:09 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <CAFqt6zaRP56DPRHTGMNiY3KpdOKPB_SeeuFagUbkmQKQ6mKD2A@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.124.1.5]
X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To
 HQMAIL107.nvidia.com (172.20.187.13)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1604895433; bh=GyczsSIPQ2H7XyF7aw5OG6GSzZRXZ+iyOimEZqVpguI=;
        h=Subject:To:CC:References:From:Message-ID:Date:User-Agent:
         MIME-Version:In-Reply-To:Content-Type:Content-Language:
         Content-Transfer-Encoding:X-Originating-IP:X-ClientProxiedBy;
        b=NcFwCzlIIkdM2jCJN3EMJWiVtpT610ymFCkhLJzj2vxhiHAT5isr8uX3wzPA862Fp
         U7IFUbiMUdJxAIDzWbW677vYiaQgtcAp3ByBOrxcF31UrwGHXFqoYZXdDIxE1MvfM9
         rWd99Y2W71EkELaRi50GU1Ns38LsaW4EykWseuyMsI4uffl2yVfzroHJXTXoMA3hMR
         pZ28L1Ar6lGSwBcyNCCdVhyLBOSfn9iiJ7noJBz9SzWS/V7s5ce4Z0FpLDZd9C8SiQ
         y3Qf6EzYP1APkfnN1nmBSehFD5/ElNK8Y1rcXNX/JqafBuhkEkzOr1htFIzu0VhO4G
         h1w3idpkvjhsQ==
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/8/20 7:41 PM, Souptick Joarder wrote:
> On Sat, Nov 7, 2020 at 2:27 PM John Hubbard <jhubbard@nvidia.com> wrote:
>>
>> On 11/7/20 12:24 AM, Souptick Joarder wrote:
>>> Fixed typo s/Poiner/Pointer
>>>
>>> Fixes: 5b636857fee6 ("TOMOYO: Allow using argv[]/envp[] of execve() as conditions.")
>>> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
>>> Cc: John Hubbard <jhubbard@nvidia.com>
>>> ---
>>>    security/tomoyo/domain.c | 2 +-
>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/security/tomoyo/domain.c b/security/tomoyo/domain.c
>>> index bd748be..7b2babe 100644
>>> --- a/security/tomoyo/domain.c
>>> +++ b/security/tomoyo/domain.c
>>> @@ -891,7 +891,7 @@ int tomoyo_find_next_domain(struct linux_binprm *bprm)
>>>     *
>>>     * @bprm: Pointer to "struct linux_binprm".
>>>     * @pos:  Location to dump.
>>> - * @dump: Poiner to "struct tomoyo_page_dump".
>>> + * @dump: Pointer to "struct tomoyo_page_dump".
>>
>> Not worth a separate patch, especially since the original comment is merely
>> copying the C sources, and as such, does not add any value.
>>
>> I'd either a) craft a new documentation line that adds some value, or b) just
>> merge this patch into the previous one, and make a note in the commit
>> description to the effect that you've included a trivial typo fix as long
>> as you're there.
>>
> 
> John, as patch[1/2] is dropped, can we take this patch forward with some more
> updates in documentations ?
> 

That's really up to the folks who work on this code. Personally I would rarely
post a patch *just* for this, but on the other hand it is a correction. Either
way is fine with me of course.


thanks,
-- 
John Hubbard
NVIDIA