Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Saurav Kashyap <skashyap@marvell.com>
To:     "xiakaixu1987@gmail.com" <xiakaixu1987@gmail.com>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>
CC:     "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Kaixu Xia <kaixuxia@tencent.com>
Subject: RE: [PATCH] scsi: bnx2fc: fix comparison to bool warning
Thread-Topic: [PATCH] scsi: bnx2fc: fix comparison to bool warning
Thread-Index: AQHWtSZXw7LwU+PJ/EKQqIb/yr/v3am/PtBw
Date:   Mon, 9 Nov 2020 04:56:40 +0000
Message-ID: <DM6PR18MB3034D9FD587A112D92062257D2EA0@DM6PR18MB3034.namprd18.prod.outlook.com>
References: <1604767920-8361-1-git-send-email-kaixuxia@tencent.com>
In-Reply-To: <1604767920-8361-1-git-send-email-kaixuxia@tencent.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 6f4b65ea-04e4-45b5-a27d-08d8846bd880
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Nov 2020 04:56:40.0621
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: NbkymrKcudEENrSKJFcdKi0ISBhqZ4FgvF15UkDTJQ/8L48dq5wV4XYOTV7AnC15IAOjCAq83k/UBgHY8s2Gjw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR18MB2602
X-OriginatorOrg: marvell.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.312,18.0.737
 definitions=2020-11-09_01:2020-11-05,2020-11-09 signatures=0
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,


> -----Original Message-----
> From: xiakaixu1987@gmail.com <xiakaixu1987@gmail.com>
> Sent: Saturday, November 7, 2020 10:22 PM
> To: jejb@linux.ibm.com; martin.petersen@oracle.com
> Cc: linux-scsi@vger.kernel.org; linux-kernel@vger.kernel.org; Kaixu Xia
> <kaixuxia@tencent.com>
> Subject: [PATCH] scsi: bnx2fc: fix comparison to bool warning
>=20
> From: Kaixu Xia <kaixuxia@tencent.com>
>=20
> Fix the following coccicheck warning:
>=20
> ./drivers/scsi/bnx2fc/bnx2fc_fcoe.c:2089:5-23: WARNING: Comparison to boo=
l
> ./drivers/scsi/bnx2fc/bnx2fc_fcoe.c:2187:5-23: WARNING: Comparison to boo=
l
>=20
> Reported-by: Tosk Robot <tencent_os_robot@tencent.com>
> Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
> ---
>  drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
> b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
> index 6890bbe04a8c..b612f5ea647e 100644
> --- a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
> +++ b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
> @@ -2086,7 +2086,7 @@ static int __bnx2fc_disable(struct fcoe_ctlr *ctlr)
>  {
>  	struct bnx2fc_interface *interface =3D fcoe_ctlr_priv(ctlr);
>=20
> -	if (interface->enabled =3D=3D true) {
> +	if (interface->enabled) {
>  		if (!ctlr->lp) {
>  			pr_err(PFX "__bnx2fc_disable: lport not found\n");
>  			return -ENODEV;
> @@ -2184,7 +2184,7 @@ static int __bnx2fc_enable(struct fcoe_ctlr *ctlr)
>  	struct cnic_fc_npiv_tbl *npiv_tbl;
>  	struct fc_lport *lport;
>=20
> -	if (interface->enabled =3D=3D false) {
> +	if (!interface->enabled) {
>  		if (!ctlr->lp) {
>  			pr_err(PFX "__bnx2fc_enable: lport not found\n");
>  			return -ENODEV;
>
Thanks for a patch.

Acked-by: Saurav Kashyap <skashyap@marvell.com>

Thanks,
~Saurav
 --
> 2.20.0