Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp2998637pxb; Sun, 8 Nov 2020 22:39:26 -0800 (PST) X-Google-Smtp-Source: ABdhPJyMT4o0WDt/NMkLm4wQZW3a6i1TXx5Bpcqt1xlVCi/Ht4uxdinZKdAUZjss+vTENL7nMykH X-Received: by 2002:a17:906:a00c:: with SMTP id p12mr14089630ejy.249.1604903966444; Sun, 08 Nov 2020 22:39:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604903966; cv=none; d=google.com; s=arc-20160816; b=oYVSqwcmAW/+kXm+To7b1J9/lj+J6usv4VO2AngeNCBB9KjoMNySqYGvf5i1WKLqDu VUV8XPZ4M38K+0eSvZq/S5DlAanwzS80PQV7nTUJmUoXtybUTnSJqGdrN/LkWBS0yFcl 25oKd6acIim9jLsTa++FU4Ck0OG6AfsWQjvqzBT02ga6RGdFLTNnTFR4RnM1leoFINR+ 0tYD9AZ9kS3CV/1mg7kGMoSZfJpnNqObHgDpG2DNutmThDs/QykmrWgVOYb+amRR13T4 d94MwAR3IajpU5Za1sLDDu6Dd21C7vD8+z1IQdcHgmF3pcX/OwmChEh8yPa6yy8jgyYX wfWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:ironport-sdr :ironport-sdr; bh=1TXs7QmEG2dHW+3CggTLWUFxbY/rNWhz7EDsrchFS1w=; b=IM4opSSBBZqdjKYWL6uAiZQcPMRTCYhPHSth+v6J3MYNJnjT8fJMVA+I01EE8B/eoN 7v+1yhBsKhtwWCsBhP/5cl7XUeqlD6rruyXY4QuNIEhyRa2ODZCZtshkxyb3G7AUEQwS bnMRpcJgneLUMRvwmktQA/u1/5n8K0Xob/LG9qq2LcdJer99fsi7ARzZLNgFiIzkN4qr e6SrBdsJ/+cmTqrwzwx2jrcE3STDaxG7s4ufnNVCQ3ivfl4VHQwE/LYAGVtyK4s+vs3T vmrw4O4SVO+rJvIZnl+oV3bWk6LnuzLF7ATvgKOXsKj/zLSh5/GjSiVAwhtqUrUY2Ab3 XQWA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a23si6862263edn.292.2020.11.08.22.39.03; Sun, 08 Nov 2020 22:39:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729534AbgKIGes (ORCPT + 99 others); Mon, 9 Nov 2020 01:34:48 -0500 Received: from mga12.intel.com ([192.55.52.136]:27633 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729076AbgKIGer (ORCPT ); Mon, 9 Nov 2020 01:34:47 -0500 IronPort-SDR: Hy1ZvAHhX4b+JsYm7tbuu3s643L7rxOYF6ZHLe2vWLTgCrSXKegtiG/aK06AmAyV+rYDksBn6c UaYyZHKiMwgw== X-IronPort-AV: E=McAfee;i="6000,8403,9799"; a="149035416" X-IronPort-AV: E=Sophos;i="5.77,462,1596524400"; d="scan'208";a="149035416" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Nov 2020 22:34:47 -0800 IronPort-SDR: epgwv5nkki90oJuuM6jW+S8ec5md4ptPQZLXv9wT+rvJ5nOm4ZXwF4aBldsS9I312p4Oykmr0t e1Ge+n1wmpog== X-IronPort-AV: E=Sophos;i="5.77,462,1596524400"; d="scan'208";a="530588466" Received: from tassilo.jf.intel.com ([10.54.74.11]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Nov 2020 22:34:47 -0800 Date: Sun, 8 Nov 2020 22:34:46 -0800 From: Andi Kleen To: Like Xu Cc: Paolo Bonzini , Peter Zijlstra , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , wei.w.wang@intel.com, linux-kernel@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH v12 01/11] perf/x86: Fix variable types for LBR registers Message-ID: <20201109063446.GM466880@tassilo.jf.intel.com> References: <20200613080958.132489-1-like.xu@linux.intel.com> <20200613080958.132489-2-like.xu@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200613080958.132489-2-like.xu@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jun 13, 2020 at 04:09:46PM +0800, Like Xu wrote: > From: Wei Wang > > The MSR variable type can be 'unsigned int', which uses less memory than > the longer 'unsigned long'. Fix 'struct x86_pmu' for that. The lbr_nr won't > be a negative number, so make it 'unsigned int' as well. Hi, What's the status of this patchkit? It would be quite useful to me (and various other people) to use LBRs in guest. I reviewed it earlier and the patches all looked good to me. But i don't see it in any -next tree. Reviewed-by: Andi Kleen Could it please be merged? Thanks, -Andi