Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2] mm/gup_test: GUP_TEST depends on DEBUG_FS
To:     John Hubbard <jhubbard@nvidia.com>,
        Barry Song <song.bao.hua@hisilicon.com>,
        akpm@linux-foundation.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Cc:     linuxarm@huawei.com, Ralph Campbell <rcampbell@nvidia.com>,
        John Garry <john.garry@huawei.com>
References: <20201108083732.15336-1-song.bao.hua@hisilicon.com>
 <cf1b1b35-c608-9b5e-0c1a-216431b83750@nvidia.com>
From:   Randy Dunlap <rdunlap@infradead.org>
Message-ID: <071150d8-9159-91c4-118d-b19c2bd785ea@infradead.org>
Date:   Sun, 8 Nov 2020 23:52:14 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <cf1b1b35-c608-9b5e-0c1a-216431b83750@nvidia.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 11/8/20 11:45 PM, John Hubbard wrote:
> On 11/8/20 12:37 AM, Barry Song wrote:
>> Without DEBUG_FS, all the code in gup_test becomes meaningless. For sure
>> kernel provides debugfs stub while DEBUG_FS is disabled, but the point
>> here is that GUP_TEST can do nothing without DEBUG_FS.
>>
>> Cc: John Hubbard <jhubbard@nvidia.com>
>> Cc: Ralph Campbell <rcampbell@nvidia.com>
>> Cc: Randy Dunlap <rdunlap@infradead.org>
>> Suggested-by: John Garry <john.garry@huawei.com>
>> Signed-off-by: Barry Song <song.bao.hua@hisilicon.com>
>> ---
>>   -v2:
>>   add comment as a prompt to users as commented by John and Randy, thanks!
>>
>>   mm/Kconfig | 4 ++++
>>   1 file changed, 4 insertions(+)
> 
> Thanks for suffering through a lot of discussion about this!
> 
> Reviewed-by: John Hubbard <jhubbard@nvidia.com>
> 
> 
> thanks,

Acked-by: Randy Dunlap <rdunlap@infradead.org>

thanks.

-- 
~Randy