Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp3073509pxb; Mon, 9 Nov 2020 01:34:56 -0800 (PST) X-Google-Smtp-Source: ABdhPJz02WUKcMdFSo3kUty7wV++FSkyG+qRUAZCj5b/u9AnLhJ5dzl8yGory9NKEvX97Ei1KA9N X-Received: by 2002:a17:906:8142:: with SMTP id z2mr13730059ejw.30.1604914496232; Mon, 09 Nov 2020 01:34:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604914496; cv=none; d=google.com; s=arc-20160816; b=vLHrr3YwiTXLCfL4Je5YjhAUmdBXT3p4cq0QH+/867i/T/3HHFROrwCePiKhbg0J6x RE9Iq9to/i6vZra0JSUaE+4bL9DR1VIylnYCuENvAwcDLRpvxjBN7NpZiosMQi22VcPZ ykA62ewGUp2agmTooNq7I4YFovbCkeFsw+kLI2Rsdqk0XLOmvE5ewuOVo4B1UksyXB08 xC1rUTW6JC9OfaEtti0AMghXoW/0O0jMrYGnN5xkqEgWLpR2xGZ7ot/xEgsj/FIKmqlS 3jkBLIBhMj/PXiwbzTIPPtcdMshDXs9E9n/sKGnFjg1lpIFUUIK+AU2dpQf4GNQIQTSg p0UA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=yDoJ4lM5/zFxDk7HQ7jfU8i25wqgFyGo3fgaf+U7nxc=; b=Z8vJ6wiJmN8K+UEYfmUvB3Bh87FXjOVS6bG/0MVzBOo0OS6woChmFYqx1qMC1cqHGA UPg8RRtjX5nBlBaZ6CBWpPXgOQ6rvvIOiC5PUgcc4roWkv24gE5nMy32IwV2rG/lXUfe 3oGXnrLixvn52aXMztU000+0ALga2pRp8dGIEb0sUN4xb6L1KRrYfspKSBtXqpTsA3i2 1e7BlOt885ZutKFUAiWECA6Jk6QfExokouY1CKaplJOc5quxjfOBdvflH+hQZ5X/L4c4 q4uqfxqVIaU6Ta8yRz2ISbPx+qJDQT4/JxpVWM4pKwq+RFMzQpps4IJvGo27AHmNgUIq SPeA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h27si7639002ejd.385.2020.11.09.01.34.33; Mon, 09 Nov 2020 01:34:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727077AbgKIJcX (ORCPT + 99 others); Mon, 9 Nov 2020 04:32:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44644 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726176AbgKIJcX (ORCPT ); Mon, 9 Nov 2020 04:32:23 -0500 Received: from smtp1.goneo.de (smtp1.goneo.de [IPv6:2001:1640:5::8:30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5BEC6C0613CF for ; Mon, 9 Nov 2020 01:32:22 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by smtp1.goneo.de (Postfix) with ESMTP id 04E4923F150; Mon, 9 Nov 2020 10:32:19 +0100 (CET) X-Virus-Scanned: by goneo X-Spam-Flag: NO X-Spam-Score: -2.983 X-Spam-Level: X-Spam-Status: No, score=-2.983 tagged_above=-999 tests=[ALL_TRUSTED=-1, AWL=-0.083, BAYES_00=-1.9] autolearn=ham Received: from smtp1.goneo.de ([127.0.0.1]) by localhost (smtp1.goneo.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EYVf58zyV78p; Mon, 9 Nov 2020 10:32:17 +0100 (CET) Received: from lem-wkst-02.lemonage.de. (hq.lemonage.de [87.138.178.34]) by smtp1.goneo.de (Postfix) with ESMTPA id CF0D323F2DC; Mon, 9 Nov 2020 10:32:16 +0100 (CET) From: poeschel@lemonage.de To: Miguel Ojeda Sandonis , linux-kernel@vger.kernel.org (open list) Cc: Lars Poeschel , Randy Dunlap Subject: [PATCH] auxdisplay: hd44780_common: Fix build error Date: Mon, 9 Nov 2020 10:31:54 +0100 Message-Id: <20201109093154.1080024-1-poeschel@lemonage.de> X-Mailer: git-send-email 2.28.0 In-Reply-To: <76f9cd1b-3ace-e8a8-aaee-8d64e0900603@infradead.org> References: <76f9cd1b-3ace-e8a8-aaee-8d64e0900603@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Lars Poeschel When building the hd44780_common driver without a driver that actually uses it like panel or hd44780 you got a build error, because hd44780_common uses charlcd, but did not select it. It's users did select it. This is fixed now. hd4478_common now selects charlcd in Kconfig and panel and hd44780 do not. They only select hd44780_common. Reported-by: Randy Dunlap Signed-off-by: Lars Poeschel --- drivers/auxdisplay/Kconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig index a69623124a26..a2b59b84bb88 100644 --- a/drivers/auxdisplay/Kconfig +++ b/drivers/auxdisplay/Kconfig @@ -27,6 +27,7 @@ config CHARLCD config HD44780_COMMON tristate "Common functions for HD44780 (and compatibles) LCD displays" if COMPILE_TEST + select CHARLCD help This is a module with the common symbols for HD44780 (and compatibles) displays. This is the code that multiple other modules use. It is not @@ -37,7 +38,6 @@ config HD44780_COMMON config HD44780 tristate "HD44780 Character LCD support" depends on GPIOLIB || COMPILE_TEST - select CHARLCD select HD44780_COMMON help Enable support for Character LCDs using a HD44780 controller. @@ -196,7 +196,6 @@ config ARM_CHARLCD menuconfig PARPORT_PANEL tristate "Parallel port LCD/Keypad Panel support" depends on PARPORT - select CHARLCD select HD44780_COMMON help Say Y here if you have an HD44780 or KS-0074 LCD connected to your -- 2.28.0