Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp3079684pxb;
        Mon, 9 Nov 2020 01:48:57 -0800 (PST)
X-Google-Smtp-Source: ABdhPJyEVotCMxi6gy2AB6R9G7OF9xu3THsNwrvaUNnj5nwzj3Dgc7fHxt4DD6aSFKfmTC/NSM93
X-Received: by 2002:aa7:d48d:: with SMTP id b13mr14034391edr.264.1604915337714;
        Mon, 09 Nov 2020 01:48:57 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1604915337; cv=none;
        d=google.com; s=arc-20160816;
        b=0FEX/MRDsTVJtDID9yzBh68HJnGfSO9fRhtQcnvU24d4b2FgDQmB5lZHr/YGEEVzOy
         baFVstwCBYcM8zxd3ZqywPAstkJ2aQdeD4bv0DiLJxXBaa+Rr0wdS0tYlQIeJGkaT036
         ktggG4bvoQDV1cVBEeGJepj4muS+nWMfg2pi5C9uY6iY5L0Ys0L0dg7eKezPQhalFIf0
         vS1nvabc1vFgnxk++RbMuAFg6+peuJvuXKot1ogoqvDgCPyIzZJTBRIy3LJ7nmHfnaqG
         Q9xUXA86v8F+eRtuoIVuqo+bzOOqDoTpm811L/2+uMj9ZfUsHLvt2tihVMx7wrfLmsEl
         8ggQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to
         :references:mime-version:dkim-signature;
        bh=b+fXAPRsR/uex6VU5/EqCVLiWplbh7G5vxH2O/MlyR4=;
        b=V5TTYEYT9ZWsP3/h8n08ENZD4q33u2oY1/2QRHXQMsWW7/icG7I2SiiirQe46ZEw9h
         3Jcy1ntklv1tD1kzpt7DB/tvt6EjdFajxoHB7ifm2jf55S1qQ9EiIv2zab78hWiRFE+O
         FpYa9lh2fcbMruReG1pDSMY4A4Eh2DQjAWPhn/4Hb/FemS81UrnIwp2q/nTylSt8OfVQ
         uT7msULSd1qUYbhYYJiCCwYdg/IRTyyw4hZYQIaLgTCyyraEP54ywnZMtkh8xp5LJS/O
         WTkm/+Y7KnxhNUo7u4rHtptgxiTxZt/AXT8UjhZxlunm91nupaY4eSukQErXqPl4OYUa
         1J2w==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@gmail.com header.s=20161025 header.b=pJhTvuH4;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id gw7si6617666ejb.657.2020.11.09.01.48.34;
        Mon, 09 Nov 2020 01:48:57 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@gmail.com header.s=20161025 header.b=pJhTvuH4;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1729107AbgKIJrG (ORCPT <rfc822;patchstalker@gmail.com>
        + 99 others); Mon, 9 Nov 2020 04:47:06 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46934 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1728917AbgKIJrF (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 9 Nov 2020 04:47:05 -0500
Received: from mail-yb1-xb42.google.com (mail-yb1-xb42.google.com [IPv6:2607:f8b0:4864:20::b42])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 68276C0613CF;
        Mon,  9 Nov 2020 01:47:04 -0800 (PST)
Received: by mail-yb1-xb42.google.com with SMTP id 2so3549247ybc.12;
        Mon, 09 Nov 2020 01:47:04 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20161025;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=b+fXAPRsR/uex6VU5/EqCVLiWplbh7G5vxH2O/MlyR4=;
        b=pJhTvuH4nCUkAyElx/qD1AaanZ2cSIDtOfvdTAtsy5Ez/Lq7CqmANmvpLaG4Jv4C34
         jIEgyAzYdk6Do0yo+ry7bKyAIHSny1U3jwftJXUmXb+FAvTufJ8EKK7LnA0Jsb8wo01f
         csx9lYsaAEXeQhC3lFcAS1dUM0GrO0gH4ms7rHViqdvqpTp66RlaRtR2iZkrQUar1u16
         WIip1bxKzZiy+BjmPDHd5RI4bLLGPnZH0g+vyEWzoCDlGsWaZnCgFDaQQvJEzbzYjoOC
         syVJAJSWz0EMYHU6CnermmxeUw9tvwo+/wJ3RmlF0x9QfivT3R+3KM6BKC41MUENR42o
         mS8A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=b+fXAPRsR/uex6VU5/EqCVLiWplbh7G5vxH2O/MlyR4=;
        b=TG7mDiNFzStOgmC7cqhfMOpDb4bZU4r76uGZyYw9vuZTpKecNUgghNY5ZcpSDYbBqp
         j17XU5vhvhoCIRpof3IDLK8GrF7gRuYNAexWsix/UZ6Jq4q+3WVa+9TEjA/ovpAlOrbj
         56pPsf1R1kIJ/Vse/HuSD8paCL8qynmXjrpqLsWnkGqojtJeHe4gkTizbF/F30bjfC7l
         ApQfrJCbIGEr9Qt2/zDL/pefRJCnulKjf0EmJUd0+2oWMcuSZK02GAz5j2DbMqkkNPfk
         XSwroVnj2l7aoo6zdIo6M3J7IC6kQ++Uw5vBX8QMuqPE+97Zx7evH/32CgH0LCTXYWqt
         quBQ==
X-Gm-Message-State: AOAM533L5KdCl7KgQO9dGYITprRsiTn/JTPoCJ1SKDbWqjHMQmoVXOhx
        NuM+SEdnO5P9GhAk0+dlWN7NxQiU1gFXuskVOkA=
X-Received: by 2002:a25:bcc7:: with SMTP id l7mr8063390ybm.115.1604915223794;
 Mon, 09 Nov 2020 01:47:03 -0800 (PST)
MIME-Version: 1.0
References: <20201106192415.GA2696904@mwanda>
In-Reply-To: <20201106192415.GA2696904@mwanda>
From:   Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Date:   Mon, 9 Nov 2020 10:46:53 +0100
Message-ID: <CANiq72m+_4K8RzR4JtdAq4o4uc_vBPmLZmgLiGB1jwd_FnjrZA@mail.gmail.com>
Subject: Re: [PATCH] auxdisplay: fix use after free in lcd2s_i2c_remove()
To:     Dan Carpenter <dan.carpenter@oracle.com>
Cc:     Lars Poeschel <poeschel@lemonage.de>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        kernel-janitors@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Nov 6, 2020 at 8:26 PM Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> The kfree() needs to be moved down a line to prevent a use after free.

Thanks Dan for catching this one up while in -next. I'll pick it up.

Cheers,
Miguel