Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] MIPS: reserve the memblock right after the kernel
From:   Alexander Sverdlin <alexander.sverdlin@nokia.com>
To:     Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc:     Jiaxun Yang <jiaxun.yang@flygoat.com>, linux-mips@vger.kernel.org,
        Paul Burton <paulburton@kernel.org>,
        linux-kernel@vger.kernel.org, stable@vger.kernel.org
References: <20201106141001.57637-1-alexander.sverdlin@nokia.com>
 <20201107094028.GA4918@alpha.franken.de>
 <1d6a424e-944e-7f21-1f30-989fb61018a8@nokia.com>
Message-ID: <27310707-78d5-0f96-7048-749db4959a07@nokia.com>
Date:   Mon, 9 Nov 2020 12:08:03 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
In-Reply-To: <1d6a424e-944e-7f21-1f30-989fb61018a8@nokia.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from ulegcpsvhp1.emea.nsn-net.net (131.228.32.167) by AM9P191CA0026.EURP191.PROD.OUTLOOK.COM (2603:10a6:20b:21c::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.21 via Frontend Transport; Mon, 9 Nov 2020 11:08:05 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: e92e3848-edb2-4217-b076-08d8849fbb9c
X-MS-TrafficTypeDiagnostic: AM8PR07MB7393:
X-Microsoft-Antispam-PRVS: <AM8PR07MB7393F831A1083DA6738DE26088EA0@AM8PR07MB7393.eurprd07.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 0B19l6SF4fH8QY/6OuYDpvOpo0kkiPfQLiiYMIEe1aY9kUvRYiY7SOS7UYlNXSxLjtiLSMb7fGvlz5LyHEnpSqm1DMvlfcm13toEap4VbuFcrVjQrtkFJgxFnE5afMpzPqcq9JrHoZwchspe1vLdLmm4clCmhTPiKyp5UnWpqTXqVimetcVXXhEARz6d85OeBv7McvnLnlHbHBF+adFpVODJ8DtAbYtTxRA9DYGMJSRV9oeOzwDmhG0n0zzeZ0NISkcUfBJYNCwOtB+nShQM6Z+ekXWOKd7E9VYxxuIJTMumzlbCsYFOmpKaVjDR7DEkHCSrH+Vw1iQZ2Y2+MQPbNpmvg3LBVHK+Y/1mAqZTUxgUSEkjI/ioRp04ZbIKg6O/
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR07MB4531.eurprd07.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(396003)(376002)(366004)(346002)(136003)(5660300002)(83380400001)(6486002)(31696002)(66476007)(8676002)(54906003)(478600001)(53546011)(6506007)(26005)(44832011)(956004)(2616005)(52116002)(316002)(31686004)(86362001)(16526019)(186003)(8936002)(6512007)(4326008)(2906002)(6916009)(66556008)(66946007)(36756003)(43740500002);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData: XlGUxJ/wrzmtGFN8/tXIIUFvHAuPjUotGpmIzv85UXO/DyXI1SAiqveFcbo0KGZYMfPccuQT0B+QOpJdlyMGXZwdsnAR0hws3BqI3lcHiE/sNLHICgXPJ/ulbC0QEFfvhnFQOTNddktfzQitDpZG9mvGqLfY/jPvNNN+2Vf/42yWu1yPVBmLgLR6HWDg3E9BazcuACuOfVyMHphhFsYq7BlMkB6hm+aaT+Tvy/h61yZLK2yxHZvwzeJx+PgSojLs/V999YxS72j16T//XZP+Jj19BSvkKUtFXjB87LTfBDK9urYUsZA+DQ6NTCR3AQVFh/ERYzq14gJHsSVmyY56W031pJ4i+Sqv6XcpP2/Hu1woeMxklRSfZYV9ybyjjjAV8cdXPC6qXoSH3TYubfvlquxUK1fW0aQnI3BPHaQaO/syX3MGIQmDt87J51/WvEiMISFVZ+Bb8B/kh6OCmrSfhq2x3Il34sIajFyTJ4ephagaRoCT6ZLU1QViiGiQj+46Z0S3dLdzaEHkP3EkdlrXRQZDn/8LrEnXSx2Td8jnAG4zbgM3Q6QdjRO+ejnE+Iv5Iay3fY7EHIFpEg56bCdZBNX1nQuNy0jFKeDFf+4YvkLAfDfgqK05qLUfuctB2kyIQfB/gRjDRh9e/nlvH+ayEEnVP4P+D4gnq1o1PqxCFArbDIfhcPKnRvgjipb3+jLIbYCwaRsjr7PmXwVMHbWSU7bdNW+B5Sjv77z7PNC1yhQyT7vAwtrxu3fVmBRjNf+VUQ5T7CRfC2Nzv8dPrN2B+SsttXwZVSi8qHYEdCNfSGXj97ERUIGMlEoEJutxQRELMV6zHGzMVvNzLtQstObOd4g98PepEyvWuSYJF6abPmZUrGjD7frdLGgyM6EQsmyCtiReorl8rPUSSjkPfF9CQQ==
X-OriginatorOrg: nokia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e92e3848-edb2-4217-b076-08d8849fbb9c
X-MS-Exchange-CrossTenant-AuthSource: AM0PR07MB4531.eurprd07.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2020 11:08:05.6617
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5d471751-9675-428d-917b-70f44f9630b0
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: y/ubUEsn15/0kc2pqBE3DUGkfJ2DphkEJWQPSHFFx0LSDLChrLgkgUD04vtJLwYvPXX9crkJuLrQ8qRgs13baDOK5AdUo9TPl4rF6w/BZ1w=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR07MB7393
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Thomas,

On 09/11/2020 11:34, Alexander Sverdlin wrote:
>>> Linux doesn't own the memory immediately after the kernel image. On Octeon
>>> bootloader places a shared structure right close after the kernel _end,
>>> refer to "struct cvmx_bootinfo *octeon_bootinfo" in cavium-octeon/setup.c.
>>>
>>> If check_kernel_sections_mem() rounds the PFNs up, first memblock_alloc()
>>> inside early_init_dt_alloc_memory_arch() <= device_tree_init() returns
>>> memory block overlapping with the above octeon_bootinfo structure, which
>>> is being overwritten afterwards.
>> as this special for Octeon how about added the memblock_reserve
>> in octen specific code ?
> while the shared structure which is being corrupted is indeed Octeon-specific,
> the wrong assumption that the memory right after the kernel can be allocated by memblock
> allocator and re-used somewhere in Linux is in MIPS-generic check_kernel_sections_mem().
> 
> I personally will be fine with repairing Octeon only as I don't have other MIPS
> targets to care about, but maybe someone else in the MIPS community will find
> this fix useful...

another reason for not putting that to Octeon platform code was the fact, that one
would need to put the knowledge about wrong assumption of ARCH (MIPS) code into
different code area of Octeon platform.
If at some point in time check_kernel_sections_mem() will be altered/fixed, nobody
will understand why Octeon still has this workaround.

-- 
Best regards,
Alexander Sverdlin.