Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp3136535pxb; Mon, 9 Nov 2020 03:41:43 -0800 (PST) X-Google-Smtp-Source: ABdhPJzL2DocacI4SBZmkHSIurXSKQgjxkLXa954dy8UW4SA838L16TnHDnC5OzsdD59xDmrll7u X-Received: by 2002:a17:906:af47:: with SMTP id ly7mr15332250ejb.532.1604922103520; Mon, 09 Nov 2020 03:41:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604922103; cv=none; d=google.com; s=arc-20160816; b=vTziYTRyQRQLdAtD6p6tFXJ7DiAG83cUKqDmOlhAdhen3CN4TKalxmrtUMtp97HH5A Ccae1YkHw1ICQytebxLtxEL6utpoyemGf0nQISfVTDwBywi6pAyE52zTyuNXBtTBvXUj Z/ocYYCEgepoQTOSFBmWRBQTp0alUnXbbi8zY3kuvsU/xhtcNS/T2Eae9jC6fpZyeK55 pSoHBd7ohGXe7YEofQwsAg3ljLaOZqOXSGxzwaftbzwhOzjHA4UuxT60vDslHD+bOaW9 WvpyAmwXInwomciU4wbuKOTH2sOpJFSgXz0L3T29IRim9+wXotG5JS3vXR0raojtQ+hv wiCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :ironport-sdr:ironport-sdr; bh=mDxRTm67aO3gwomR192iklowuMun6zu791jO88362qM=; b=etjEiqfWq9SUxHAl5edzUeWbNa7+S97CKbWwTvTJ4LZWAr6p/xOzwrc5hks+QGTPwe pjlqCUZD1v+2/anuP8gT1qHC2ZZpTCr5UXgpBYJKbKSaI3ynduxkWx7kU79sU6y/uQzE 0DnJVjb5AUCaQh03GqENlxWnNX3NMRs5a/KrZwgctgWOl/qiVQ3/wLGsQxpeWA3/wKm9 DRq8fjJdFvNxcY7R/leE/6DKqusxFvktYelV5GZUHUxn9WH9EVEN9YqMqM0Lkuaqcsf5 tbe6MNtHVe2ls7+t19ZH4FDNizKYY/MpTMcJp6L0Q8KiDwQbSew6rhHOORqbo4iutPf2 x2Qw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id jr7si7200128ejb.592.2020.11.09.03.41.20; Mon, 09 Nov 2020 03:41:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729507AbgKILkD (ORCPT + 99 others); Mon, 9 Nov 2020 06:40:03 -0500 Received: from mga11.intel.com ([192.55.52.93]:49415 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727311AbgKILkD (ORCPT ); Mon, 9 Nov 2020 06:40:03 -0500 IronPort-SDR: bgRX9y6qfVEE8mDoGITql9520iUh5mJT8XgtB2f8XrhDt15rAY17x/RF7DtVHNRx3Tkp3EVuFU XjzxKuFf486Q== X-IronPort-AV: E=McAfee;i="6000,8403,9799"; a="166276480" X-IronPort-AV: E=Sophos;i="5.77,463,1596524400"; d="scan'208";a="166276480" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Nov 2020 03:40:02 -0800 IronPort-SDR: f0GZK/P7FVmWfHN7XXZxrKoFtbFbzhPXi0NlWKcPSAqDiCWUwQ9WIIIFZQW32V3gHvEULu0hwL JoR0CIj6g/TA== X-IronPort-AV: E=Sophos;i="5.77,463,1596524400"; d="scan'208";a="327242336" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Nov 2020 03:40:00 -0800 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1kc5Xi-005AOR-9j; Mon, 09 Nov 2020 13:41:02 +0200 Date: Mon, 9 Nov 2020 13:41:02 +0200 From: Andy Shevchenko To: Wan Ahmad Zainie Cc: kishon@ti.com, vkoul@kernel.org, robh+dt@kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, mgross@linux.intel.com, lakshmi.bai.raja.subramanian@intel.com Subject: Re: [PATCH v2 2/2] phy: intel: Add Keem Bay USB PHY support Message-ID: <20201109114102.GY4077@smile.fi.intel.com> References: <20201109031654.22443-1-wan.ahmad.zainie.wan.mohamad@intel.com> <20201109031654.22443-3-wan.ahmad.zainie.wan.mohamad@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201109031654.22443-3-wan.ahmad.zainie.wan.mohamad@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 09, 2020 at 11:16:54AM +0800, Wan Ahmad Zainie wrote: > Add support for USB PHY on Intel Keem Bay SoC. ... > +config PHY_INTEL_KEEMBAY_USB > + tristate "Intel Keem Bay USB PHY driver" > + depends on ARCH_KEEMBAY || (ARM64 && COMPILE_TEST) > + depends on OF && HAS_IOMEM Do you really need dependency to OF (yes, I see that it will be not functional, but still can be compile tested)? > + select GENERIC_PHY > + select REGMAP_MMIO > + help > + Choose this option if you have an Intel Keem Bay SoC. > + > + To compile this driver as a module, choose M here: the module > + will be called phy-keembay-usb.ko. ... > +#include > +#include > +#include > +#include > +#include > +#include No evidence of anything being used in this code. mod_devicetable.h is missed, though. > +#include > +#include > +#include ... > + usleep_range(30, 50); Why 30-50? ... > + usleep_range(20, 50); Why these numbers? ... > + usleep_range(2, 10); Ditto. ... > + usleep_range(20, 50); Ditto. ... > + struct device_node *np = dev->of_node; It's being used only once and it doesn't bring any benefit. -- With Best Regards, Andy Shevchenko