Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932445AbWHTCUI (ORCPT ); Sat, 19 Aug 2006 22:20:08 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932491AbWHTCUI (ORCPT ); Sat, 19 Aug 2006 22:20:08 -0400 Received: from mx1.redhat.com ([66.187.233.31]:20656 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S932445AbWHTCUG (ORCPT ); Sat, 19 Aug 2006 22:20:06 -0400 Date: Sat, 19 Aug 2006 22:19:35 -0400 From: Dave Jones To: Andrew Morton , greg@kroah.com Cc: Linux Kernel Subject: [CPUFREQ] acpi-cpufreq: Ignore failure from acpi_cpufreq_early_init_acpi Message-ID: <20060820021935.GA21026@redhat.com> Mail-Followup-To: Dave Jones , Andrew Morton , greg@kroah.com, Linux Kernel Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4.2.2i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1620 Lines: 44 Ignore the return value of early_init_acpi(), as it can give false error messages. If there is something really wrong, then register_driver will fail cleanly with EINVAL later. [ background: modprobe acpi-cpufreq on systems not capable of speed-scaling started failing with 'invalid argument', where previously it would only ever -ENODEV I'm not 100% happy with the solution. It'd be better to handle failure properly, but this is a low-impact change for 2.6.18 We can always revisit doing this better in .19 --davej.] Signed-off-by: Venkatesh Pallipadi Signed-off-by: Dave Jones Index: linux-2.6.18-rc4/arch/i386/kernel/cpu/cpufreq/acpi-cpufreq.c =================================================================== --- linux-2.6.18-rc4.orig/arch/i386/kernel/cpu/cpufreq/acpi-cpufreq.c +++ linux-2.6.18-rc4/arch/i386/kernel/cpu/cpufreq/acpi-cpufreq.c @@ -567,16 +567,11 @@ static struct cpufreq_driver acpi_cpufre static int __init acpi_cpufreq_init (void) { - int result = 0; - dprintk("acpi_cpufreq_init\n"); - result = acpi_cpufreq_early_init_acpi(); + acpi_cpufreq_early_init_acpi(); - if (!result) - result = cpufreq_register_driver(&acpi_cpufreq_driver); - - return (result); + return cpufreq_register_driver(&acpi_cpufreq_driver); } -- http://www.codemonkey.org.uk - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/