Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp3204326pxb; Mon, 9 Nov 2020 05:32:40 -0800 (PST) X-Google-Smtp-Source: ABdhPJyvq+i/KLYG88jlNHru0JYhwxvjl3Pl3fAAP9uTMMsSjNvEf+g5N9twKPfdr54IWlCC4KMK X-Received: by 2002:a05:6402:144f:: with SMTP id d15mr15032684edx.300.1604928760709; Mon, 09 Nov 2020 05:32:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604928760; cv=none; d=google.com; s=arc-20160816; b=qGE4+JtWPPE3yOJz460LoMMKyJ3nDUe1KfQdR3I+7VWouJ9WHPIJ3eyH4YjJmSKB7m bdhhkP1uu7JTGmlhnaCBlTIcarZsK9/TPTBYMriR4oiOa5vyynb6oO7yZEOPcd/8i70j O9+/jrqgHbWcUyUJSKPV2kZNu4Cbx3XvPQT6zE0h8pYeqllPAh5CvFM/KO6s14JZGSy2 yTqek4F8aIFNuXVhaPu1qwuSa5HlM4T5Y68QB6tIXPuijCu0W1sTPdzLRkm/089KRKWJ pTO8VzrSlzUzzDSBTqE5/sK2nnDyz3f6iLzO4jjZGIiyoys0S1ZCuyHtfMbwIpbrvUFR cIyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=+sz4tbYNuwYjyVl/Ub4iOvWLg0YjxVlle9/HbtnKn3I=; b=MvEq4Ip6SMjzdnWBfB5dLsHaiOq1a6QmrrMqriJDPTex4Rn6YPftYNkrQZjkeGPgi5 UO/GQuLehGEpj2wzpkpqZRwYrMNeAfiunMJDL3+jNzvZo1YsgFfe7hI2WnVDrAPxrB1t AXY2OA8eBL4nMfJ99LS3hsyMpoK9rcL5KZ6/sZEoP0OfS03GTYmZAQ0ttQzzZ5DcZre0 N57iBt/GLW/BRu4GQuvwXCw5kpwjX96Z8tcFrVpL3i8ALIW3ItL/eveEguEt6hymblHv BNC/hvzaRq3J5+lEhw4JIYGKn/E3ET5v1eyKS2AQVitxSSOZBK0COpl2bId1BaM80eAG Cttw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ufKvexxE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h10si7497464eje.596.2020.11.09.05.32.17; Mon, 09 Nov 2020 05:32:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ufKvexxE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732079AbgKINbD (ORCPT + 99 others); Mon, 9 Nov 2020 08:31:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54000 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731958AbgKINbA (ORCPT ); Mon, 9 Nov 2020 08:31:00 -0500 Received: from mail-pf1-x443.google.com (mail-pf1-x443.google.com [IPv6:2607:f8b0:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C842EC0613CF for ; Mon, 9 Nov 2020 05:30:59 -0800 (PST) Received: by mail-pf1-x443.google.com with SMTP id g7so8187459pfc.2 for ; Mon, 09 Nov 2020 05:30:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=+sz4tbYNuwYjyVl/Ub4iOvWLg0YjxVlle9/HbtnKn3I=; b=ufKvexxEIva0lg+0/eug7BwTwcoisncojILiOcOxK8iGgqzqRFN2dRTHx4+A7F2XLT umwQNfUgA8siwS6Sh/fdr5nmQOZygHKzXeMkrT7BP3VSxz5Y/2PeypLDd88VkPbF8DDn 131MQYExWaE4kTGsRPDPPflC5mlEcUX/rWqWEskHV4Z5bdTGijJLJ9esUz/ab13E7AfQ IlesHAtiqt1lykkgqd8hi+QWagdataYSti1zKtjT2+pUFLzdQWS2rnf4+Zf5eKQRUjQw 5oi6tSAkC+btdR+AueU52vFL9kDY77kl8u34Pg6BSziBrUOKnfSqUX6BAmgYGKVMZmgE qRBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=+sz4tbYNuwYjyVl/Ub4iOvWLg0YjxVlle9/HbtnKn3I=; b=gxOj8hyLwXU6K9FYhQ9i7ogg/GqelgAvQnYgk/mAHzUwUzZwK+HFO8TQbS4bBpFFvw 8xlFKV2QEB6fZtvD/8u5jOQeQn033hu6YVFMBZ2cwo/Xq0jQOboVisOyTQA/n3Jr7Nhb N2g9H6wZ7wntfLKxCH/7a1zm9yFH9jlVobCDH1vAhoAnjU6xzKAwEUAeJL3uydHfZWSZ MY4KtkfUVmbzSrJLF9GHy306fCn+MqgfdflOzrVPXnuFqC3tOBJTQKE4wBFbst6C6rTq TPoAFJ19c6cUjsKtdmA8KJxDBrL0gaLdWuVR94Nb+cGbNGt2YgX3+JBHz2uY5eGfzjhJ RxCA== X-Gm-Message-State: AOAM532jJ3dGgi6TKU2/mlCVYkbqxi+zLgAD6yoZSYcULI3rV+9U9Jrh zZ6fTaj1BjzAjdOGF0C0GJ4n X-Received: by 2002:a17:90b:3687:: with SMTP id mj7mr13252559pjb.143.1604928659159; Mon, 09 Nov 2020 05:30:59 -0800 (PST) Received: from work ([103.59.133.81]) by smtp.gmail.com with ESMTPSA id p4sm7881148pjo.6.2020.11.09.05.30.56 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 09 Nov 2020 05:30:58 -0800 (PST) Date: Mon, 9 Nov 2020 19:00:53 +0530 From: Manivannan Sadhasivam To: Bhaumik Bhatt Cc: linux-arm-msm@vger.kernel.org, hemantk@codeaurora.org, jhugo@codeaurora.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/6] Minor bug fixes and clean-up for MHI host driver Message-ID: <20201109133053.GK24289@work> References: <1604684690-31065-1-git-send-email-bbhatt@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1604684690-31065-1-git-send-email-bbhatt@codeaurora.org> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 06, 2020 at 09:44:44AM -0800, Bhaumik Bhatt wrote: > This patch series serves to clean up the MHI host driver by removing an > unnecessary counter and an unused function. It also renames a function to make > it clearly worded. There is currently no user of this exported function which > makes it is safe to do so now. > > Bug fixes include adding a missing EXPORT_SYMBOL_GPL to a function, and adding > a return value check to bail out of RDDM download in kernel panic path. > > An outlier among the group exports the mhi_get_exec_env() API for use by > controller drivers, in case they need to determine behavior on the basis of the > current execution environment. > > This set of patches was tested on arm64. Series applied to mhi-next! Thanks, Mani > > v2: > -Removed the declaration for mhi_get_exec_env() from internal.h > -Improved on the error log message in RDDM download exit case due to unknown EE > > Bhaumik Bhatt (6): > bus: mhi: core: Remove unnecessary counter from mhi_firmware_copy() > bus: mhi: core: Add missing EXPORT_SYMBOL for mhi_get_mhi_state() > bus: mhi: core: Expose mhi_get_exec_env() API for controllers > bus: mhi: core: Remove unused mhi_fw_load_worker() declaration > bus: mhi: core: Rename RDDM download function to use proper words > bus: mhi: core: Skip RDDM download for unknown execution environment > > drivers/bus/mhi/core/boot.c | 15 +++++++++------ > drivers/bus/mhi/core/internal.h | 2 -- > drivers/bus/mhi/core/main.c | 2 ++ > include/linux/mhi.h | 12 +++++++++--- > 4 files changed, 20 insertions(+), 11 deletions(-) > > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project >