Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp3224682pxb; Mon, 9 Nov 2020 06:02:44 -0800 (PST) X-Google-Smtp-Source: ABdhPJwyDsFNfXbuUszvjS9VUuUJFn06WvG6D5BO+5bq9C+q5DQm0bzobE9QqX/N801cHk4fIogl X-Received: by 2002:a19:434a:: with SMTP id m10mr3253296lfj.153.1604930564414; Mon, 09 Nov 2020 06:02:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604930564; cv=none; d=google.com; s=arc-20160816; b=x15iX+zLJa4Vs+fvEXVZzHHgLgCI+exvorNhYPEKob8ogSxYPCPu4lu8kZdzpII2tt SEuFC72OJ7RPYviZyDW4FCZ9ItraPnBpFRLHWDjEMjxojVaHI5nHbwaf35dTeYt8AYvO kkdjd/sJLPY3mQhDMQyBubEpnTGPlaxmp11prKR86q5Z2UuRsLZL+7xJR/EmVfZHrEr+ /Uw+9E6Wbkx8g+WGODL9noNqg0KQG3l6dYyyM6rPg9NkkCFEUd0dXqB4xhWcCQBBj1P9 GJvGBXVHDheCWzrqI5/v1BLK+kA7JAn6tlf7UvDluwNSm2V29oFBAtCaXAKYht3qVUwE mf+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=gSYjZ1cUgOekEM7SwW9yeu6llfvLPIn9JJb6KN19b+0=; b=SsH1/euVhDbDy0y6I30SmG140oNGIUBZJUgd7T2NhDfuDaYyjGiQ9PWdxX2TeeGIaI PC96cpEvHzye1sgmns77J09x5pHx6DBC6SZGzwShhcN9bhsTePtfFQ9pxlfTQstE1B3c pM+Aj5OgHNmGKJrcLI/O0U9VXE0UM4llad1wjNj3ICf8W56ivBbdhF2UqWZ51IVNQ3hE gWZ2Myi9dy5HTj8vjBhR1VwOIHclP3l4uhAQ4kykks4IlqHmU1pW+rc6kQGJZif+5Ltp 3s5/+eLX+oAXNQebZi6y/q1/BrBI2XHMMix+d7l766Aa7KAQdXCzl8FM9+IwZsWRdmBr xbFA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=uheTqZt3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i197si1014618lfi.429.2020.11.09.06.02.15; Mon, 09 Nov 2020 06:02:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=uheTqZt3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731276AbgKIN7l (ORCPT + 99 others); Mon, 9 Nov 2020 08:59:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58426 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729854AbgKIN7k (ORCPT ); Mon, 9 Nov 2020 08:59:40 -0500 Received: from mail-pf1-x443.google.com (mail-pf1-x443.google.com [IPv6:2607:f8b0:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 797FEC0613CF; Mon, 9 Nov 2020 05:59:38 -0800 (PST) Received: by mail-pf1-x443.google.com with SMTP id e7so8228542pfn.12; Mon, 09 Nov 2020 05:59:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gSYjZ1cUgOekEM7SwW9yeu6llfvLPIn9JJb6KN19b+0=; b=uheTqZt3G2+6GJj/cnThwf9U010w83aj61EMBOva7nathZ8x/txGFq9RJd7zy5O7q7 Z+qZveWsaJMx7KsOK8BCgsRr9Myqdh+/u3J9225VqAXndLlOSf3W0jhO3XBASTAN7gdW RyRm6KF5rY6emONkNlZRtKwm5EWhnhpLPg3NBtFbJ09MQusOUAd3uPRgMDrF4fGiVqIV Em0N3pqiUpDkxQgKxMqrH9W4PezYE3c5d5LixTPQh4NGjXRyKXPEJXyCuusXMbO4YZAw mmTQoO4ihtK6Ysm8eStgwwssoRRNxXaopu3jCWJpvhyzV1vXCFNvPEwj6qfM0XXHQePs ucKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gSYjZ1cUgOekEM7SwW9yeu6llfvLPIn9JJb6KN19b+0=; b=bCsQuA2DYlYSj7Sc5SZD2eDZfFHnyCFnLY+IqKun9DF8DXC+Y7O4jEQNBKQObsvLh5 NVX2moim0TTguzUec7wAmmy/IFmZqPYkbKkLPCv4qTIK/kMFFZs4QypUkAFE11jKpyJD ST50t9xx6Gzf9yJSkdb1GmLAs2sjahc1ko+p1W836gq2mzQ8pxPa4eYJWbIk40hNN/WN er7kVX8Z7wrAsLPmwZOOYSzSCFlU5pYOrpqql2r1m15Uz0ciZ6ldlVmtjLXCN1k0yJP4 hp75oyneEVhsWDDnDzfnsynuOLMEKs4b0EWbYUaxc6iQSASuMNl73pN3mH4xw/Xw5wUC kseg== X-Gm-Message-State: AOAM531Tl5HVFOsD5ydaMXSCNI5JjScvT3OvJ44QrDWCJoY3BdvZDaD9 fryguhVl/qACkUpjVKwLtZy65i7SKCvn8Q== X-Received: by 2002:a17:90b:1642:: with SMTP id il2mr12300961pjb.81.1604930378160; Mon, 09 Nov 2020 05:59:38 -0800 (PST) Received: from localhost ([209.9.72.213]) by smtp.gmail.com with ESMTPSA id j12sm10422175pga.78.2020.11.09.05.59.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 05:59:37 -0800 (PST) From: Geliang Tang To: Mat Martineau , Matthieu Baerts , "David S. Miller" , Jakub Kicinski , Paolo Abeni Cc: Geliang Tang , netdev@vger.kernel.org, mptcp@lists.01.org, linux-kernel@vger.kernel.org, Dan Carpenter Subject: [MPTCP][PATCH net 2/2] mptcp: cleanup for mptcp_pm_alloc_anno_list Date: Mon, 9 Nov 2020 21:59:22 +0800 Message-Id: <0f17d2f60c188554d093e820c45caf20fe53aab0.1604930005.git.geliangtang@gmail.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch added NULL pointer check for mptcp_pm_alloc_anno_list, and avoided similar static checker warnings in mptcp_pm_add_timer. Signed-off-by: Geliang Tang Reviewed-by: Dan Carpenter --- net/mptcp/pm_netlink.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/net/mptcp/pm_netlink.c b/net/mptcp/pm_netlink.c index 03f2c28f11f5..dfc1bed4a55f 100644 --- a/net/mptcp/pm_netlink.c +++ b/net/mptcp/pm_netlink.c @@ -266,7 +266,9 @@ static bool mptcp_pm_alloc_anno_list(struct mptcp_sock *msk, { struct mptcp_pm_add_entry *add_entry = NULL; struct sock *sk = (struct sock *)msk; - struct net *net = sock_net(sk); + + if (!msk) + return false; if (lookup_anno_list_by_saddr(msk, &entry->addr)) return false; @@ -283,7 +285,7 @@ static bool mptcp_pm_alloc_anno_list(struct mptcp_sock *msk, timer_setup(&add_entry->add_timer, mptcp_pm_add_timer, 0); sk_reset_timer(sk, &add_entry->add_timer, - jiffies + mptcp_get_add_addr_timeout(net)); + jiffies + mptcp_get_add_addr_timeout(sock_net(sk))); return true; } -- 2.26.2