Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750826AbWHTPiR (ORCPT ); Sun, 20 Aug 2006 11:38:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750828AbWHTPiR (ORCPT ); Sun, 20 Aug 2006 11:38:17 -0400 Received: from outpipe-village-512-1.bc.nu ([81.2.110.250]:13268 "EHLO lxorguk.ukuu.org.uk") by vger.kernel.org with ESMTP id S1750826AbWHTPiQ (ORCPT ); Sun, 20 Aug 2006 11:38:16 -0400 Subject: Re: [PATCH 2.6.18-rc4] aoe [04/13]: zero copy write 1 of 2 From: Alan Cox To: "Ed L. Cashin" Cc: linux-kernel@vger.kernel.org, Greg K-H In-Reply-To: References: Content-Type: text/plain Content-Transfer-Encoding: 7bit Date: Sat, 19 Aug 2006 11:18:12 +0100 Message-Id: <1155982692.4051.9.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.6.2 (2.6.2-1.fc5.5) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 486 Lines: 14 Ar Gwe, 2006-08-18 am 13:39 -0400, ysgrifennodd Ed L. Cashin: > Signed-off-by: "Ed L. Cashin" > + skb->len = sizeof *h + sizeof *ah; > + memset(h, 0, skb->len); Never play with skb->len directly. Use skb_put/skb_trim - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/