DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:to:subject:mime-version:content-type:content-transfer-encoding:content-disposition;
        b=neEp2JJLjZh59k1YV/ah45n+DsfJDxqpCtZ63JeKks5oSFj3FYQhinvgi1pVOB5LGFBWrd5YLtDV5+Trcr4LddtADDygIX2IERGmiUANq1dlQ94437hHaXeC5+lIy1y6lXth+L26fd+Gq6hmEYZpQVKu/G+wchXo6Kn+/m4PLac=
Message-ID: <18d709710608200905j37ba1cb3vbb027fea88801c5c@mail.gmail.com>
Date: Sun, 20 Aug 2006 13:05:39 -0300
From: "Julio Auto" <mindvortex@gmail.com>
To: linux-kernel@vger.kernel.org
Subject: On the definition of the module_param_string macro
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1198
Lines: 30

In kernel 2.6.17.9, the definition of the module_param_string macro
receives 4 parameters (see linux/include/linux/moduleparam.h:87):

#define module_param_string(name, string, len, perm) ...

allowing the name of the parameter (fed to the macro as 'name'), as it
will be in the .modinfo section, to be different from the actual name
of the variable (fed to the macro as 'string').
To me, it looks inconsistent. If, on the other hand, it was supposed
to be a 'feature', the it looks plain useless (otherwise, the same
rule should apply to other module_param* macros).
So, I would suggest that the definition changes to:

#define module_param_string(name, len, perm) ...

where it would behave like a current use of 'module_param_string(name,
name, len, perm);'

I understand that such changes in the API of modules may cause some
trouble, but it doesn't cost a thing to look at this one as a possible
improvement for the future.

Cheers,

    Julio Auto
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/