Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Lukasz Stelmach <l.stelmach@samsung.com>
To:     Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc:     "Rafael J. Wysocki" <rafael@kernel.org>,
        Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Ard Biesheuvel <ard.biesheuvel@linaro.org>,
        linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
        platform-driver-x86@vger.kernel.org,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [PATCH v8 3/6] software node: implement reference properties
Date:   Mon, 09 Nov 2020 18:02:29 +0100
In-Reply-To: <20191108042225.45391-4-dmitry.torokhov@gmail.com> (Dmitry
        Torokhov's message of "Thu, 7 Nov 2019 20:22:22 -0800")
Message-ID: <dleftjeel2pioq.fsf%l.stelmach@samsung.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-="; micalg="pgp-sha256";
        protocol="application/pgp-signature"
CMS-TYPE: 201P
References: <20191108042225.45391-1-dmitry.torokhov@gmail.com>
        <20191108042225.45391-4-dmitry.torokhov@gmail.com>
        <CGME20201109170241eucas1p14c2156334d8c6ef15d52664fa4776f41@eucas1p1.samsung.com>
Precedence: bulk

--=-=-=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

It was <2019-11-07 czw 20:22>, when Dmitry Torokhov wrote:
> It is possible to store references to software nodes in the same fashion =
as
> other static properties, so that users do not need to define separate
> structures:
>
> static const struct software_node gpio_bank_b_node =3D {
> 	.name =3D "B",
> };
>
> static const struct property_entry simone_key_enter_props[] =3D {
> 	PROPERTY_ENTRY_U32("linux,code", KEY_ENTER),
> 	PROPERTY_ENTRY_STRING("label", "enter"),
> 	PROPERTY_ENTRY_REF("gpios", &gpio_bank_b_node, 123, GPIO_ACTIVE_LOW),
> 	{ }
> };
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---

I am writing a piece that needs to provide a list of gpios to a
diriver. The above example looks like what I need.

At the moment the driver gets the list from fwnode/of_node. The list
contain references to phandles which get resolved and and the driver
ends up with a bunch of gpio descriptors. Great.

This example looks nice but does the code that reads the reference from
the gpios property and returns a gpiod actually exist? If it doesn't, I
am willing to write it.

At first glance it makes more sense to me to pass (struct gpiod_lookup
*) instead of (struct software_node *) and make gpiolib's gpiod_find()
accept lookup tables as parameter instead of searching the
gpio_lookup_list? Or do you think such temporary table should be
assembled from the above structure and then used in gpiod_find()?

Any other suggestions on how to get a bunch of gpios (the description
for gpios is available in the devicetree) for a device described with a
software nodes?

Kind regards,
=2D-=20
=C5=81ukasz Stelmach
Samsung R&D Institute Poland
Samsung Electronics

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEXpuyqjq9kGEVr9UQsK4enJilgBAFAl+pdiUACgkQsK4enJil
gBAtoQf+PVFYMyk5VSXcEzxbOfAudd3xzQezGMekETrSzHkWkccYeM6J1qmYZiDd
YZUfignacyP1J3K8DYByXeyz8JpeTyd5wjrI0R4WLr5FFTw6uZuhKjlJqz22+o+l
YPla7v2m3nC0vh6j62c8d4ZVGNliYvbmHKA2Vp1gfiler+SCRQmKoFtkcoGiGDcD
r38D5qLDV8aqd9sCGKgLB2zZQlHzE9F59MKHcD2HBYmnzvyZVmiyTy2CVGd2v/44
i1qqg1V+u5QSrCm5HroAnRjGnzEk/tZyseYCghicg5QCY6+EW9RJ+2VRTMqiLtYC
WY4WU1iS6TccGts+T8OUHb8nMbb6mQ==
=bcdp
-----END PGP SIGNATURE-----
--=-=-=--