Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Dragan Cvetic <draganc@xilinx.com>
To:     Harshal Chaudhari <harshalchau04@gmail.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
CC:     Derek Kiernan <dkiernan@xilinx.com>,
        "arnd@arndb.de" <arnd@arndb.de>, Michal Simek <michals@xilinx.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] misc: xilinx_sdfec: add compat_ptr_ioctl()
Thread-Topic: [PATCH] misc: xilinx_sdfec: add compat_ptr_ioctl()
Thread-Index: AQHWq7DXhLHdnUTr2kmvVFzvFhkfaKnAHuXg
Date:   Mon, 9 Nov 2020 17:10:24 +0000
Message-ID: <SN4PR0201MB3472051AEFD34AB114827ABBCBEA0@SN4PR0201MB3472.namprd02.prod.outlook.com>
References: <20201026155801.16053-1-harshalchau04@gmail.com>
In-Reply-To: <20201026155801.16053-1-harshalchau04@gmail.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 72acd98c-9e98-46da-a543-08d884d25957
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Nov 2020 17:10:24.9100
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Uo0O5t8O773+xZyMuui/4tB+14LYstsefXb0WOyfBR2hJdG0v35QJiVCegU8qVlhVsJHD78AFZJ00DyFCzYEHA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR02MB3949
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Harshal Chaudhari <harshalchau04@gmail.com>
> Sent: Monday 26 October 2020 15:58
> To: gregkh@linuxfoundation.org
> Cc: Derek Kiernan <dkiernan@xilinx.com>; Dragan Cvetic <draganc@xilinx.co=
m>; arnd@arndb.de; Michal Simek
> <michals@xilinx.com>; linux-arm-kernel@lists.infradead.org; linux-kernel@=
vger.kernel.org
> Subject: [PATCH] misc: xilinx_sdfec: add compat_ptr_ioctl()
>=20
> Driver has a trivial helper function to convert
> the pointer argument and then call the native ioctl handler.
> But now we have a generic implementation for that, so we can use it.
>=20
> Signed-off-by: Harshal Chaudhari <harshalchau04@gmail.com>
> ---
>  drivers/misc/xilinx_sdfec.c | 12 +-----------
>  1 file changed, 1 insertion(+), 11 deletions(-)
>=20
> diff --git a/drivers/misc/xilinx_sdfec.c b/drivers/misc/xilinx_sdfec.c
> index 92291292756a..6f252793dceb 100644
> --- a/drivers/misc/xilinx_sdfec.c
> +++ b/drivers/misc/xilinx_sdfec.c
> @@ -1016,14 +1016,6 @@ static long xsdfec_dev_ioctl(struct file *fptr, un=
signed int cmd,
>  	return rval;
>  }
>=20
> -#ifdef CONFIG_COMPAT
> -static long xsdfec_dev_compat_ioctl(struct file *file, unsigned int cmd,
> -				    unsigned long data)
> -{
> -	return xsdfec_dev_ioctl(file, cmd, (unsigned long)compat_ptr(data));
> -}
> -#endif
> -
>  static __poll_t xsdfec_poll(struct file *file, poll_table *wait)
>  {
>  	__poll_t mask =3D 0;
> @@ -1054,9 +1046,7 @@ static const struct file_operations xsdfec_fops =3D=
 {
>  	.release =3D xsdfec_dev_release,
>  	.unlocked_ioctl =3D xsdfec_dev_ioctl,
>  	.poll =3D xsdfec_poll,
> -#ifdef CONFIG_COMPAT
> -	.compat_ioctl =3D xsdfec_dev_compat_ioctl,
> -#endif
> +	.compat_ioctl =3D compat_ptr_ioctl,
>  };
>=20
>  static int xsdfec_parse_of(struct xsdfec_dev *xsdfec)
> --
> 2.17.1

Acked-by: Dragan Cvetic <dragan.cvetic@xilinx.com>