Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp3369626pxb; Mon, 9 Nov 2020 09:22:45 -0800 (PST) X-Google-Smtp-Source: ABdhPJyLqGFHvRk8ZrXcE3Ma9EkFbzXJWPNG7tPlmyXmvP/Hq/O15qy4vD2bK10P2oMDTnJiSj0c X-Received: by 2002:a17:906:bc46:: with SMTP id s6mr15730105ejv.456.1604942565500; Mon, 09 Nov 2020 09:22:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604942565; cv=none; d=google.com; s=arc-20160816; b=OAKtGl6oFHodrl1nEH4N/6nTbdgz2LuHvW+qiPUTb0u9cMbZ79Yhukj3Gs28LYegiA i0aSVZl/+8hfPkQW1w42EGSIuN5uEA345GiiJUkRFyS1aCNeevOF8puiAohMQ6JS3gVR Qeg+INTgUvpaJPSEsdTdys3w9X4GlJYP4br8oPLT7MpPTnXhb+wMmILu2LB7CpogiK5J 8MDuQvXuzLk1x1LFm4Cl4nr6Y8yFbVomikSmXzQqT4vQ7ND1HD+1SXJrEzqh6FzgrIrh IsipdCQCA5/RYHYB5Dcn/OJfxHI8c89HhoyptXFOMZajIP/s6B2GNArYQMuyB1OVJF2v FfZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:dkim-signature:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from; bh=IiykI/a7ajJ3/GWJO3+HlUOt0S96bxffP6ovv8CN5x0=; b=S1+5423k+Jjb4n3ZneKhpdCTbqhJofBS4xQWkWbl+E4Ei0n73U8T2Jd+S4FpsfaOYX C/gnwcS+vvCrI6ZQVpeK7GKuQPsLLA2fvCh/qQ6sAQXThWpb+DHI7qiYpIgOQX2X0mBX oAbVfOA+baOND/oxpSvGdgNfK/BTk5jBjanbmRdt+ypwuXo3B3I8O3TNMiw6Xjn4juy9 v7RdbtF9kw3i+/2qp4XCTvchaaTG8pC4UfbNRtvEGQ5NTTVgO155Sz9QH+WI6gvULPeJ k97kKmZjElhrni+i9Hdnxh9vDWX2o7CoU4/fhE0hR1phuz+ZRwPpXlm/yaLyNyianNRN yc+w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=JeP2av6k; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k9si7300024ejx.605.2020.11.09.09.22.22; Mon, 09 Nov 2020 09:22:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=JeP2av6k; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731346AbgKIRUU (ORCPT + 99 others); Mon, 9 Nov 2020 12:20:20 -0500 Received: from hqnvemgate25.nvidia.com ([216.228.121.64]:1351 "EHLO hqnvemgate25.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730768AbgKIRUS (ORCPT ); Mon, 9 Nov 2020 12:20:18 -0500 Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Mon, 09 Nov 2020 09:20:14 -0800 Received: from HQMAIL105.nvidia.com (172.20.187.12) by HQMAIL105.nvidia.com (172.20.187.12) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 9 Nov 2020 17:20:17 +0000 Received: from vidyas-desktop.nvidia.com (10.124.1.5) by mail.nvidia.com (172.20.187.12) with Microsoft SMTP Server id 15.0.1473.3 via Frontend Transport; Mon, 9 Nov 2020 17:20:13 +0000 From: Vidya Sagar To: , , , , , , , CC: , , , , , , Subject: [PATCH V4 5/6] PCI: tegra: Check return value of tegra_pcie_init_controller() Date: Mon, 9 Nov 2020 22:49:36 +0530 Message-ID: <20201109171937.28326-6-vidyas@nvidia.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201109171937.28326-1-vidyas@nvidia.com> References: <20201109171937.28326-1-vidyas@nvidia.com> X-NVConfidentiality: public MIME-Version: 1.0 Content-Type: text/plain DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1604942414; bh=IiykI/a7ajJ3/GWJO3+HlUOt0S96bxffP6ovv8CN5x0=; h=From:To:CC:Subject:Date:Message-ID:X-Mailer:In-Reply-To: References:X-NVConfidentiality:MIME-Version:Content-Type; b=JeP2av6kez/BTs+ATf60ypgdKksM/Dp2VCGvVAMprK3baAvOQG6BDOtbFMoDQRkym WVK7PxyPow763QEaO+3aaRLIKEOB1+uxPi+F3C952gUSphzcxV98Ela6Jy+fIsur6W NXwmdFen0mOYey7uux1eTIOzvlaCznPVNE89MXp+PDPlIU6wtMxRwx/9Rq5A/mHMRY MIgNMk7ZLOjYLKeEvThcYR2E9Ft0JPw8+nR+OHuc4kVLIpw8Y1X1yMOYR8zo7gcrDQ wuaz2jB7rSX2ZV+c3U7K0L6hL6L5rI0bYosUtokGsVp8c0fUnrkzU1sjNdctnsgnos 1deuv98CC5PuA== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The return value of tegra_pcie_init_controller() must be checked before PCIe link up check and registering debugfs entries subsequently as it doesn't make sense to do these when the controller initialization itself has failed. Signed-off-by: Vidya Sagar --- V4: * None V3: * New patch in this series drivers/pci/controller/dwc/pcie-tegra194.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c index 9be10c8953df..8c08998b9ce1 100644 --- a/drivers/pci/controller/dwc/pcie-tegra194.c +++ b/drivers/pci/controller/dwc/pcie-tegra194.c @@ -1579,7 +1579,11 @@ static int tegra_pcie_config_rp(struct tegra_pcie_dw *pcie) goto fail_pm_get_sync; } - tegra_pcie_init_controller(pcie); + ret = tegra_pcie_init_controller(pcie); + if (ret < 0) { + dev_err(dev, "Failed to initialize controller: %d\n", ret); + goto fail_pm_get_sync; + } pcie->link_state = tegra_pcie_dw_link_up(&pcie->pci); if (!pcie->link_state) { -- 2.17.1