Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201109112319.264511-1-alexandre.chartre@oracle.com> <20201109112319.264511-2-alexandre.chartre@oracle.com>
In-Reply-To: <20201109112319.264511-2-alexandre.chartre@oracle.com>
From:   Andy Lutomirski <luto@kernel.org>
Date:   Mon, 9 Nov 2020 09:25:14 -0800
Message-ID: <CALCETrWOK-ZjcUKarbTokRxLOd3RmjYjnDhc1mgUeXRVFdGgow@mail.gmail.com>
Subject: Re: [RFC][PATCH 01/24] x86/syscall: Add wrapper for invoking syscall function
To:     Alexandre Chartre <alexandre.chartre@oracle.com>
Cc:     X86 ML <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Alexander-

You appear to be infected by corporate malware that has inserted the
string "@aserv0122.oracle.com" to the end of all the email addresses
in your to: list.  "luto@kernel.org"@aserv0122.oracle.com, for
example, is not me.  Can you fix this?


On Mon, Nov 9, 2020 at 3:21 AM Alexandre Chartre
<alexandre.chartre@oracle.com> wrote:
>
> Add a wrapper function for invoking a syscall function.

This needs some explanation of why.

>
> Signed-off-by: Alexandre Chartre <alexandre.chartre@oracle.com>
> ---
>  arch/x86/entry/common.c | 16 +++++++++++++---
>  1 file changed, 13 insertions(+), 3 deletions(-)
>
> diff --git a/arch/x86/entry/common.c b/arch/x86/entry/common.c
> index 870efeec8bda..d222212908ad 100644
> --- a/arch/x86/entry/common.c
> +++ b/arch/x86/entry/common.c
> @@ -35,6 +35,15 @@
>  #include <asm/syscall.h>
>  #include <asm/irq_stack.h>
>
> +static __always_inline void run_syscall(sys_call_ptr_t sysfunc,
> +                                       struct pt_regs *regs)
> +{
> +       if (!sysfunc)
> +               return;

What's this for?

> +
> +       regs->ax = sysfunc(regs);
> +}
> +