Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] auxdisplay: hd44780_common: Fix build error
To:     poeschel@lemonage.de,
        Miguel Ojeda Sandonis <miguel.ojeda.sandonis@gmail.com>,
        open list <linux-kernel@vger.kernel.org>
References: <76f9cd1b-3ace-e8a8-aaee-8d64e0900603@infradead.org>
 <20201109093154.1080024-1-poeschel@lemonage.de>
From:   Randy Dunlap <rdunlap@infradead.org>
Message-ID: <9afaeba0-6e83-cdc2-07f8-3bac5553208b@infradead.org>
Date:   Mon, 9 Nov 2020 09:30:17 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <20201109093154.1080024-1-poeschel@lemonage.de>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/9/20 1:31 AM, poeschel@lemonage.de wrote:
> From: Lars Poeschel <poeschel@lemonage.de>
> 
> When building the hd44780_common driver without a driver that actually
> uses it like panel or hd44780 you got a build error, because
> hd44780_common uses charlcd, but did not select it. It's users did
> select it.
> This is fixed now. hd4478_common now selects charlcd in Kconfig and
> panel and hd44780 do not. They only select hd44780_common.
> 
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Lars Poeschel <poeschel@lemonage.de>

Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested

Thanks.

> ---
>  drivers/auxdisplay/Kconfig | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig
> index a69623124a26..a2b59b84bb88 100644
> --- a/drivers/auxdisplay/Kconfig
> +++ b/drivers/auxdisplay/Kconfig
> @@ -27,6 +27,7 @@ config CHARLCD
>  
>  config HD44780_COMMON
>  	tristate "Common functions for HD44780 (and compatibles) LCD displays" if COMPILE_TEST
> +	select CHARLCD
>  	help
>  	  This is a module with the common symbols for HD44780 (and compatibles)
>  	  displays. This is the code that multiple other modules use. It is not
> @@ -37,7 +38,6 @@ config HD44780_COMMON
>  config HD44780
>  	tristate "HD44780 Character LCD support"
>  	depends on GPIOLIB || COMPILE_TEST
> -	select CHARLCD
>  	select HD44780_COMMON
>  	help
>  	  Enable support for Character LCDs using a HD44780 controller.
> @@ -196,7 +196,6 @@ config ARM_CHARLCD
>  menuconfig PARPORT_PANEL
>  	tristate "Parallel port LCD/Keypad Panel support"
>  	depends on PARPORT
> -	select CHARLCD
>  	select HD44780_COMMON
>  	help
>  	  Say Y here if you have an HD44780 or KS-0074 LCD connected to your
> 


-- 
~Randy