Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp3383076pxb;
        Mon, 9 Nov 2020 09:42:02 -0800 (PST)
X-Google-Smtp-Source: ABdhPJzD/5doSoK0bVFmbJN632DZ4sk5j8N0qpYm53vXSIFxC3WZzkkn+OgXRAl9Fo9WfgPmvfP9
X-Received: by 2002:a17:906:86c7:: with SMTP id j7mr15865111ejy.301.1604943722606;
        Mon, 09 Nov 2020 09:42:02 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1604943722; cv=none;
        d=google.com; s=arc-20160816;
        b=jzpgaVq2bvNR6cUl1NjTcn8slVRqDC+pHld64WuJ3+fCGcHgn8nVV4jvZXVsQUcrnx
         Vb7e3WiY8iK7OGgicQ6qrbMgwt/KGFqEesWHccMmCYRJMcQ5yAeqjC3sbJbeoo1gHTmG
         f+gbo8/Jags/iSv5/0AAbUgljhd6WZRUnftHCCYSNDeXydiBkcsB6FfHTzq/W021Q0cH
         VKQC3mqtChCaOK5KozccOhOLxa0hl8iSpHI8QlGnlnzpuO+PfZrlAXGSpucNp8vfM21q
         BjakCWz/FzDxU6jyEEOwWoXWf62H3QEs6IBviymMugccOpEPkJaWtiq0lMypyh6jn5iU
         v3YQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to
         :references:mime-version:dkim-signature;
        bh=TTyyryUY+eVAAkMwbjWLEr4OsaNSLm0UnpBPUIOYlkY=;
        b=tJ6h3Bx3My0qvE9SrEOUKsmFpom/vUd7tJYXMJ2adBiXpA0OQ6xdgjYNREnEP/EMWi
         Tr1JtEBXCKPPcJkWFiH5lQF7/vO+W8a1/C10h8PUPjiUO6KkJ68YuMQ+TJMOkXikNDWq
         0pgVah+bWcrmkCl0pgj+xAly87aobTgvPr+7Xz/A7IaBQ5QsJNBm0SF8CYa5blrrIzy5
         KT2aaVu+JB9V8w0U3ISBz/5f5Lr51miB6L4ewR7XXnpgfY3E5/ykSPqJ2XACUAQ8Hk3P
         6DAHIKAhTZmY9quHycBox2QDsFv/0Viq6K/KDyHlT2YGaHu2YWMAgD4ge/SwZ6thTsBK
         30mg==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=default header.b=C2vyZAXt;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id bx25si7470837ejb.270.2020.11.09.09.41.37;
        Mon, 09 Nov 2020 09:42:02 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=default header.b=C2vyZAXt;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1731522AbgKIRjK (ORCPT <rfc822;patchstalker@gmail.com>
        + 99 others); Mon, 9 Nov 2020 12:39:10 -0500
Received: from mail.kernel.org ([198.145.29.99]:41252 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1730330AbgKIRjK (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 9 Nov 2020 12:39:10 -0500
Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50])
        (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id 4123F20578
        for <linux-kernel@vger.kernel.org>; Mon,  9 Nov 2020 17:39:09 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=default; t=1604943549;
        bh=hlWU5zGloECZNFrwjneLZv9TFr5kKDDNTOdv4sM4WJw=;
        h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
        b=C2vyZAXthtKbVejAYfokMEHzLWrY0mx5+BZ2K1LjjVWYpnSnEQixeBH0De+uzqubk
         urQlv1X32ne2iNWEZilSz11T1bBDZEfup7TNmrMMIAkpFJIZ2EroqLWkhYNOCU/J/d
         jqG/vymsRjO82JnnIowbYRYuW19EMdtY2PKgzYZA=
Received: by mail-wr1-f50.google.com with SMTP id 23so9634896wrc.8
        for <linux-kernel@vger.kernel.org>; Mon, 09 Nov 2020 09:39:09 -0800 (PST)
X-Gm-Message-State: AOAM531Q9zqCDcP1x6cPFr1sFLyN/N+YeOj7vMsKgJqrnrCJvAOy3MZJ
        T9XKU5D0p4BrAdmUcBdi4yH2NCfLpu7VAlszPTTBJQ==
X-Received: by 2002:adf:f0c2:: with SMTP id x2mr12660274wro.184.1604943547814;
 Mon, 09 Nov 2020 09:39:07 -0800 (PST)
MIME-Version: 1.0
References: <20201109112319.264511-1-alexandre.chartre@oracle.com> <20201109112319.264511-9-alexandre.chartre@oracle.com>
In-Reply-To: <20201109112319.264511-9-alexandre.chartre@oracle.com>
From:   Andy Lutomirski <luto@kernel.org>
Date:   Mon, 9 Nov 2020 09:38:56 -0800
X-Gmail-Original-Message-ID: <CALCETrXtqC9w5gAa=UcF=B4z7vKuUL2sutsCJOjaSCK4CX4q0Q@mail.gmail.com>
Message-ID: <CALCETrXtqC9w5gAa=UcF=B4z7vKuUL2sutsCJOjaSCK4CX4q0Q@mail.gmail.com>
Subject: Re: [RFC][PATCH 08/24] x86/entry: Add C version of SWAPGS and SWAPGS_UNSAFE_STACK
To:     Alexandre Chartre <alexandre.chartre@oracle.com>
Cc:     X86 ML <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Nov 9, 2020 at 3:22 AM Alexandre Chartre
<alexandre.chartre@oracle.com> wrote:
>
> SWAPGS and SWAPGS_UNSAFE_STACK are assembly macros. Add C versions
> of these macros (swapgs() and swapgs_unsafe_stack()).

This needs a very good justification.  It also needs some kind of
static verification that these helpers are only used by noinstr code,
and they need to be __always_inline.  And I cannot fathom how C code
could possibly use SWAPGS_UNSAFE_STACK in a meaningful way.