Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 9 Nov 2020 17:41:08 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Rob Herring <robh+dt@kernel.org>
Cc:     Saravana Kannan <saravanak@google.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Rafael J . Wysocki" <rafael@kernel.org>,
        Daniel Mentz <danielmentz@google.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Frank Rowand <frowand.list@gmail.com>
Subject: Re: [PATCH RFC] driver core: Ensure DT devices always have fwnode set
Message-ID: <20201109174108.GK6380@sirena.org.uk>
References: <20201106150747.31273-1-broonie@kernel.org>
 <CAGETcx-abGAgYrHM0jm6hVkrJ5KvfhK6gCZ4Y6RY0msPJDCuQg@mail.gmail.com>
 <CAL_JsqKfEWY8+suK3vrtbJbgWzDkCeDV_s61dh5Xwj13cHzCUQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="ibq+fG+Ci5ONsaof"
Content-Disposition: inline
In-Reply-To: <CAL_JsqKfEWY8+suK3vrtbJbgWzDkCeDV_s61dh5Xwj13cHzCUQ@mail.gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk


--ibq+fG+Ci5ONsaof
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Nov 09, 2020 at 11:25:39AM -0600, Rob Herring wrote:
> On Fri, Nov 6, 2020 at 1:09 PM Saravana Kannan <saravanak@google.com> wrote:

> > And all the subsystems that create their own device from an of_node
> > should use of_set_device_of_node() to set the device's of_node. That
> > way, all this is done in a consistent manner across subsystems and
> > avoid all of the of_get/put() and OF_POPULATED set/clear strewn all
> > over the subsystems.

> Perhaps a fwnode call in device_add instead that implements the above
> and anything else needed for each type of fwnode. It might even be
> possible with that to get rid of most of

I'd suggested doing it with a callout as well in the original thread
that sparked my proposal - my patch was just the most minimal
implementation to fix the current problem.

> of_platform_device_create_pdata() and of_device_add(). IIRC, those
> were pretty much copies of the core code.

> That would also be less fragile than having a coccinelle script.

--ibq+fG+Ci5ONsaof
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl+pfzMACgkQJNaLcl1U
h9BwuAf+Ifvb6jENdSABE4ZiMAMqCgybbePbrFprkqHG4M7jIiXqRSigNor+ptQS
3GFjy2IiR5+LgRW58IThVh97j3Ju4sCIGXZvlV1ixs2HfMDL58cuVkIOEL8Q9zqC
WF0gBQlyO1rhgxbj48fD1czx5I8q5jxcNdophbDNOHNB2vNcr8yXbZyPZLdsD8Dh
N2sfmi9Kls1yfhqzh7B9XU2nS/D4h5afIpfQNz9TEQSg2Ka3otnLdysQUQkim+6S
BxOLUbSxeB+r0IXGSJqjEZYnWREojywWymdHUpXk4w57b0G10bh2CFWmAKNbCEqV
IjUNKcURgrgns5KHUKXXA4NtVLOHmg==
=jsPy
-----END PGP SIGNATURE-----

--ibq+fG+Ci5ONsaof--