Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 9 Nov 2020 13:10:59 -0600
From:   Rob Herring <robh@kernel.org>
To:     Alice Guo <alice.guo@nxp.com>
Cc:     shawnguo@kernel.org, s.hauer@pengutronix.de, krzk@kernel.org,
        linux-imx@nxp.com, peng.fan@nxp.com, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/4] dt-bindings: soc: imx8m: add DT Binding doc for
 soc unique ID
Message-ID: <20201109191059.GA1599099@bogus>
References: <20201105072629.24175-1-alice.guo@nxp.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201105072629.24175-1-alice.guo@nxp.com>
Precedence: bulk

On Thu, Nov 05, 2020 at 03:26:26PM +0800, Alice Guo wrote:
> Add DT Binding doc for the Unique ID of i.MX 8M series.
> 
> Signed-off-by: Alice Guo <alice.guo@nxp.com>
> ---
>  .../devicetree/bindings/arm/fsl.yaml          | 33 +++++++++++++++++++
>  1 file changed, 33 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index e4db0f9ed664..0419f078502b 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -901,6 +901,39 @@ properties:
>                - fsl,s32v234-evb           # S32V234-EVB2 Customer Evaluation Board
>            - const: fsl,s32v234
> 
> +  soc:
> +    description:
> +      i.MX8M Family SoC must provide a soc node in the root of the device tree,
> +      representing the System-on-Chip since these test chips are rather complex.
> +    type: object
> +    properties:
> +      compatible:
> +        oneOf:
> +          - items:
> +              - const: fsl,imx8mm-soc
> +              - const: simple-bus
> +          - items:
> +              - const: fsl,imx8mn-soc
> +              - const: simple-bus
> +          - items:
> +              - const: fsl,imx8mp-soc
> +              - const: simple-bus
> +          - items:
> +              - const: fsl,imx8mq-soc
> +              - const: simple-bus

items:
  - enum:
      - fsl,imx8mm-soc
      - fsl,imx8mn-soc
      - fsl,imx8mp-soc
      - fsl,imx8mq-soc
  - const: simple-bus

> +
> +      nvmem-cells:
> +        maxItems: 1
> +        description: Phandle to the SOC Unique ID provided by a nvmem node
> +
> +      nvmem-cells-names:
> +        const: soc_unique_id
> +
> +    required:
> +      - compatible
> +      - nvmem-cells
> +      - nvmem-cell-names
> +

'soc' should be required?

>  additionalProperties: true
> 
>  ...
> --
> 2.17.1
>