Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Lukasz Stelmach <l.stelmach@samsung.com>
To:     Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Ard Biesheuvel <ard.biesheuvel@linaro.org>,
        linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
        platform-driver-x86@vger.kernel.org,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [PATCH v8 3/6] software node: implement reference properties
Date:   Mon, 09 Nov 2020 20:54:59 +0100
In-Reply-To: <20201109185305.GT1003057@dtor-ws> (Dmitry Torokhov's message
        of "Mon, 9 Nov 2020 10:53:05 -0800")
Message-ID: <dleftjr1p2nw4s.fsf%l.stelmach@samsung.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-="; micalg="pgp-sha256";
        protocol="application/pgp-signature"
CMS-TYPE: 201P
References: <20201109185305.GT1003057@dtor-ws>
        <CGME20201109195504eucas1p19d493c947d8752e39c26202cf0978fc0@eucas1p1.samsung.com>
Precedence: bulk

--=-=-=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

It was <2020-11-09 pon 10:53>, when Dmitry Torokhov wrote:
> On Mon, Nov 09, 2020 at 07:18:37PM +0100, Lukasz Stelmach wrote:
>> It was <2020-11-09 pon 19:24>, when Andy Shevchenko wrote:
>> > On Mon, Nov 09, 2020 at 06:02:29PM +0100, Lukasz Stelmach wrote:
>> >> It was <2019-11-07 czw 20:22>, when Dmitry Torokhov wrote:
>> >> > It is possible to store references to software nodes in the same fa=
shion as
>> >> > other static properties, so that users do not need to define separa=
te
>> >> > structures:
>> >> >
>> >> > static const struct software_node gpio_bank_b_node =3D {
>> >> > 	.name =3D "B",
>> >> > };
>> >> >
>> >> > static const struct property_entry simone_key_enter_props[] =3D {
>> >> > 	PROPERTY_ENTRY_U32("linux,code", KEY_ENTER),
>> >> > 	PROPERTY_ENTRY_STRING("label", "enter"),
>> >> > 	PROPERTY_ENTRY_REF("gpios", &gpio_bank_b_node, 123, GPIO_ACTIVE_LO=
W),
>> >> > 	{ }
>> >> > };
>> >> >
>> >> > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
>> >> > ---
>> >>=20
>> >> I am writing a piece that needs to provide a list of gpios to a
>> >> diriver. The above example looks like what I need.
>> >
>> > Nope.
>> >
>> > It mustn't be used for GPIOs or PWMs or whatever that either should co=
me via
>> > lookup tables or corresponding firmware interface.
>> >
>>=20
>> May I ask why? I've read commit descriptions for drivers/base/swnode.c
>> and the discussion on lkml and I understand software nodes as a way to
>> provide (synthesize) a description for a device that is missing a
>> description in the firmware. Another use case seems to be to replace (in
>> the long run) platform data. That is what I am trying to use it for.
>>=20
>> I want my device to be configured with either DT or software_nodes
>> created at run time with configfs. My device is going to use GPIOs
>> described in the DT and it is going to be configured via configfs at run
>> time. I could use platform_data to pass structures from configfs but
>> software nodes would let me save some code in the device driver and use
>> the same paths for both static (DT) and dynamic (configfs)
>> configuration.
>>=20
>> Probably I have missed something and I will be greatful, if you tell me
>> where I can find more information about software nodes. There are few
>> users in the kernel and it isn't obvious for me how to use software
>> nodes properly.
>
> Yeah, I disagree with Andy here. The lookup tables are a crutch that we
> have until GPIO and PWM a taught to support software nodes (I need to
> resurrect my patch series for GPIO, if you have time to test that would
> be awesome).

It will be great to help. I=C2=A0am not sure if I have means to test PWMs,
but I can do GPIOs.

=2D-=20
=C5=81ukasz Stelmach
Samsung R&D Institute Poland
Samsung Electronics

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEXpuyqjq9kGEVr9UQsK4enJilgBAFAl+pnpMACgkQsK4enJil
gBByKQgAkxubb9+fQ8Q8CxUOcAoEFhm9/mGmiqvKYt3tMj8QFl6Ns4SKyo5koe2g
CfZvxmo64cv2mOOkcRCxVqU7A3WbNvhJoaJUmnvOURCT/nTSfx5fJGYzwshQz30N
wUFPjhWO8N2K7vyL+xUUor5ZHe2By0k9b0PHPLe7w1mprQ9TBFlTvDIK4eDDTY8b
c3omtlW9HX6GR0tc7UCcTRpNofSuD66+Ya66AtvxS/jTvICxDM7n68A6h/X5o2Km
ZGUwN7itkAg/0BbQjBgQiR6+PZ41wm8PFls3P5U3uc4qMeyVE87bhMnyyiabg8oQ
x7XZ8zMJbikCqLWP386saRHAiYkvSw==
=c5q9
-----END PGP SIGNATURE-----
--=-=-=--