Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp3488143pxb; Mon, 9 Nov 2020 12:29:50 -0800 (PST) X-Google-Smtp-Source: ABdhPJxTgVvdY+qbzlDh/tbMJrGZzJVZwM6L/ht9Hbb0FSm7qTdDjBTD5YHL1QNCUaMDy1z/M8+D X-Received: by 2002:a17:907:d23:: with SMTP id gn35mr3429203ejc.238.1604953790433; Mon, 09 Nov 2020 12:29:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604953790; cv=none; d=google.com; s=arc-20160816; b=y+Jad6sNiudweM7eKpQ1DDBRoAb/lk+m8p5skundnp5Cls+XHjhSh1L3YkBTEL0gDF XAjM5gEHyEV4dgW0xAlap7amVA68qY+V0885wHk3vgzgqbgQojN28zLSFs6qrf/vmTvn gEZ8ZzcffjKdRKINmLtilnvZQ/y0F4kptjRSOisZCsx82rsJ3Bn7bKV9CAb1ogf7bcZa 0W0XWOyQe79cXakKCjWkk9vxrWAOA45Xr8jgEqKT16vXlsULIjAqRnrbjoLnFRMECxNL NV5C0jui/Z7ZnaqsQw+O4NYyqrES+wWqfba3okJqprb69mv3F9Rcbv5U+AhA0TxV6JmA v7zA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=YKRwez1RHpvoPJ9o8anP5jYVJ+VaWB0hDVM4B0WrFe0=; b=0wN1eJlwBFkPU3EQNv27gSqpXARnIgr2aPDx03E7usWN8zh0CmsF77tNCQOePLID8w 2ju4FnQhyfoFctCvT7OiCGoGmXmsboNm7mF8LZP99vSxE5B4j6wU4wdsGOIG5TTS/qeK cChX7VIOqQxpFSpgcRNDw/PYswLT+Brm3DUH/s/djRQRsNvM82CJcr1QBMZX5FHFCMDG 0zU0FVztVjxszeZlJ94wK/7//xROW0B9bFcgj5KROZgi/89dqmOiHE0QpaKSiE1DwpOW St8ADQyTgerlF58yEijXImwfpYOR0qCMuKFpeYPGVJ2PRRW9CmmMR1YgbrAAP6tkkSbh ub5w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cw28si3409859edb.309.2020.11.09.12.29.27; Mon, 09 Nov 2020 12:29:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729965AbgKIU0F (ORCPT + 99 others); Mon, 9 Nov 2020 15:26:05 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:44140 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726952AbgKIU0E (ORCPT ); Mon, 9 Nov 2020 15:26:04 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kcDjj-00699l-ND; Mon, 09 Nov 2020 21:25:59 +0100 Date: Mon, 9 Nov 2020 21:25:59 +0100 From: Andrew Lunn To: Sven Van Asbroeck Cc: Heiner Kallweit , Jakub Kicinski , Russell King , "David S. Miller" , netdev , Linux Kernel Mailing List Subject: Re: [PATCH net-next v1] net: phy: spi_ks8995: Do not overwrite SPI mode flags Message-ID: <20201109202559.GF1456319@lunn.ch> References: <20201109193117.2017-1-TheSven73@gmail.com> <20201109194934.GE1456319@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 09, 2020 at 02:56:38PM -0500, Sven Van Asbroeck wrote: > On Mon, Nov 9, 2020 at 2:49 PM Andrew Lunn wrote: > > > > Did you check to see if there is a help to set just the mode without > > changing any of the other bits? > > Absolutely, but it doesn't exist, AFAIK. > It would be great if client spi drivers would use a helper function like > that. Then you should consider adding it, and cross post the SPI list. Andrew