Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp3511134pxb; Mon, 9 Nov 2020 13:11:09 -0800 (PST) X-Google-Smtp-Source: ABdhPJxJ+HgF97ox9nSLH3WTKMMv6JPiwxsRu60Ybh85nw1OKpBapr054shklMs5cwNNMJmbprG1 X-Received: by 2002:a17:906:6d4:: with SMTP id v20mr17958583ejb.500.1604956268806; Mon, 09 Nov 2020 13:11:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604956268; cv=none; d=google.com; s=arc-20160816; b=j6yKmEc84cJZ+Bn0wdLqneT3Z5gp/vxZIoYvwgAxKZwnuN5ya9OV3AyWVNXVBAgXG0 C1vZTLYPiDWhW6dPONrvrx0aLrKFkQVCNt4Lo8gnsuxQv5lBIzQTFBM6FobRoSBsPVUj zmgWGX1xAE4BB/bNiZeS0sGS/PKHxcOYFRazOg9FpmOI50sxw1kDBCLgshEuC8TPo7Cp P2nkUBtnUhO5yHfP7y2oGCAguEZYGW3OJ4IWO22tJO8lSmKsOqtyVBjdrqpQaS7sIJaF nuf+aSw6Gk4rOqbZkPADwdTDbeff2rpUj+hm0RftfNpmkN6DqElilS6A5+M1m9k7CHLc H8AA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=ovlmdojfxlwMZ2ZebETCu0y39/joFf1To8fTVVKWe4s=; b=ASVPam9l6bBuAU4i2Dqv2EuKlW9CqVj1X6Y50leXUhJWpfBGBZ+2SpncH7YUJaMaJj olDHRyCf1UrxDyz3zR5kMbSMirXxCWeltRTfZUaT0YOHfPxsIlHiMs8C7/z2kftmFMDg 4vwsC+cnCbbDBPemsgBQu5wrlJr8n4+Pc0IF+BwAUhXWJDp4Vm1loHkJnh3MScQ0DNxy Zs0yR25Y2qoLQgNdPe5l4mzdaMw+QfllZFWU/Kq4SjrY++jzXYMdqVPBymG2da41NP+I KmuizIwT1Gj+AsJxLb56dI28kCqVv28MGWYpL0CDc9M0ub6unx6GEuYIpJxmqtD3KWLF Jgsw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Me0aH2dK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d10si7599408ejh.20.2020.11.09.13.10.45; Mon, 09 Nov 2020 13:11:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Me0aH2dK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729878AbgKIVJC (ORCPT + 99 others); Mon, 9 Nov 2020 16:09:02 -0500 Received: from mail.kernel.org ([198.145.29.99]:37090 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725946AbgKIVJC (ORCPT ); Mon, 9 Nov 2020 16:09:02 -0500 Received: from kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net (c-67-180-217-166.hsd1.ca.comcast.net [67.180.217.166]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8DDC3206CB; Mon, 9 Nov 2020 21:09:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604956141; bh=Pv45jqhpj6D9l7uaZtADH1iQ5NeKsgfBsKyUxNTbCdM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Me0aH2dKk/4bCMtGXZanq7PtE72HwuKT5YkPJ9kWnasPBz/iJDnRO+YlvGr/19DNI 9urR7G4y5C/p6yyo5kfMIrJpn3mjH3PvHr/5lS7Ya6tI15XPOjtQftRQe+OhmnnW31 75ft5EBCFV9VIFPgSpJFrggrMtzIx+SDo7h9nuYA= Date: Mon, 9 Nov 2020 13:09:00 -0800 From: Jakub Kicinski To: Sven Van Asbroeck Cc: Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v1] net: phy: spi_ks8995: Do not overwrite SPI mode flags Message-ID: <20201109130900.39602186@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> In-Reply-To: <20201109193117.2017-1-TheSven73@gmail.com> References: <20201109193117.2017-1-TheSven73@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 9 Nov 2020 14:31:17 -0500 Sven Van Asbroeck wrote: > From: Sven Van Asbroeck > > This driver makes sure the underlying SPI bus is set to "mode 0" > by assigning SPI_MODE_0 to spi->mode. This overwrites all other > SPI mode flags. > > In some circumstances, this can break the underlying SPI bus driver. > For example, if SPI_CS_HIGH is set on the SPI bus, the driver > will clear that flag, which results in a chip-select polarity issue. > > Fix by changing only the SPI_MODE_N bits, i.e. SPI_CPHA and SPI_CPOL. > > Signed-off-by: Sven Van Asbroeck This is a fix right? You seem to be targeting net-next and there is no Fixes tag but it sounds like a bug.