Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp3517834pxb; Mon, 9 Nov 2020 13:22:43 -0800 (PST) X-Google-Smtp-Source: ABdhPJxhK+tpAUl4rN4w2szwSiUHOraT/M06IB+eevOhAMaTgytuWrowWYVMvfLYXIBPwtKThgCo X-Received: by 2002:a17:906:f752:: with SMTP id jp18mr16215828ejb.331.1604956963100; Mon, 09 Nov 2020 13:22:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604956963; cv=none; d=google.com; s=arc-20160816; b=OFdg2zJN52Z19ePNBx+nLmKT4sZx4/XQMZd161Du5EKx5GS/OwXFTmxl3GgNgH+r4u ikn4RE3IK9+f2YaPbqXqP9n10zDPqTIU/QCIG0f92UO/f8atN/oEa8N75VO6fXV0xIf3 F8BvUPNFD95nbBSj/nBZmTPNGY0iGEWzrRQ/pJ8uXijVf6i8FO8PTukSksjJXWeKQRsP ji7S+T9YVXIuo6NMiBG5JrHG6MGAPjnC8S3b6EwWeuSN+1cLYYVdkd0QpPSLD6w6+uA6 80PyuGCIN1v7b2f9Icc5q1CeYX9G3MU2i1vO1ME/W2H/WWLUlZ7DPeSavJ2Qniro9NYL ZoGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=e/mxdauGCfin4P1unK7sTKqBRJWd95ferwSgYprlXsM=; b=vOGKKKW7gZgScN1x624ckm635dy/MkAo8rgan3CDUOg8tcTZ4+S+aN6GtwugKk0ebP EatwN898NhA9D3fUs0F6JPD+DXhninbp5UuupLQ2+8ZUBDqELBLId6Yc2gapg13SCEXI 31N3TCAWHy7WMOf9MtnhYTgD9VdBl2K6Tcimwa5B3KlON6sLtK95fdvJq9QNic8bmlnX XXuAZcyfeGbtSArsuMLfE4mezFHzJFosgJRyhQfpBJf+PycPQ9WXyynu2QQ89/4cqAbU 8quDfZur9FUYVjronSWB602eD9PLJL9b7eNNJ5uKeXjoUMgl99DVrgR1IbVYLnD7CNov 5zpA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=b5h89XM0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bt10si7763518edb.503.2020.11.09.13.22.20; Mon, 09 Nov 2020 13:22:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=b5h89XM0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731470AbgKIVUN (ORCPT + 99 others); Mon, 9 Nov 2020 16:20:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731388AbgKIVTd (ORCPT ); Mon, 9 Nov 2020 16:19:33 -0500 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7CA1CC0613CF for ; Mon, 9 Nov 2020 13:19:33 -0800 (PST) Received: by mail-wm1-x343.google.com with SMTP id s13so906679wmh.4 for ; Mon, 09 Nov 2020 13:19:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=e/mxdauGCfin4P1unK7sTKqBRJWd95ferwSgYprlXsM=; b=b5h89XM0bSAA01H9VI7YC0WubiXdlYohWOGdakYwfbQeM0MifG/HJ7RiJjyS8bNAqv Yq0xrDdJ/NdDCYnAvDV+Gz94LXJqrl3Y9rQ1xU5cQVElcN9MRBYPt7zShja/Bk9UKiY+ WqQGtf5m5oHpwx0PpT6vx6sx0WU+595ypt6m//MfqLkRGLEVbmlBXKkjvjc4+0QCw5SY 32zJqgbybJVw0CEE2G/rBftR+lVzzS50Z19Gnxv32vnSAyV0pO+I/ApDOOXfswqPnmLU rAqt+Z5FRuuTuszclEWd6FGcuvBK9Rvt+6Q2ubDA7I6UNZGYzp4HdqjtuyoOZzsm2oeB Q+Pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=e/mxdauGCfin4P1unK7sTKqBRJWd95ferwSgYprlXsM=; b=DE2ymZeWSTcRKdvexKyuAL2k3vetQRHxiALzdKFY5/OEX19rm3pOQtxxmse2oV2WX0 2rJafxT23ulrLtYZUL9tAz5DlGT/Y5yZVH8seGqTgF62vCmT62SdaClqdm51wl8EkcsZ pG2iT2Fhsq4zFFzoLn/p9X8TpqGN6kyXn4Hr8ldhojm8lxk5XB2rGfkVAY9UlMlxlwYo uPT2lX4BWKLdAcGuO+35gM0R1UxcCyhki3MB6WKm7chmq36zQrZS8fsGanPSP1M/T2m8 99clH9ecEVSAHvUkW0DZapvsJaFPlwRlPsq5K9yiOqyzplzTyRDPzQ2sqJtEY5ZHJi0C eIOg== X-Gm-Message-State: AOAM5332NZc3PNMnKX7ithp0r7iQBMiGnAr6IOgbnluFE3ovuGnZ3Qh2 z+x72Us3txE3WeLrgAIK0Ls9nA== X-Received: by 2002:a1c:6545:: with SMTP id z66mr1082675wmb.157.1604956772232; Mon, 09 Nov 2020 13:19:32 -0800 (PST) Received: from dell.default ([91.110.221.139]) by smtp.gmail.com with ESMTPSA id 71sm15170630wrm.20.2020.11.09.13.19.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 13:19:31 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , David Airlie , Daniel Vetter , Sumit Semwal , Jerome Glisse , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org Subject: [PATCH 12/20] drm/radeon/radeon_cs: Fix a bunch of doc-rot issues Date: Mon, 9 Nov 2020 21:18:47 +0000 Message-Id: <20201109211855.3340030-13-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201109211855.3340030-1-lee.jones@linaro.org> References: <20201109211855.3340030-1-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/radeon_cs.c:416: warning: Function parameter or member 'backoff' not described in 'radeon_cs_parser_fini' drivers/gpu/drm/radeon/radeon_cs.c:735: warning: Function parameter or member 'p' not described in 'radeon_cs_packet_parse' drivers/gpu/drm/radeon/radeon_cs.c:735: warning: Function parameter or member 'idx' not described in 'radeon_cs_packet_parse' drivers/gpu/drm/radeon/radeon_cs.c:735: warning: Excess function parameter 'parser' description in 'radeon_cs_packet_parse' drivers/gpu/drm/radeon/radeon_cs.c:844: warning: Function parameter or member 'p' not described in 'radeon_cs_packet_next_reloc' drivers/gpu/drm/radeon/radeon_cs.c:844: warning: Function parameter or member 'cs_reloc' not described in 'radeon_cs_packet_next_reloc' drivers/gpu/drm/radeon/radeon_cs.c:844: warning: Function parameter or member 'nomm' not described in 'radeon_cs_packet_next_reloc' drivers/gpu/drm/radeon/radeon_cs.c:844: warning: Excess function parameter 'parser' description in 'radeon_cs_packet_next_reloc' drivers/gpu/drm/radeon/radeon_cs.c:844: warning: Excess function parameter 'data' description in 'radeon_cs_packet_next_reloc' drivers/gpu/drm/radeon/radeon_cs.c:844: warning: Excess function parameter 'offset_start' description in 'radeon_cs_packet_next_reloc' drivers/gpu/drm/radeon/radeon_cs.c:844: warning: Excess function parameter 'offset_mask' description in 'radeon_cs_packet_next_reloc' drivers/gpu/drm/radeon/radeon_cs.c:844: warning: Excess function parameter 'reloc' description in 'radeon_cs_packet_next_reloc' Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Sumit Semwal Cc: Jerome Glisse Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Cc: linux-media@vger.kernel.org Cc: linaro-mm-sig@lists.linaro.org Signed-off-by: Lee Jones --- drivers/gpu/drm/radeon/radeon_cs.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_cs.c b/drivers/gpu/drm/radeon/radeon_cs.c index 21ce2f9502c09..729939df29cc5 100644 --- a/drivers/gpu/drm/radeon/radeon_cs.c +++ b/drivers/gpu/drm/radeon/radeon_cs.c @@ -408,6 +408,7 @@ static int cmp_size_smaller_first(void *priv, struct list_head *a, * cs_parser_fini() - clean parser states * @parser: parser structure holding parsing context. * @error: error number + * @backoff: indicator to backoff the reservation * * If error is set than unvalidate buffer, otherwise just free memory * used by parsing context. @@ -723,8 +724,9 @@ int radeon_cs_ioctl(struct drm_device *dev, void *data, struct drm_file *filp) /** * radeon_cs_packet_parse() - parse cp packet and point ib index to next packet - * @parser: parser structure holding parsing context. + * @p: parser structure holding parsing context. * @pkt: where to store packet information + * @idx: packet index * * Assume that chunk_ib_index is properly set. Will return -EINVAL * if packet is bigger than remaining ib size. or if packets is unknown. @@ -829,11 +831,9 @@ void radeon_cs_dump_packet(struct radeon_cs_parser *p, /** * radeon_cs_packet_next_reloc() - parse next (should be reloc) packet - * @parser: parser structure holding parsing context. - * @data: pointer to relocation data - * @offset_start: starting offset - * @offset_mask: offset mask (to align start offset on) - * @reloc: reloc informations + * @p: parser structure holding parsing context. + * @cs_reloc: reloc informations + * @nomm: never actually used * * Check if next packet is relocation packet3, do bo validation and compute * GPU offset using the provided start. -- 2.25.1