Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp3566534pxb; Mon, 9 Nov 2020 14:54:55 -0800 (PST) X-Google-Smtp-Source: ABdhPJzld3+Y5PAyJGKNJHOljsoQ26lO1AooECyfyIzho0XFEhJPld3RW4cBIb+DyL1WrFjQ4VXy X-Received: by 2002:a50:a6d0:: with SMTP id f16mr17281941edc.135.1604962495681; Mon, 09 Nov 2020 14:54:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604962495; cv=none; d=google.com; s=arc-20160816; b=EEfZ04C7GS3ZFU7wjdiuin+PKv9hswhrRW+TL19EKFkrrJF+igtJ+7hENTjil2qbe7 koFNiTD5AZXQDQNCeM3aGukZXmz5IpoNW7JLwHBb2pSejTIUQeo61sCyF7+nXve2aae6 Id6HPhAoyfa3In7acgSKI9n52ybIyKh4GPP0lYkjs/yVK5IneFmzgZzc2juejFhlsIvb 28ljVx4GTWCxElqIYcCmVhOSD3Z40i8JyaiEAR5Kgbq3gskpjFpDr7C8+ZtI7Vo70Ull O1gEnuP99v1o+c9K9QJaY8a8MwI8Hv0FQ+Lhd+WMA9G7QD9kq/BpX5hC5bJTgq8N+JRS O3lQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=txv+At+3yeOrsWXR6dLpQayjehiEbp5bftx46nlauZA=; b=b+OWoFXw5XNEiJbE/u/4SYuUuDo6FZkrofxezEiKlWwcZU8t3/v2gpktofaQynJ0yi cZtEjojDrLmcten8BY9ScNT7c2/fqS0WmDhU52u2ksYGD5jeHaTdyBYOLTe0Y+eXx7fJ o8VyodQSpWCanEcceYpfJ8SUuC/IGyWa2iwQyp+D1pSAw7qgr8ioEEmQV2KqlzXiB3fC XD4KYo4mefn1mfQ0gJQJbu2eaY4D0ijm99Qm5okJhtCbgvg6i6AWnNKMu0T8yRL7hv5Q z0ZL8gXQybuPDyceF5Yz8aUfR4SFoeaWIIMHEg6LrkNUYtNtgNaKx0L9U0bAg6eb7oIa vhTg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=cgALtHFV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cz19si7474689edb.512.2020.11.09.14.54.31; Mon, 09 Nov 2020 14:54:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=cgALtHFV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730467AbgKIWuw (ORCPT + 99 others); Mon, 9 Nov 2020 17:50:52 -0500 Received: from mail.kernel.org ([198.145.29.99]:60536 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729247AbgKIWuv (ORCPT ); Mon, 9 Nov 2020 17:50:51 -0500 Received: from kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net (unknown [163.114.132.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CFCB3206C0; Mon, 9 Nov 2020 22:50:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604962251; bh=apQ2qdH9FTTvtkF02IPDqcoq8TgCgCDbRlAv5SA6baM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=cgALtHFVZ6r93CS3CJASGpLf7pmZFnw/iB3Q0ZI0FhMDKsUG5LKF96uJqKnjdlbFe /4iIeupM9h9GrTKRadp7Xz2OQoG76ItGruYuZAKOVTPuId+vAPm21b+YHg7jz5Py17 4rmD5yLY3feZw8qR1nTt45G30UxW/niMCwEe4LVk= Date: Mon, 9 Nov 2020 14:50:49 -0800 From: Jakub Kicinski To: Sven Van Asbroeck Cc: Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , netdev , Linux Kernel Mailing List Subject: Re: [PATCH net-next v1] net: phy: spi_ks8995: Do not overwrite SPI mode flags Message-ID: <20201109145049.42e0abe5@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> In-Reply-To: References: <20201109193117.2017-1-TheSven73@gmail.com> <20201109130900.39602186@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> <20201109132421.720a0e13@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> <20201109140428.27b89e0e@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> <20201109142322.782b9495@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> <20201109143605.0a60b2ab@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 9 Nov 2020 17:39:22 -0500 Sven Van Asbroeck wrote: > What I already posted (as v1) should be the minimal fix. > Can we proceed on that basis? I'll follow up with the helper > after the net -> net-next merge, as you suggested. Well, you cut off the relevant part of my email where I said: But please at least repost for net and CC Mark and the SPI list for input. Maybe Mark has a different idea on how client drivers should behave. Also please obviously CC the author of the patch who introduced the breakage.