Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp3568509pxb; Mon, 9 Nov 2020 14:59:20 -0800 (PST) X-Google-Smtp-Source: ABdhPJxC/Gw/8ZchtIrkxSswWmBBiR10EhAqheXh8y2hk9onznsqd7m4xhQpvBvVnkcUOdNzHx1d X-Received: by 2002:a17:906:b20c:: with SMTP id p12mr17199220ejz.369.1604962760516; Mon, 09 Nov 2020 14:59:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604962760; cv=none; d=google.com; s=arc-20160816; b=i3uznF/kkPgPCQ1UriKRLHD+W78/ks9wDFke013KJPQaDoq4EGgspalkl2gtIHnos8 WTbrBtQxl0qFQuSCR84PQRaBO/6HnQ6tV25UYnPGKhMohTqSpGLMIkvngcTWDySVGJ8u 9TnWzaHCSEE+0EOb7Sp55yQkZccrUH5XeOlBxtfjaA+Jv1kzO8PmEpvBmmtI93od3ULv XF3m919chJsikyTYqEBLULP7YhiVsm5e2jko6wbsbpO0732hyzpkh/SnXvJQt1UPaC7N bQQxHR42oDzQDqRXT9TmT3wC2YIPX4C9/Ai8RthwUPD5Mp00UBbmZEYUziPBCS8rXoPw mL0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=es9iLiu0OSLSHKxLFLhvMkFrTkEk1Ugq3hgIApTVdA4=; b=UmyPc0Vcx9Jc/eLjpEsvf2AdZQilbcs8cE4k68ehmU5fab0AzvuHD/DyygCKVqTMCn xAC659wTiZVUyjByLQeGduxOf/HdNwi0YJM346h69DDVhgPLIxzVpdqXq1FwbaOJHwi0 D3gH4HPsNDtocQnD/5awmOy5NjSuI/tfcRdS5xx2If6Pf8g+i5p/+ucU+oQjXZqHSN2I PfS9ASZkj2H5cchJQANmG0JcnmYDiYkNtLmqBlg4xWP9HSLBAuE3E2UZgQYwFVK+4fXS QfRBG1SozjnEYrPfPxRmTZyWsiVfq0mk7XF48ulYUAH+T1z9qe464MXoU/sTFpjce+iE 4jHQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=QSa2KbZU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d2si2144861edm.376.2020.11.09.14.58.56; Mon, 09 Nov 2020 14:59:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=QSa2KbZU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729987AbgKIW5g (ORCPT + 99 others); Mon, 9 Nov 2020 17:57:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57656 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729247AbgKIW5g (ORCPT ); Mon, 9 Nov 2020 17:57:36 -0500 Received: from mail-ua1-x944.google.com (mail-ua1-x944.google.com [IPv6:2607:f8b0:4864:20::944]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E785BC0613CF; Mon, 9 Nov 2020 14:57:35 -0800 (PST) Received: by mail-ua1-x944.google.com with SMTP id x13so3186564uar.4; Mon, 09 Nov 2020 14:57:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=es9iLiu0OSLSHKxLFLhvMkFrTkEk1Ugq3hgIApTVdA4=; b=QSa2KbZUZBeiY6NmYmou9TcUHL2mMhtVRei27UWYHAb46yUOQkKktBWns05VgjjuTF stFXNzBZCzP1fuwR4TNNxNwyMUzmwhtt5sltInl1r2bKmDdcypwjZbt8PzRIO8KrDwUl ieQvZrehxLl4DUlWtfXWT6e7vG45IlbTywBIhEX8OfjcZ+W90CycrLOFP1YbhebrxoIJ UqD8wmuHA4ImO2iW1pPGSyGwSH4KDHyjJTT2jrixizne93gJD9UdERQRX4s21QoFpVw5 OIB3fkOowBrJKZ4zuhdNdB2qECMStmssc2V67oUoNulHdQu/+2+dRVf6zaS14pEti2Xv ArQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=es9iLiu0OSLSHKxLFLhvMkFrTkEk1Ugq3hgIApTVdA4=; b=IneoU7ooJRnLZfL4MCQgh2pvByP/M2v5Z+GxBROHqHEsiG6nJvQkUvgSsYeAWZnbv4 R5u1OrqBeb2pvHlQbcM4n74SBXkrkLkc5hlyyPiGVaAhxbaMhjs7+uqs7ann9jTrkYK7 wRoyIZlnJ30XsKkrSCykwL369Y1CQjufhdJbgBe6Hs14gF+fqyoo/7eg93SSWhvwmQvB 28QuY7PV9AbXD1sH3u8poyVHViXd6K4rWoFsw453zC+oFo2aagUwFABMAa1Dpxflv8cq T8fo8gWybDi9c+8dLl69xbbxc1vxxIXhlSAymlEUGM5WSzBJ97yHrWG3SVHPrZSO1t8Q 41ig== X-Gm-Message-State: AOAM532zEmqtSy6T5GZq0nyOdxJqdzoMxeRq5rJp2sUofuKhaK9mdYEm zYXnatngw1NW0r/70S72IDYfzcFA4UqIlIeGkQ8= X-Received: by 2002:ab0:281a:: with SMTP id w26mr8262195uap.49.1604962655139; Mon, 09 Nov 2020 14:57:35 -0800 (PST) MIME-Version: 1.0 References: <20201109193117.2017-1-TheSven73@gmail.com> <20201109130900.39602186@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> <20201109132421.720a0e13@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> <20201109140428.27b89e0e@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> <20201109142322.782b9495@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> <20201109143605.0a60b2ab@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> <20201109145049.42e0abe5@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> In-Reply-To: <20201109145049.42e0abe5@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> From: Sven Van Asbroeck Date: Mon, 9 Nov 2020 17:57:23 -0500 Message-ID: Subject: Re: [PATCH net-next v1] net: phy: spi_ks8995: Do not overwrite SPI mode flags To: Jakub Kicinski Cc: Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , netdev , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 9, 2020 at 5:50 PM Jakub Kicinski wrote: > > But please at least repost for net and CC Mark and the SPI list > for input. > > Maybe Mark has a different idea on how client drivers should behave. > > Also please obviously CC the author of the patch who introduced > the breakage. I believe they're aware: I tried to propose a patch to fix this in the spi core, but it looks like it was rejected - with feedback: "fix the client drivers instead" https://patchwork.kernel.org/project/spi-devel-general/patch/20201106150706.29089-1-TheSven73@gmail.com/#23747737 I will respin this minimal fix as v2, add Fixes tags and Cc the people involved, as you suggested.