Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 10 Nov 2020 11:23:58 +1100
From:   Stephen Rothwell <sfr@canb.auug.org.au>
To:     Randy Dunlap <rdunlap@infradead.org>
Cc:     linux-kernel@vger.kernel.org,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
        linux-pm@vger.kernel.org,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>, linux-clk@vger.kernel.org,
        Taniya Das <tdas@codeaurora.org>, linux-next@vger.kernel.org,
        Nathan Chancellor <natechancellor@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH -next v2] clk: pm_clock: provide stubs for
 pm_clk_runtime_suspend/_resume
Message-ID: <20201110112358.7534075f@canb.auug.org.au>
In-Reply-To: <20201109032115.10610-1-rdunlap@infradead.org>
References: <20201109032115.10610-1-rdunlap@infradead.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/kVA7201z7YABmbVZ.11D5.l";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Precedence: bulk

--Sig_/kVA7201z7YABmbVZ.11D5.l
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi all,

On Sun,  8 Nov 2020 19:21:15 -0800 Randy Dunlap <rdunlap@infradead.org> wro=
te:
>
> Add stubs for pm_clk_runtime_suspend() and pm_clk_runtime_resume()
> to fix build errors when CONFIG_PM and CONFIG_PM_CLK are not enabled.
>=20
> Fixes these build errors:
>=20
> ../drivers/clk/qcom/camcc-sc7180.c: In function =E2=80=98cam_cc_sc7180_pr=
obe=E2=80=99:
> ../drivers/clk/qcom/camcc-sc7180.c:1672:8: error: implicit declaration of=
 function =E2=80=98pm_clk_runtime_resume=E2=80=99; did you mean =E2=80=98pm=
_runtime_resume=E2=80=99? [-Werror=3Dimplicit-function-declaration]
>   ret =3D pm_clk_runtime_resume(&pdev->dev);
>         ^~~~~~~~~~~~~~~~~~~~~
> ../drivers/clk/qcom/camcc-sc7180.c:1681:3: error: implicit declaration of=
 function =E2=80=98pm_clk_runtime_suspend=E2=80=99; did you mean =E2=80=98p=
m_runtime_suspend=E2=80=99? [-Werror=3Dimplicit-function-declaration]
>    pm_clk_runtime_suspend(&pdev->dev);
>    ^~~~~~~~~~~~~~~~~~~~~~
>=20
> Fixes: 15d09e830bbc ("clk: qcom: camcc: Add camera clock controller drive=
r for SC7180")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> Cc: Len Brown <len.brown@intel.com>
> Cc: Pavel Machek <pavel@ucw.cz>
> Cc: linux-pm@vger.kernel.org
> Cc: Michael Turquette <mturquette@baylibre.com>
> Cc: Stephen Boyd <sboyd@kernel.org>
> Cc: linux-clk@vger.kernel.org
> Cc: Taniya Das <tdas@codeaurora.org>
> Cc: linux-next@vger.kernel.org
> Cc: Nathan Chancellor <natechancellor@gmail.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> ---
> v2: move the function stubs to be inside the #else (for !CONFIG_PM)
>     as suggested by Nathan to fix another build error
>=20
>  include/linux/pm_clock.h |    8 ++++++++
>  1 file changed, 8 insertions(+)

I have added this to the merge of to clk tree in linux-next today
(pending it being added to the clk tree itself).

--=20
Cheers,
Stephen Rothwell

--Sig_/kVA7201z7YABmbVZ.11D5.l
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAl+p3Z4ACgkQAVBC80lX
0GylrggAgWLtxVpvAT6XbNbAXqfr2ATTEcubuM8h7Tueti77AlQlAh99RWqKHHAI
lS05MrkjXe9XPYEI8kPkhph+/LSFhmRezQc6KsH7Y5E8uNZL/4k474A4Z6Cz2uE+
SL+1M1BDRONkfD9l5cuDdqEhwHLZzgZ8vQdfus5+9RnprRMV3PtqW1FTFZUsjXBd
H37vt4K6ZTJvgPB+7XH6+FPFBeVsqnVilx8IYK/2G12yWN7Gb4eZIUGoZbMGXzCf
M63Gm+bpVPcuRWV/PboK/FeVUyJ8mjldjMwCjUxJPGJgVoO6gyJuFCuf2ivMoYrh
wbU5dOw3Ka3fUA3OiTQkI3/pGv7MaA==
=qN6g
-----END PGP SIGNATURE-----

--Sig_/kVA7201z7YABmbVZ.11D5.l--