Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp3653074pxb; Mon, 9 Nov 2020 17:43:42 -0800 (PST) X-Google-Smtp-Source: ABdhPJx6I1dAJE1RQ7X1CW3Sl9YBtu3kLP210h/EuO9onnJxq1s+AZheWqXcDHiu1pRsjHo0EsLk X-Received: by 2002:a17:906:4705:: with SMTP id y5mr17443651ejq.112.1604972622104; Mon, 09 Nov 2020 17:43:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604972622; cv=none; d=google.com; s=arc-20160816; b=KROBqmmUYnBVYeC2O9IBP5LeuMVhvKqUJdnc08qNYVIbJ/6uN7HNLqWyG1VkfhLTO2 ppqJ5n0zHUrKCI/QGIQt/xvcPfFS2gInu2Iy1E10jh5o2LvHm6IQvNAw04pKYAmC2tJq TdXV8AlzsGLTrK6++psBfc+sOmwU3rkEmOG3YJkvLowwovVeFv5LA5OJFPG//urwL2lk fGBH+5O4j4f1EhtsLWe6D2usc9YPXniFKiss1JniTDDJfId6JI5YPkRw4PKNb9IYY+BM fgg9Ep/81Ud3cbDC5mVE44c1wTddWge0dwE66b8Pir3AjJnUT73dd5Gh2Lv0JeVgVCCr IQWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=fqIegLU/6+RDb+e7tfhxhJ5dlx3wlPfGgX7i4hnbrqQ=; b=JT4BNKM85C8U3zmw9VkTxTW7gbUVK9yAebZ8qVEXT5KxLnxGUcvx0AvrNGO7OGdTUT fHzbv1gDMGIs5ApVmajIrsBjAjd+Yg4TrNYMYaUTzrMrtnnvx9pA9K45ppb4kwKx8pSt FuY7faHsJuA47arM9M80XoCA1eborivuvnV+jOcIUHjFMFq8HM+gZfxCDxp7Le4jovo1 gGxHIgBTR6s5oriUiUMkxB3AuzKrZxYmqmeP+jVOAsX8C0E3fMGKD/edqgCv1i9BND1I OCN/KNs7MunwU6b8QjdDcW9jmgVeodmaBpXeq5Urq23lJ9G8C2KzaLYgDI40+fdXiuNd w3BQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="W/IWdvo1"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b21si9395113ejz.183.2020.11.09.17.43.19; Mon, 09 Nov 2020 17:43:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="W/IWdvo1"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729968AbgKJBlt (ORCPT + 99 others); Mon, 9 Nov 2020 20:41:49 -0500 Received: from mail.kernel.org ([198.145.29.99]:34134 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725889AbgKJBlr (ORCPT ); Mon, 9 Nov 2020 20:41:47 -0500 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 54A152065D; Tue, 10 Nov 2020 01:41:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604972506; bh=DdNDkC1zyUDmV0VvGjYD9xPcxiipqhzX0rr6mtoMTcc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=W/IWdvo15kwJJi+uCCtq/MbRQ9c7uQ/HspXfETkivOp6ourv+a6g971E59t28bj2X IrzCFZR3GX85PVBsKP2UjQ7OwGceN7qkhRnRFkiIl/cF1qciX1ejXwJQbkBGKC3IL5 nVWyf+iy8PAvBzh0qRm8413rGclCp15JoT+jjwgU= Date: Mon, 9 Nov 2020 17:41:45 -0800 From: Jakub Kicinski To: Andrew Lunn Cc: Jisheng Zhang , Florian Fainelli , Heiner Kallweit , "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] net: phy: microchip_t1: Don't set .config_aneg Message-ID: <20201109174145.70243122@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20201109173622.GC1456319@lunn.ch> References: <20201109091605.3951c969@xhacker.debian> <20201109173622.GC1456319@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 9 Nov 2020 18:36:22 +0100 Andrew Lunn wrote: > On Mon, Nov 09, 2020 at 09:16:05AM +0800, Jisheng Zhang wrote: > > The .config_aneg in microchip_t1 is genphy_config_aneg, so it's not > > needed, because the phy core will call genphy_config_aneg() if the > > .config_aneg is NULL. > > > > Signed-off-by: Jisheng Zhang > > Reviewed-by: Andrew Lunn Applied, thanks!