Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp3693576pxb; Mon, 9 Nov 2020 19:20:10 -0800 (PST) X-Google-Smtp-Source: ABdhPJxyXI7EG199CbiAhXTAswDCyAe/i2d3irGDsjIoIOr2Od2NdfnZ9qEu+cL/awr/VP3bPlAU X-Received: by 2002:aa7:dd49:: with SMTP id o9mr18409705edw.143.1604978409740; Mon, 09 Nov 2020 19:20:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604978409; cv=none; d=google.com; s=arc-20160816; b=zKweC4F0whMv1/lO9WSvvii2Y1IM+GgWd5b0ge5KpVd5AUqoibKOC/dmpNIbokZTbf HP4FZMHfim3KGRxRGGA99in4FCJ+GY086oF/YWRxs52CopzJ23ovUUbjJju2G9B9KUYh Jt1ITFJnZkPF4MQG3Sp2uUASKh9xErTMoSOA+1z+uVN+JZKfyO+9pRP8bRTR/dabUlY7 iwUhEI8ZjRGsGktp8EdthbWCAuAexvf+R5yg+EMOFMtOuREbS1uBUc5TmkNuUlQLwe95 FysYOKp1chQ5KQex1cfxRBUwYOBu7YDGeWGDpxa2DIio3H+Ej7xsZUSVxfj6W35717aW chEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=2q2a3c0EDL8zpkgGQj4cwdQEtHMV2NPqAstAdMklI3E=; b=MDrjLrBHrJ1YFlf2mSKMVsmGcq5wct7QRv9Kab84pi0+sDCblP7s1YGBP6AQVoRzTX 384oWElL/eRD5wTNTnD9+LYe/U3jAdBp1T/rNSh1x4eLkOKhsJaGsjiK39isMxfTOcna QUYXqtNpzrpPm+ZFhVosFx35fkuQlLfFEBpBrV5LNn70hDzI50wNw1xOfgHctE2wt4/s mg04uJbo8OkecxOu1dDB+qbpQoXukRJ9PEIvSqtB3DDlxDB3hehDJQ5tWZOqFdWnnbCt VBEg+y8D8cPgcLBkCC9onagZfBTUuEg0wMMc0lrGIiuPg/LBXCpADJff45f+rdjZ/oyk wXRw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x19si8835994edi.214.2020.11.09.19.19.46; Mon, 09 Nov 2020 19:20:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730520AbgKJDPx (ORCPT + 99 others); Mon, 9 Nov 2020 22:15:53 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:7510 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728607AbgKJDPw (ORCPT ); Mon, 9 Nov 2020 22:15:52 -0500 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4CVY0H3js5zhhK1; Tue, 10 Nov 2020 11:15:43 +0800 (CST) Received: from localhost.localdomain.localdomain (10.175.113.25) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.487.0; Tue, 10 Nov 2020 11:15:41 +0800 From: Jing Xiangfeng To: , , CC: , , Subject: [PATCH] HID: intel-ish-hid: Remove unnecessary assignment to variable rv Date: Tue, 10 Nov 2020 11:20:49 +0800 Message-ID: <20201110032049.187404-1-jingxiangfeng@huawei.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This assignment to rv is unused in an error path. So remove it. Signed-off-by: Jing Xiangfeng --- drivers/hid/intel-ish-hid/ishtp-hid.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/hid/intel-ish-hid/ishtp-hid.c b/drivers/hid/intel-ish-hid/ishtp-hid.c index b8aae69ad15d..393bed0abee9 100644 --- a/drivers/hid/intel-ish-hid/ishtp-hid.c +++ b/drivers/hid/intel-ish-hid/ishtp-hid.c @@ -211,10 +211,8 @@ int ishtp_hid_probe(unsigned int cur_hid_dev, struct ishtp_hid_data *hid_data; hid = hid_allocate_device(); - if (IS_ERR(hid)) { - rv = PTR_ERR(hid); - return -ENOMEM; - } + if (IS_ERR(hid)) + return PTR_ERR(hid); hid_data = kzalloc(sizeof(*hid_data), GFP_KERNEL); if (!hid_data) { -- 2.17.1