Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2 02/13] ARM: dts: mmp2-olpc-xo-1-75: Delete
 #address-cells from ssp3
To:     Lubomir Rintel <lkundrak@v3.sk>, Arnd Bergmann <arnd@arndb.de>,
        Olof Johansson <olof@lixom.net>,
        Rob Herring <robh+dt@kernel.org>
Cc:     SoC Team <soc@kernel.org>, Rob Herring <robh+dt@kernel.org>,
        linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20200718205019.184927-1-lkundrak@v3.sk>
 <20200718205019.184927-3-lkundrak@v3.sk>
From:   Florian Fainelli <f.fainelli@gmail.com>
Message-ID: <a98683e3-c666-a308-9c67-b898134c13fe@gmail.com>
Date:   Mon, 9 Nov 2020 19:19:30 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Firefox/78.0 Thunderbird/78.4.1
MIME-Version: 1.0
In-Reply-To: <20200718205019.184927-3-lkundrak@v3.sk>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 7/18/2020 1:50 PM, Lubomir Rintel wrote:
> On the XO-1.75, this node represents a bus interface that operates in slave
> mode and thus is only able to accommodate a single subnode; no address
> cells are necessary.
> 
> The Documentation/devicetree/bindings/spi/spi-controller.yaml binding
> prefers that we drop the property instead of setting it to zero.
> 
> This fixes a DT validation error:
> 
>   arch/arm/boot/dts/mmp2-olpc-xo-1-75.dt.yaml: spi@d4037000:
>       { ... } is valid under each of {'required': ['spi-slave']},
>                                      {'required': ['#address-cells']}
> 
> We also need to drop #size-cells:
> 
>   arch/arm/boot/dts/mmp2-olpc-xo-1-75.dt.yaml: spi@d4037000:
>       '#address-cells' is a dependency of '#size-cells'
> 
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>

This patch causes the following warning to be issued when validating the
mmp2 DTS files against specific bindings:

arch/arm/boot/dts/mmp2.dtsi:472.23-480.6: Warning (spi_bus_bridge):
/soc/apb@d4000000/spi@d4037000: incorrect #address-cells for SPI bus
  also defined at arch/arm/boot/dts/mmp2-olpc-xo-1-75.dts:225.7-237.3
arch/arm/boot/dts/mmp2.dtsi:472.23-480.6: Warning (spi_bus_bridge):
/soc/apb@d4000000/spi@d4037000: incorrect #size-cells for SPI bus
  also defined at arch/arm/boot/dts/mmp2-olpc-xo-1-75.dts:225.7-237.3
arch/arm/boot/dts/mmp2-olpc-xo-1-75.dt.yaml: Warning (spi_bus_reg):
Failed prerequisite 'spi_bus_bridge'

Is there a fix that we can apply to silence this warning? Thanks!
-- 
Florian